Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] Fix MACHINE regex in runqemu
@ 2013-09-02 12:50 Mihai Prica
  2013-09-02 12:50 ` [PATCH 1/1] scripts/runqemu: Fix MACHINE regex Mihai Prica
  0 siblings, 1 reply; 2+ messages in thread
From: Mihai Prica @ 2013-09-02 12:50 UTC (permalink / raw)
  To: openembedded-core

The MACHINE variable wasn't correcty detected from a kernel filename.

The following changes since commit c7994f83baa678a4670472e1f037bfc16cb1e3be:

  bitbake: runqueue: Fix scenequeue to pass file descriptors, not a float (2013-09-02 09:16:24 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib mihaip/b2890
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=mihaip/b2890

Mihai Prica (1):
  scripts/runqemu: Fix MACHINE regex

 scripts/runqemu |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
1.7.9.5



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] scripts/runqemu: Fix MACHINE regex
  2013-09-02 12:50 [PATCH 0/1] Fix MACHINE regex in runqemu Mihai Prica
@ 2013-09-02 12:50 ` Mihai Prica
  0 siblings, 0 replies; 2+ messages in thread
From: Mihai Prica @ 2013-09-02 12:50 UTC (permalink / raw)
  To: openembedded-core

When runqemu tries to determine the MACHINE variable from a
kernel or vmdk filename that doesn't contain any known machine
name, the variable gets set to the filename. It should remain
unset and cause an error.

[YOCTO #2890]

Signed-off-by: Mihai Prica <mihai.prica@intel.com>
---
 scripts/runqemu |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index 04dc3b0..b496785 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -224,13 +224,13 @@ fi
 
 if [ -z "$MACHINE" ]; then
     if [ "x$FSTYPE" = "xvmdk" ]; then
-        MACHINE=`basename $VM | sed 's/.*\(qemux86-64\|qemux86\|qemuarm\|qemumips64\|qemumips\|qemuppc\|qemush4\).*/\1/'`
+        MACHINE=`basename $VM | sed -n 's/.*\(qemux86-64\|qemux86\|qemuarm\|qemumips64\|qemumips\|qemuppc\|qemush4\).*/\1/p'`
         if [ -z "$MACHINE" ]; then
             error "Unable to set MACHINE from vmdk filename [$VM]"
         fi
         echo "Set MACHINE to [$MACHINE] based on vmdk [$VM]"
     else
-        MACHINE=`basename $KERNEL | sed 's/.*\(qemux86-64\|qemux86\|qemuarm\|qemumips64\|qemumips\|qemuppc\|qemush4\).*/\1/'`
+        MACHINE=`basename $KERNEL | sed -n 's/.*\(qemux86-64\|qemux86\|qemuarm\|qemumips64\|qemumips\|qemuppc\|qemush4\).*/\1/p'`
         if [ -z "$MACHINE" ]; then
             error "Unable to set MACHINE from kernel filename [$KERNEL]"
         fi
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-02 12:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-02 12:50 [PATCH 0/1] Fix MACHINE regex in runqemu Mihai Prica
2013-09-02 12:50 ` [PATCH 1/1] scripts/runqemu: Fix MACHINE regex Mihai Prica

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox