* [PATCH 0/1] image.bbclass: do not automatically remove update-rc.d
@ 2013-09-13 2:09 Qi.Chen
2013-09-13 2:09 ` [PATCH 1/1] " Qi.Chen
0 siblings, 1 reply; 6+ messages in thread
From: Qi.Chen @ 2013-09-13 2:09 UTC (permalink / raw)
To: openembedded-core
From: Chen Qi <Qi.Chen@windriver.com>
The following changes since commit bd76847d867f9f76f76f033439cfb834cf59380f:
libnewt-python: Don't write a whiptail package (2013-09-12 08:23:42 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib ChenQi/do-not-remove-updatercd
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/do-not-remove-updatercd
Chen Qi (1):
image.bbclass: do not automatically remove update-rc.d
meta/classes/image.bbclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] image.bbclass: do not automatically remove update-rc.d
2013-09-13 2:09 [PATCH 0/1] image.bbclass: do not automatically remove update-rc.d Qi.Chen
@ 2013-09-13 2:09 ` Qi.Chen
2013-09-17 13:25 ` Richard Purdie
2013-09-22 3:13 ` ChenQi
0 siblings, 2 replies; 6+ messages in thread
From: Qi.Chen @ 2013-09-13 2:09 UTC (permalink / raw)
To: openembedded-core
From: Chen Qi <Qi.Chen@windriver.com>
In rootfs_uninstall_unneeded function, the update-rc.d package would
be removed if no 'package-management' and no delayed postinsts.
However, in update-rc.d.bbclass, the update-rc.d package is only
recommended. Thus, if NO_RECOMMENDATIONS is enabled or 'update-rc.d'
is added to BAD_RECOMMENDATIONS, the update-rc.d package will not
be installed at the first place. Tring to remove it will result in an
error.
Also this function assumes that update-rc.d is only used by postinsts.
This assumption isn't always true. Users may want to write their own
init scripts and use the update-rc.d tool to manage them.
[YOCTO #5169]
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
meta/classes/image.bbclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index f1e62f14..f37cd90 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -505,12 +505,12 @@ rootfs_uninstall_unneeded () {
if ${@base_contains("IMAGE_FEATURES", "package-management", "false", "true", d)}; then
if [ -z "$(delayed_postinsts)" ]; then
# All packages were successfully configured.
- # update-rc.d, base-passwd, run-postinsts are no further use, remove them now
+ # base-passwd, run-postinsts are no further use, remove them now
remove_run_postinsts=false
if [ -e ${IMAGE_ROOTFS}${sysconfdir}/init.d/run-postinsts ]; then
remove_run_postinsts=true
fi
- rootfs_uninstall_packages update-rc.d base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}
+ rootfs_uninstall_packages base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}
# Need to remove rc.d files for run-postinsts by hand since opkg won't
# call postrm scripts in offline root mode.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] image.bbclass: do not automatically remove update-rc.d
2013-09-13 2:09 ` [PATCH 1/1] " Qi.Chen
@ 2013-09-17 13:25 ` Richard Purdie
2013-09-22 3:13 ` ChenQi
1 sibling, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2013-09-17 13:25 UTC (permalink / raw)
To: Qi.Chen; +Cc: openembedded-core
On Fri, 2013-09-13 at 10:09 +0800, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> In rootfs_uninstall_unneeded function, the update-rc.d package would
> be removed if no 'package-management' and no delayed postinsts.
>
> However, in update-rc.d.bbclass, the update-rc.d package is only
> recommended. Thus, if NO_RECOMMENDATIONS is enabled or 'update-rc.d'
> is added to BAD_RECOMMENDATIONS, the update-rc.d package will not
> be installed at the first place. Tring to remove it will result in an
> error.
>
> Also this function assumes that update-rc.d is only used by postinsts.
> This assumption isn't always true. Users may want to write their own
> init scripts and use the update-rc.d tool to manage them.
>
> [YOCTO #5169]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> meta/classes/image.bbclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This is not correct. The correct behaviour here is to uninstall these
packages *if* they are installed. Just removing it from the list is not
the real fix.
Cheers,
Richard
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index f1e62f14..f37cd90 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -505,12 +505,12 @@ rootfs_uninstall_unneeded () {
> if ${@base_contains("IMAGE_FEATURES", "package-management", "false", "true", d)}; then
> if [ -z "$(delayed_postinsts)" ]; then
> # All packages were successfully configured.
> - # update-rc.d, base-passwd, run-postinsts are no further use, remove them now
> + # base-passwd, run-postinsts are no further use, remove them now
> remove_run_postinsts=false
> if [ -e ${IMAGE_ROOTFS}${sysconfdir}/init.d/run-postinsts ]; then
> remove_run_postinsts=true
> fi
> - rootfs_uninstall_packages update-rc.d base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}
> + rootfs_uninstall_packages base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}
>
> # Need to remove rc.d files for run-postinsts by hand since opkg won't
> # call postrm scripts in offline root mode.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] image.bbclass: do not automatically remove update-rc.d
2013-09-13 2:09 ` [PATCH 1/1] " Qi.Chen
2013-09-17 13:25 ` Richard Purdie
@ 2013-09-22 3:13 ` ChenQi
2013-09-22 8:44 ` Richard Purdie
1 sibling, 1 reply; 6+ messages in thread
From: ChenQi @ 2013-09-22 3:13 UTC (permalink / raw)
To: openembedded-core
ping
On 09/13/2013 10:09 AM, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> In rootfs_uninstall_unneeded function, the update-rc.d package would
> be removed if no 'package-management' and no delayed postinsts.
>
> However, in update-rc.d.bbclass, the update-rc.d package is only
> recommended. Thus, if NO_RECOMMENDATIONS is enabled or 'update-rc.d'
> is added to BAD_RECOMMENDATIONS, the update-rc.d package will not
> be installed at the first place. Tring to remove it will result in an
> error.
>
> Also this function assumes that update-rc.d is only used by postinsts.
> This assumption isn't always true. Users may want to write their own
> init scripts and use the update-rc.d tool to manage them.
>
> [YOCTO #5169]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> meta/classes/image.bbclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index f1e62f14..f37cd90 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -505,12 +505,12 @@ rootfs_uninstall_unneeded () {
> if ${@base_contains("IMAGE_FEATURES", "package-management", "false", "true", d)}; then
> if [ -z "$(delayed_postinsts)" ]; then
> # All packages were successfully configured.
> - # update-rc.d, base-passwd, run-postinsts are no further use, remove them now
> + # base-passwd, run-postinsts are no further use, remove them now
> remove_run_postinsts=false
> if [ -e ${IMAGE_ROOTFS}${sysconfdir}/init.d/run-postinsts ]; then
> remove_run_postinsts=true
> fi
> - rootfs_uninstall_packages update-rc.d base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}
> + rootfs_uninstall_packages base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}
>
> # Need to remove rc.d files for run-postinsts by hand since opkg won't
> # call postrm scripts in offline root mode.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] image.bbclass: do not automatically remove update-rc.d
2013-09-22 3:13 ` ChenQi
@ 2013-09-22 8:44 ` Richard Purdie
2013-09-22 9:23 ` ChenQi
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2013-09-22 8:44 UTC (permalink / raw)
To: ChenQi; +Cc: openembedded-core
On Sun, 2013-09-22 at 11:13 +0800, ChenQi wrote:
> ping
I replied to this:
"""
This is not correct. The correct behaviour here is to uninstall these
packages *if* they are installed. Just removing it from the list is not
the real fix.
"""
and I stand by that feedback.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] image.bbclass: do not automatically remove update-rc.d
2013-09-22 8:44 ` Richard Purdie
@ 2013-09-22 9:23 ` ChenQi
0 siblings, 0 replies; 6+ messages in thread
From: ChenQi @ 2013-09-22 9:23 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 09/22/2013 04:44 PM, Richard Purdie wrote:
> On Sun, 2013-09-22 at 11:13 +0800, ChenQi wrote:
>> ping
> I replied to this:
>
> """
> This is not correct. The correct behaviour here is to uninstall these
> packages *if* they are installed. Just removing it from the list is not
> the real fix.
> """
>
> and I stand by that feedback.
>
> Cheers,
>
> Richard
>
>
>
Thanks.
I'll send out a new patch.
Best Regards,
Chen Qi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-22 9:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-13 2:09 [PATCH 0/1] image.bbclass: do not automatically remove update-rc.d Qi.Chen
2013-09-13 2:09 ` [PATCH 1/1] " Qi.Chen
2013-09-17 13:25 ` Richard Purdie
2013-09-22 3:13 ` ChenQi
2013-09-22 8:44 ` Richard Purdie
2013-09-22 9:23 ` ChenQi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox