* [dora][PATCH 0/2] Dora backports
@ 2014-01-06 10:21 Martin Jansa
2014-01-06 10:21 ` [dora][PATCH 1/2] ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script Martin Jansa
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Martin Jansa @ 2014-01-06 10:21 UTC (permalink / raw)
To: openembedded-core
The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
Martin Jansa (1):
ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
Richard Purdie (1):
eglibc-initial.inc: Drop duplicate include
meta/conf/distro/include/default-providers.inc | 2 +
meta/recipes-core/eglibc/eglibc-initial.inc | 2 -
...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
meta/recipes-extended/ltp/ltp_20130503.bb | 4 +-
4 files changed, 207 insertions(+), 3 deletions(-)
create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
--
1.8.5.2
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dora][PATCH 1/2] ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
2014-01-06 10:21 [dora][PATCH 0/2] Dora backports Martin Jansa
@ 2014-01-06 10:21 ` Martin Jansa
2014-01-06 10:21 ` [dora][PATCH 2/2] eglibc-initial.inc: Drop duplicate include Martin Jansa
2014-01-10 6:18 ` [dora][PATCH 0/2] Dora backports Robert Yang
2 siblings, 0 replies; 9+ messages in thread
From: Martin Jansa @ 2014-01-06 10:21 UTC (permalink / raw)
To: openembedded-core
From: Martin Jansa <martin.jansa@gmail.com>
* ltp installs 2 different runtests_noltp.sh files from different
directories into /opt/ltp/testcases/bin/runtests_noltp.sh
last one installed wins and causes unexpected changes in
buildhistory's files-in-image.txt report, rename them to have
unique name as other ltp scripts have.
* also define PREFERRED_PROVIDER to resolve note shown when
building with meta-oe layer:
NOTE: multiple providers are available for ltp (ltp, ltp-ddt)
NOTE: consider defining a PREFERRED_PROVIDER entry to match ltp
* use patch generated without -M
in my builds both versions worked, but Saul reported that it fails to
apply with:
Applying patch
0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
patch: **** Only garbage was found in the patch input.
Now I've see the same issue on different builder (with Ubuntu 12.04).
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta/conf/distro/include/default-providers.inc | 2 +
...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
meta/recipes-extended/ltp/ltp_20130503.bb | 4 +-
3 files changed, 207 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
diff --git a/meta/conf/distro/include/default-providers.inc b/meta/conf/distro/include/default-providers.inc
index d4b9db0..e2b0892 100644
--- a/meta/conf/distro/include/default-providers.inc
+++ b/meta/conf/distro/include/default-providers.inc
@@ -43,3 +43,5 @@ PREFERRED_PROVIDER_udev ?= "${@base_contains('DISTRO_FEATURES','systemd','system
# There are issues with runtime packages and PREFERRED_PROVIDER, see YOCTO #5044 for details
# on this rather strange entry.
PREFERRED_PROVIDER_bluez4 ?= "bluez4"
+# Alternative is ltp-ddt in meta-oe: meta-oe/recipes-devtools/ltp-ddt/ltp-ddt_0.0.4.bb
+PREFERRED_PROVIDER_ltp ?= "ltp"
diff --git a/meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch b/meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
new file mode 100644
index 0000000..1b4d232
--- /dev/null
+++ b/meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
@@ -0,0 +1,202 @@
+From 9751a6526cffcdf4e3dc2cb33641259a7be00e19 Mon Sep 17 00:00:00 2001
+From: Martin Jansa <Martin.Jansa@gmail.com>
+Date: Sat, 7 Dec 2013 18:24:32 +0100
+Subject: [PATCH] Rename runtests_noltp.sh script so have unique name
+
+* they are installed in the same target path
+ /opt/ltp/testcases/bin/runtests_noltp.sh
+ and overwrite each other in non-deterministic way
+ when multiple processes are used in "make install"
+
+ ./temp/log.do_install:install -m 00775
+ "ltp/20120903-r2/ltp-20120903/testcases/kernel/containers/sysvipc/runtests_noltp.sh"
+ "ltp/20120903-r2/image/opt/ltp/testcases/bin/runtests_noltp.sh"
+ ./temp/log.do_install:install -m 00775
+ "ltp/20120903-r2/ltp-20120903/testcases/kernel/containers/utsname/runtests_noltp.sh"
+ "ltp/20120903-r2/image/opt/ltp/testcases/bin/runtests_noltp.sh"
+
+Upstream-Status: Pending
+
+Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
+---
+ .../kernel/containers/sysvipc/runipctests_noltp.sh | 31 ++++++++++++++++
+ .../kernel/containers/sysvipc/runtests_noltp.sh | 31 ----------------
+ .../kernel/containers/utsname/runtests_noltp.sh | 41 ----------------------
+ .../kernel/containers/utsname/runutstests_noltp.sh | 41 ++++++++++++++++++++++
+ 4 files changed, 72 insertions(+), 72 deletions(-)
+ create mode 100644 testcases/kernel/containers/sysvipc/runipctests_noltp.sh
+ delete mode 100644 testcases/kernel/containers/sysvipc/runtests_noltp.sh
+ delete mode 100755 testcases/kernel/containers/utsname/runtests_noltp.sh
+ create mode 100755 testcases/kernel/containers/utsname/runutstests_noltp.sh
+
+diff --git a/testcases/kernel/containers/sysvipc/runipctests_noltp.sh b/testcases/kernel/containers/sysvipc/runipctests_noltp.sh
+new file mode 100644
+index 0000000..84f398f
+--- /dev/null
++++ b/testcases/kernel/containers/sysvipc/runipctests_noltp.sh
+@@ -0,0 +1,31 @@
++#!/bin/sh
++################################################################################
++## ##
++## Copyright (c) International Business Machines Corp., 2007 ##
++## ##
++## This program is free software; you can redistribute it and#or modify ##
++## it under the terms of the GNU General Public License as published by ##
++## the Free Software Foundation; either version 2 of the License, or ##
++## (at your option) any later version. ##
++## ##
++## This program is distributed in the hope that it will be useful, but ##
++## WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY ##
++## or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License ##
++## for more details. ##
++## ##
++## You should have received a copy of the GNU General Public License ##
++## along with this program; if not, write to the Free Software ##
++## Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA ##
++## ##
++################################################################################
++
++exit_code=0
++echo "sysvipc tests"
++for type in none clone unshare; do
++ echo "**sysvipc $type"
++ ./shmnstest_noltp $type
++ if [ $? -ne 0 ]; then
++ exit_code=$?
++ fi
++done
++exit $exit_code
+diff --git a/testcases/kernel/containers/sysvipc/runtests_noltp.sh b/testcases/kernel/containers/sysvipc/runtests_noltp.sh
+deleted file mode 100644
+index 84f398f..0000000
+--- a/testcases/kernel/containers/sysvipc/runtests_noltp.sh
++++ /dev/null
+@@ -1,31 +0,0 @@
+-#!/bin/sh
+-################################################################################
+-## ##
+-## Copyright (c) International Business Machines Corp., 2007 ##
+-## ##
+-## This program is free software; you can redistribute it and#or modify ##
+-## it under the terms of the GNU General Public License as published by ##
+-## the Free Software Foundation; either version 2 of the License, or ##
+-## (at your option) any later version. ##
+-## ##
+-## This program is distributed in the hope that it will be useful, but ##
+-## WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY ##
+-## or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License ##
+-## for more details. ##
+-## ##
+-## You should have received a copy of the GNU General Public License ##
+-## along with this program; if not, write to the Free Software ##
+-## Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA ##
+-## ##
+-################################################################################
+-
+-exit_code=0
+-echo "sysvipc tests"
+-for type in none clone unshare; do
+- echo "**sysvipc $type"
+- ./shmnstest_noltp $type
+- if [ $? -ne 0 ]; then
+- exit_code=$?
+- fi
+-done
+-exit $exit_code
+diff --git a/testcases/kernel/containers/utsname/runtests_noltp.sh b/testcases/kernel/containers/utsname/runtests_noltp.sh
+deleted file mode 100755
+index 43cb7e2..0000000
+--- a/testcases/kernel/containers/utsname/runtests_noltp.sh
++++ /dev/null
+@@ -1,41 +0,0 @@
+-#!/bin/sh
+-################################################################################
+-## ##
+-## Copyright (c) International Business Machines Corp., 2007 ##
+-## ##
+-## This program is free software; you can redistribute it and#or modify ##
+-## it under the terms of the GNU General Public License as published by ##
+-## the Free Software Foundation; either version 2 of the License, or ##
+-## (at your option) any later version. ##
+-## ##
+-## This program is distributed in the hope that it will be useful, but ##
+-## WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY ##
+-## or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License ##
+-## for more details. ##
+-## ##
+-## You should have received a copy of the GNU General Public License ##
+-## along with this program; if not, write to the Free Software ##
+-## Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA ##
+-## ##
+-################################################################################
+-
+-oldhostname=`hostname`
+-exit_code=0
+-echo "unshare tests"
+-for i in `seq 1 5`; do
+- echo "test $i (unshare)"
+- ./utstest_noltp unshare $i
+- if [ $? -ne 0 ]; then
+- exit_code=$?
+- fi
+-done
+-echo "clone tests"
+-for i in `seq 1 5`; do
+- echo "test $i (clone)"
+- ./utstest_noltp clone $i
+- if [ $? -ne 0 ]; then
+- exit_code=$?
+- fi
+-done
+-hostname "$oldhostname"
+-exit $exit_code
+diff --git a/testcases/kernel/containers/utsname/runutstests_noltp.sh b/testcases/kernel/containers/utsname/runutstests_noltp.sh
+new file mode 100755
+index 0000000..43cb7e2
+--- /dev/null
++++ b/testcases/kernel/containers/utsname/runutstests_noltp.sh
+@@ -0,0 +1,41 @@
++#!/bin/sh
++################################################################################
++## ##
++## Copyright (c) International Business Machines Corp., 2007 ##
++## ##
++## This program is free software; you can redistribute it and#or modify ##
++## it under the terms of the GNU General Public License as published by ##
++## the Free Software Foundation; either version 2 of the License, or ##
++## (at your option) any later version. ##
++## ##
++## This program is distributed in the hope that it will be useful, but ##
++## WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY ##
++## or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License ##
++## for more details. ##
++## ##
++## You should have received a copy of the GNU General Public License ##
++## along with this program; if not, write to the Free Software ##
++## Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA ##
++## ##
++################################################################################
++
++oldhostname=`hostname`
++exit_code=0
++echo "unshare tests"
++for i in `seq 1 5`; do
++ echo "test $i (unshare)"
++ ./utstest_noltp unshare $i
++ if [ $? -ne 0 ]; then
++ exit_code=$?
++ fi
++done
++echo "clone tests"
++for i in `seq 1 5`; do
++ echo "test $i (clone)"
++ ./utstest_noltp clone $i
++ if [ $? -ne 0 ]; then
++ exit_code=$?
++ fi
++done
++hostname "$oldhostname"
++exit $exit_code
+--
+1.8.4.3
+
diff --git a/meta/recipes-extended/ltp/ltp_20130503.bb b/meta/recipes-extended/ltp/ltp_20130503.bb
index 387826d..9e1183c 100644
--- a/meta/recipes-extended/ltp/ltp_20130503.bb
+++ b/meta/recipes-extended/ltp/ltp_20130503.bb
@@ -21,7 +21,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
DEPENDS = "attr libaio libcap acl openssl"
-SRC_URI = "${SOURCEFORGE_MIRROR}/ltp/ltp-full-${PV}.bz2"
+SRC_URI = "${SOURCEFORGE_MIRROR}/ltp/ltp-full-${PV}.bz2 \
+ file://0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch \
+"
SRC_URI[md5sum] = "d448d9e9731d7ef45352fc74633cc97f"
SRC_URI[sha256sum] = "afdb1479e73d4da7f0d4d5d3fe1570bc5fc96e3317d4a5c10c59c046d3dfa4a0"
--
1.8.5.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [dora][PATCH 2/2] eglibc-initial.inc: Drop duplicate include
2014-01-06 10:21 [dora][PATCH 0/2] Dora backports Martin Jansa
2014-01-06 10:21 ` [dora][PATCH 1/2] ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script Martin Jansa
@ 2014-01-06 10:21 ` Martin Jansa
2014-01-10 6:18 ` [dora][PATCH 0/2] Dora backports Robert Yang
2 siblings, 0 replies; 9+ messages in thread
From: Martin Jansa @ 2014-01-06 10:21 UTC (permalink / raw)
To: openembedded-core
From: Richard Purdie <richard.purdie@linuxfoundation.org>
There is little point in including the file twice so lets not. The
main recipe already included it.
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
meta/recipes-core/eglibc/eglibc-initial.inc | 2 --
1 file changed, 2 deletions(-)
diff --git a/meta/recipes-core/eglibc/eglibc-initial.inc b/meta/recipes-core/eglibc/eglibc-initial.inc
index 83b1d2c..0f0e1cd 100644
--- a/meta/recipes-core/eglibc/eglibc-initial.inc
+++ b/meta/recipes-core/eglibc/eglibc-initial.inc
@@ -1,5 +1,3 @@
-require eglibc-common.inc
-
DEPENDS = "linux-libc-headers virtual/${TARGET_PREFIX}gcc-initial"
PROVIDES = "virtual/${TARGET_PREFIX}libc-initial"
--
1.8.5.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [dora][PATCH 0/2] Dora backports
2014-01-06 10:21 [dora][PATCH 0/2] Dora backports Martin Jansa
2014-01-06 10:21 ` [dora][PATCH 1/2] ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script Martin Jansa
2014-01-06 10:21 ` [dora][PATCH 2/2] eglibc-initial.inc: Drop duplicate include Martin Jansa
@ 2014-01-10 6:18 ` Robert Yang
2014-01-10 10:41 ` Richard Purdie
2014-01-10 11:02 ` Martin Jansa
2 siblings, 2 replies; 9+ messages in thread
From: Robert Yang @ 2014-01-10 6:18 UTC (permalink / raw)
To: Martin Jansa, openembedded-core
Hi Martin,
Thanks, please see my comments in line.
On 01/06/2014 06:21 PM, Martin Jansa wrote:
> The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
>
> libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
>
> are available in the git repository at:
>
> git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
>
> Martin Jansa (1):
> ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
>
I will take this.
> Richard Purdie (1):
> eglibc-initial.inc: Drop duplicate include
>
It seems that this is a trivial fix, I don't think it's a good idea to merge
it to dora.
// Robert
> meta/conf/distro/include/default-providers.inc | 2 +
> meta/recipes-core/eglibc/eglibc-initial.inc | 2 -
> ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
> meta/recipes-extended/ltp/ltp_20130503.bb | 4 +-
> 4 files changed, 207 insertions(+), 3 deletions(-)
> create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dora][PATCH 0/2] Dora backports
2014-01-10 6:18 ` [dora][PATCH 0/2] Dora backports Robert Yang
@ 2014-01-10 10:41 ` Richard Purdie
2014-01-10 16:51 ` Mark Hatle
2014-01-10 11:02 ` Martin Jansa
1 sibling, 1 reply; 9+ messages in thread
From: Richard Purdie @ 2014-01-10 10:41 UTC (permalink / raw)
To: Robert Yang; +Cc: openembedded-core
On Fri, 2014-01-10 at 14:18 +0800, Robert Yang wrote:
> Hi Martin,
>
> Thanks, please see my comments in line.
>
> On 01/06/2014 06:21 PM, Martin Jansa wrote:
> > The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
> >
> > libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
> >
> > are available in the git repository at:
> >
> > git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
> > http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
> >
> > Martin Jansa (1):
> > ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
> >
>
> I will take this.
>
> > Richard Purdie (1):
> > eglibc-initial.inc: Drop duplicate include
> >
>
>
> It seems that this is a trivial fix, I don't think it's a good idea to merge
> it to dora.
Thanks to one of the bitbake patches we backported, this "trivial" issue
is now putting warnings in peoples builds so I think it might be a good
idea to fix it.
Cheers,
Richard
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dora][PATCH 0/2] Dora backports
2014-01-10 6:18 ` [dora][PATCH 0/2] Dora backports Robert Yang
2014-01-10 10:41 ` Richard Purdie
@ 2014-01-10 11:02 ` Martin Jansa
2014-01-13 1:54 ` Robert Yang
1 sibling, 1 reply; 9+ messages in thread
From: Martin Jansa @ 2014-01-10 11:02 UTC (permalink / raw)
To: Robert Yang; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]
On Fri, Jan 10, 2014 at 02:18:51PM +0800, Robert Yang wrote:
>
> Hi Martin,
>
> Thanks, please see my comments in line.
>
> On 01/06/2014 06:21 PM, Martin Jansa wrote:
> > The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
> >
> > libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
> >
> > are available in the git repository at:
> >
> > git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
> > http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
> >
> > Martin Jansa (1):
> > ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
> >
>
> I will take this.
>
> > Richard Purdie (1):
> > eglibc-initial.inc: Drop duplicate include
> >
>
>
> It seems that this is a trivial fix, I don't think it's a good idea to merge
> it to dora.
And the warning shown in every dora build since
http://git.openembedded.org/bitbake/commit/?h=1.20&id=22e6b1c4c4afb27057689bbc94cbdf1f19f93e3d
isn't important enough reason to merge it?
>
> // Robert
>
> > meta/conf/distro/include/default-providers.inc | 2 +
> > meta/recipes-core/eglibc/eglibc-initial.inc | 2 -
> > ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
> > meta/recipes-extended/ltp/ltp_20130503.bb | 4 +-
> > 4 files changed, 207 insertions(+), 3 deletions(-)
> > create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
> >
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dora][PATCH 0/2] Dora backports
2014-01-10 10:41 ` Richard Purdie
@ 2014-01-10 16:51 ` Mark Hatle
2014-01-11 15:11 ` Koen Kooi
0 siblings, 1 reply; 9+ messages in thread
From: Mark Hatle @ 2014-01-10 16:51 UTC (permalink / raw)
To: openembedded-core
On 1/10/14, 4:41 AM, Richard Purdie wrote:
> On Fri, 2014-01-10 at 14:18 +0800, Robert Yang wrote:
>> Hi Martin,
>>
>> Thanks, please see my comments in line.
>>
>> On 01/06/2014 06:21 PM, Martin Jansa wrote:
>>> The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
>>>
>>> libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
>>>
>>> are available in the git repository at:
>>>
>>> git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
>>> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
>>>
>>> Martin Jansa (1):
>>> ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
>>>
>>
>> I will take this.
>>
>>> Richard Purdie (1):
>>> eglibc-initial.inc: Drop duplicate include
>>>
>>
>>
>> It seems that this is a trivial fix, I don't think it's a good idea to merge
>> it to dora.
>
> Thanks to one of the bitbake patches we backported, this "trivial" issue
> is now putting warnings in peoples builds so I think it might be a good
> idea to fix it.
Ya I agree. This is going to cause confusion for people. Being a small 2 line
patch, and pretty easy to show that it's "safe". I'd also recommend that that
backport be accepted.
--Mark
> Cheers,
>
> Richard
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dora][PATCH 0/2] Dora backports
2014-01-10 16:51 ` Mark Hatle
@ 2014-01-11 15:11 ` Koen Kooi
0 siblings, 0 replies; 9+ messages in thread
From: Koen Kooi @ 2014-01-11 15:11 UTC (permalink / raw)
To: OE-core
Op 10 jan. 2014, om 17:51 heeft Mark Hatle <mark.hatle@windriver.com> het volgende geschreven:
> On 1/10/14, 4:41 AM, Richard Purdie wrote:
>> On Fri, 2014-01-10 at 14:18 +0800, Robert Yang wrote:
>>> Hi Martin,
>>>
>>> Thanks, please see my comments in line.
>>>
>>> On 01/06/2014 06:21 PM, Martin Jansa wrote:
>>>> The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
>>>>
>>>> libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
>>>>
>>>> are available in the git repository at:
>>>>
>>>> git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
>>>> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
>>>>
>>>> Martin Jansa (1):
>>>> ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
>>>>
>>>
>>> I will take this.
>>>
>>>> Richard Purdie (1):
>>>> eglibc-initial.inc: Drop duplicate include
>>>>
>>>
>>>
>>> It seems that this is a trivial fix, I don't think it's a good idea to merge
>>> it to dora.
>>
>> Thanks to one of the bitbake patches we backported, this "trivial" issue
>> is now putting warnings in peoples builds so I think it might be a good
>> idea to fix it.
>
> Ya I agree. This is going to cause confusion for people. Being a small 2 line patch, and pretty easy to show that it's "safe". I'd also recommend that that backport be accepted.
I agree as well.
regards,
Koen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dora][PATCH 0/2] Dora backports
2014-01-10 11:02 ` Martin Jansa
@ 2014-01-13 1:54 ` Robert Yang
0 siblings, 0 replies; 9+ messages in thread
From: Robert Yang @ 2014-01-13 1:54 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-core
On 01/10/2014 07:02 PM, Martin Jansa wrote:
> On Fri, Jan 10, 2014 at 02:18:51PM +0800, Robert Yang wrote:
>>
>> Hi Martin,
>>
>> Thanks, please see my comments in line.
>>
>> On 01/06/2014 06:21 PM, Martin Jansa wrote:
>>> The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
>>>
>>> libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
>>>
>>> are available in the git repository at:
>>>
>>> git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
>>> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
>>>
>>> Martin Jansa (1):
>>> ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
>>>
>>
>> I will take this.
>>
>>> Richard Purdie (1):
>>> eglibc-initial.inc: Drop duplicate include
>>>
>>
>>
>> It seems that this is a trivial fix, I don't think it's a good idea to merge
>> it to dora.
>
> And the warning shown in every dora build since
> http://git.openembedded.org/bitbake/commit/?h=1.20&id=22e6b1c4c4afb27057689bbc94cbdf1f19f93e3d
> isn't important enough reason to merge it?
>
OK, thanks to all, I will take it.
// Robert
>>
>> // Robert
>>
>>> meta/conf/distro/include/default-providers.inc | 2 +
>>> meta/recipes-core/eglibc/eglibc-initial.inc | 2 -
>>> ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
>>> meta/recipes-extended/ltp/ltp_20130503.bb | 4 +-
>>> 4 files changed, 207 insertions(+), 3 deletions(-)
>>> create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
>>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-01-13 1:54 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-06 10:21 [dora][PATCH 0/2] Dora backports Martin Jansa
2014-01-06 10:21 ` [dora][PATCH 1/2] ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script Martin Jansa
2014-01-06 10:21 ` [dora][PATCH 2/2] eglibc-initial.inc: Drop duplicate include Martin Jansa
2014-01-10 6:18 ` [dora][PATCH 0/2] Dora backports Robert Yang
2014-01-10 10:41 ` Richard Purdie
2014-01-10 16:51 ` Mark Hatle
2014-01-11 15:11 ` Koen Kooi
2014-01-10 11:02 ` Martin Jansa
2014-01-13 1:54 ` Robert Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox