Openembedded Core Discussions
 help / color / mirror / Atom feed
* [Patch v2 0/1] A fix for QA_check
@ 2014-03-04 23:28 nitin.a.kamble
  2014-03-04 23:28 ` [Patch v2 1/1] QA_check: special case kernel modules for x32 targets nitin.a.kamble
  0 siblings, 1 reply; 2+ messages in thread
From: nitin.a.kamble @ 2014-03-04 23:28 UTC (permalink / raw)
  To: pb, saul.wold, Openembedded-core

From: Nitin A Kamble <nitin.a.kamble@intel.com>

This v2 fix is improved as per feedback from Phil Blundell <pb@pbcl.net>

Thanks,
Nitin

The following changes since commit 83b3e3e8e34a2512bcb1fe298715ece58c83dca3:

  package_manager.py: RpmPM: don't add smart channel if already added (2014-03-03 15:05:32 -0800)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib nitin/fix1
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=nitin/fix1

Nitin A Kamble (1):
  QA_check: special case kernel modules for x32 targets

 meta/classes/insane.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
1.8.1.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Patch v2 1/1] QA_check: special case kernel modules for x32 targets
  2014-03-04 23:28 [Patch v2 0/1] A fix for QA_check nitin.a.kamble
@ 2014-03-04 23:28 ` nitin.a.kamble
  0 siblings, 0 replies; 2+ messages in thread
From: nitin.a.kamble @ 2014-03-04 23:28 UTC (permalink / raw)
  To: pb, saul.wold, Openembedded-core

From: Nitin A Kamble <nitin.a.kamble@intel.com>

The Kernel module packages for x32 target have 64 bit binaries, which
breaks the QA_check expecting all the packages to be 32bit.

Make a special case for kernel module packages for x32 targets, to avoid
this false error.

Fixes Bug:
[YOCTO #5903]

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/classes/insane.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index cf00e12..1195c10 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -443,11 +443,11 @@ def package_qa_check_arch(path,name,d, elf, messages):
 
     # Check the architecture and endiannes of the binary
     if not ((machine == elf.machine()) or \
-        ("virtual/kernel" in provides) and (target_os == "linux-gnux32")):
+        ((("virtual/kernel" in provides) or bb.data.inherits_class("module", d) ) and (target_os == "linux-gnux32"))):
         messages.append("Architecture did not match (%d to %d) on %s" % \
                  (machine, elf.machine(), package_qa_clean_path(path,d)))
     elif not ((bits == elf.abiSize()) or  \
-        ("virtual/kernel" in provides) and (target_os == "linux-gnux32")):
+        ((("virtual/kernel" in provides) or bb.data.inherits_class("module", d) ) and (target_os == "linux-gnux32"))):
         messages.append("Bit size did not match (%d to %d) %s on %s" % \
                  (bits, elf.abiSize(), bpn, package_qa_clean_path(path,d)))
     elif not littleendian == elf.isLittleEndian():
-- 
1.8.1.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-04 23:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04 23:28 [Patch v2 0/1] A fix for QA_check nitin.a.kamble
2014-03-04 23:28 ` [Patch v2 1/1] QA_check: special case kernel modules for x32 targets nitin.a.kamble

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox