Openembedded Core Discussions
 help / color / mirror / Atom feed
* [dylan][PATCH 0/1] Fix for eglibc-initial failure for 1.4.3
@ 2014-03-17 23:13 Paul Eggleton
  2014-03-17 23:13 ` [dylan][PATCH 1/1] sstate: Drop 'SafeDep' code from setscene validation function Paul Eggleton
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Eggleton @ 2014-03-17 23:13 UTC (permalink / raw)
  To: openembedded-core

Fixes the eglibc-initial do_configure failure seen on the Yocto Project
autobuilder. Backported from master. 


The following change since commit c3f1bedb2494a2465db23a4d89b9f998db953f0d:

  rpm: Enable compatibility with older RPM packages that have invalid platforms (2014-03-12 19:00:34 +0000)

is available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib paule/dylan-sstate
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/dylan-sstate

Richard Purdie (1):
  sstate: Drop 'SafeDep' code from setscene validation function

 meta/classes/sstate.bbclass | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

-- 
1.8.5.3



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dylan][PATCH 1/1] sstate: Drop 'SafeDep' code from setscene validation function
  2014-03-17 23:13 [dylan][PATCH 0/1] Fix for eglibc-initial failure for 1.4.3 Paul Eggleton
@ 2014-03-17 23:13 ` Paul Eggleton
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggleton @ 2014-03-17 23:13 UTC (permalink / raw)
  To: openembedded-core

From: Richard Purdie <richard.purdie@linuxfoundation.org>

I have a feeling this code exists from the time before we had proper
coverage of one sstate task by another task. At that time it was a
"poor" persons version of that idea, we now have much better
code internal to bitbake which handles this.

Worse, this code actually breaks certain rebuild scenarios,
e.g.:

bitbake libtool-cross
bitbake libtool-cross -c cleansstate
rm tmp -rf
bitbake libtool-cross

would fail as binutils-cross wasn't installed from sstate.

The easiest fix is to remove the obsolete/broken code.

[YOCTO #5773]

(From OE-Core master rev: ccad07f35fb7f959e24fd50d04c7d10dd5cf20d0)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/sstate.bbclass | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index 0358d14..13abf33 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -639,19 +639,12 @@ def setscene_depvalid(task, taskdependees, notneeded, d):
         return x.endswith("-native")
     def isNativeCross(x):
         return x.endswith("-native") or x.endswith("-cross") or x.endswith("-cross-initial")
-    def isSafeDep(x):
-        if x in ["quilt-native", "autoconf-native", "automake-native", "gnu-config-native", "libtool-native", "pkgconfig-native", "gcc-cross", "binutils-cross", "gcc-cross-initial"]:
-            return True
-        return False
+
     def isPostInstDep(x):
         if x in ["qemu-native", "gdk-pixbuf-native", "qemuwrapper-cross", "depmodwrapper-cross", "systemd-systemctl-native", "gtk-update-icon-cache-native"]:
             return True
         return False
 
-    # We can skip these "safe" dependencies since the aren't runtime dependencies, just build time
-    if isSafeDep(taskdependees[task][0]) and taskdependees[task][1] == "do_populate_sysroot":
-        return True
-
     # We only need to trigger populate_lic through direct dependencies
     if taskdependees[task][1] == "do_populate_lic":
         return True
-- 
1.8.5.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-17 23:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-17 23:13 [dylan][PATCH 0/1] Fix for eglibc-initial failure for 1.4.3 Paul Eggleton
2014-03-17 23:13 ` [dylan][PATCH 1/1] sstate: Drop 'SafeDep' code from setscene validation function Paul Eggleton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox