[PATCH 0/1] librsvg: disable Bsymbolic if it is not supported on some hosts

[PATCH 0/1] librsvg: disable Bsymbolic if it is not supported on some hosts

[Chong Lu]

The following changes since commit 59b0f7f01bbac6f1c10ee00382c5136d1f327960:

  chrpath: Drop warning from darwn builds (2014-08-17 10:01:36 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib chonglu/librsvg
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/librsvg

Chong Lu (1):
  librsvg: disable Bsymbolic if it is not supported on some hosts

 meta/recipes-gnome/librsvg/librsvg_2.40.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

[PATCH 1/1] librsvg: disable Bsymbolic if it is not supported on some hosts

[Chong Lu]

When trying to build on my Centos 5.5 machine, got below error:
| checking for gdk-pixbuf-query-loaders... /home/build/clu1/build/qemux86_standard_glibc-std/bitbake_build/tmp/sysroots/x86_64-linux/usr/bin/gdk-pixbuf-query-loaders
| checking if gcc  supports "-Wl,-Bsymbolic-functions" flag...
| configure: error: -Bsymbolic requested but not supported by ld. Use --disable-Bsymbolic to disable
| Configure failed. The contents of all config.log files follows to aid debugging
| ERROR: oe_runconf failed

Set --enable-Bsymbolic=auto to disable it when it is not suppported.

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
 meta/recipes-gnome/librsvg/librsvg_2.40.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb b/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb
index 34d8ca1..d288d4b 100644
--- a/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb
+++ b/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb
@@ -20,7 +20,7 @@ SRC_URI += "file://gtk-option.patch \
 SRC_URI[archive.md5sum] = "acdecdb9f08f3bf662a68bf7dafb8b82"
 SRC_URI[archive.sha256sum] = "48049b643294636df7de1a4b997414d699666f5dc44776945c218a257d2a291c"
 
-EXTRA_OECONF = "--disable-introspection --disable-vala"
+EXTRA_OECONF = "--disable-introspection --disable-vala --enable-Bsymbolic=auto"
 
 PACKAGECONFIG ??= "gdkpixbuf"
 # The gdk-pixbuf loader
-- 
1.9.1

Re: [PATCH 1/1] librsvg: disable Bsymbolic if it is not supported on some hosts

[Richard Purdie]

On Mon, 2014-08-18 at 14:26 +0800, Chong Lu wrote:
> When trying to build on my Centos 5.5 machine, got below error:
> | checking for gdk-pixbuf-query-loaders... /home/build/clu1/build/qemux86_standard_glibc-std/bitbake_build/tmp/sysroots/x86_64-linux/usr/bin/gdk-pixbuf-query-loaders
> | checking if gcc  supports "-Wl,-Bsymbolic-functions" flag...
> | configure: error: -Bsymbolic requested but not supported by ld. Use --disable-Bsymbolic to disable
> | Configure failed. The contents of all config.log files follows to aid debugging
> | ERROR: oe_runconf failed
> 
> Set --enable-Bsymbolic=auto to disable it when it is not suppported.
> 
> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> ---
>  meta/recipes-gnome/librsvg/librsvg_2.40.2.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb b/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb
> index 34d8ca1..d288d4b 100644
> --- a/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb
> +++ b/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb
> @@ -20,7 +20,7 @@ SRC_URI += "file://gtk-option.patch \
>  SRC_URI[archive.md5sum] = "acdecdb9f08f3bf662a68bf7dafb8b82"
>  SRC_URI[archive.sha256sum] = "48049b643294636df7de1a4b997414d699666f5dc44776945c218a257d2a291c"
>  
> -EXTRA_OECONF = "--disable-introspection --disable-vala"
> +EXTRA_OECONF = "--disable-introspection --disable-vala --enable-Bsymbolic=auto"

Please can you add a comment in to the recipe alongside this explaining
why we need to do this. In 12 months time, nobody will be able to
remember why we're passing in this option without looking at the
history.

Also, we only need this in the -native case, correct?

Cheers,

Richard

>  PACKAGECONFIG ??= "gdkpixbuf"
>  # The gdk-pixbuf loader
> -- 
> 1.9.1
>