[PATCH 0/1] piglit: add bash to RDEPENDS_piglit

[PATCH 0/1] piglit: add bash to RDEPENDS_piglit

[Robert Yang]

The following changes since commit 4c0a9ccbad2889b27b4b1d2ab91215a4bdcca3ce:

  python-numpy: Fix build for mips64 (2014-09-01 18:00:32 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/piglit
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/piglit

Robert Yang (1):
  piglit: add bash to RDEPENDS_piglit

 meta/recipes-graphics/piglit/piglit_git.bb |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
1.7.9.5

[PATCH 1/1] piglit: add bash to RDEPENDS_piglit

[Robert Yang]

Bash:
piglit/usr/lib/piglit/tests/asmparsertest/make_test_list.sh:#!/bin/bash
piglit/usr/lib/piglit/tests/asmparsertest/vp-tex.sh:#!/bin/bash
piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-read.sh:#!/bin/bash
piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-write.sh:#!/bin/bash
piglit/usr/lib/piglit/tests/spec/arb_shader_texture_lod/compiler/make_tex_lod_tests.sh:#!/bin/bash
piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct-const.sh:#!/bin/bash
piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct.sh:#!/bin/bash
piglit/usr/lib/piglit/tests/spec/glsl-1.20/compiler/built-in-functions/outerProduct-invalid-parameters.sh:#!/bin/bash
piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_lod_tests.sh:#!/bin/bash
piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_rect_tests.sh:#!/bin/bash

The bash scripts are in the tests directory, we had planned to move the
tests into the ptest pkg, but that would make piglit unusable without
installing piglit-ptest.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-graphics/piglit/piglit_git.bb |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/piglit/piglit_git.bb b/meta/recipes-graphics/piglit/piglit_git.bb
index 5c013ef..f468120 100644
--- a/meta/recipes-graphics/piglit/piglit_git.bb
+++ b/meta/recipes-graphics/piglit/piglit_git.bb
@@ -45,4 +45,7 @@ do_install() {
 
 FILES_${PN}-dbg += "${libdir}/piglit/*/.debug/"
 
-RDEPENDS_${PN} = "python waffle python-json python-subprocess python-multiprocessing python-textutils python-netserver python-shell mesa-demos"
+RDEPENDS_${PN} = "python waffle python-json python-subprocess \
+	python-multiprocessing python-textutils python-netserver python-shell \
+	mesa-demos bash \
+	"
-- 
1.7.9.5

Re: [PATCH 1/1] piglit: add bash to RDEPENDS_piglit

[Henning Heinold]

On Tue, Sep 02, 2014 at 02:41:49AM -0700, Robert Yang wrote:
> Bash:
> piglit/usr/lib/piglit/tests/asmparsertest/make_test_list.sh:#!/bin/bash
> piglit/usr/lib/piglit/tests/asmparsertest/vp-tex.sh:#!/bin/bash
> piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-read.sh:#!/bin/bash
> piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-write.sh:#!/bin/bash
> piglit/usr/lib/piglit/tests/spec/arb_shader_texture_lod/compiler/make_tex_lod_tests.sh:#!/bin/bash
> piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct-const.sh:#!/bin/bash
> piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct.sh:#!/bin/bash
> piglit/usr/lib/piglit/tests/spec/glsl-1.20/compiler/built-in-functions/outerProduct-invalid-parameters.sh:#!/bin/bash
> piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_lod_tests.sh:#!/bin/bash
> piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_rect_tests.sh:#!/bin/bash
> 
> The bash scripts are in the tests directory, we had planned to move the
> tests into the ptest pkg, but that would make piglit unusable without
> installing piglit-ptest.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/recipes-graphics/piglit/piglit_git.bb |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-graphics/piglit/piglit_git.bb b/meta/recipes-graphics/piglit/piglit_git.bb
> index 5c013ef..f468120 100644
> --- a/meta/recipes-graphics/piglit/piglit_git.bb
> +++ b/meta/recipes-graphics/piglit/piglit_git.bb
> @@ -45,4 +45,7 @@ do_install() {
>  
>  FILES_${PN}-dbg += "${libdir}/piglit/*/.debug/"
>  
> -RDEPENDS_${PN} = "python waffle python-json python-subprocess python-multiprocessing python-textutils python-netserver python-shell mesa-demos"
> +RDEPENDS_${PN} = "python waffle python-json python-subprocess \
> +	python-multiprocessing python-textutils python-netserver python-shell \
> +	mesa-demos bash \
> +	"
> -- 

Hi Robert,

how about to split out the tests into an extra package and let the package depends on bash?

Bye Henning

Re: [PATCH 1/1] piglit: add bash to RDEPENDS_piglit

[Robert Yang]

On 09/02/2014 05:52 PM, Henning Heinold wrote:
> On Tue, Sep 02, 2014 at 02:41:49AM -0700, Robert Yang wrote:
>> Bash:
>> piglit/usr/lib/piglit/tests/asmparsertest/make_test_list.sh:#!/bin/bash
>> piglit/usr/lib/piglit/tests/asmparsertest/vp-tex.sh:#!/bin/bash
>> piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-read.sh:#!/bin/bash
>> piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-write.sh:#!/bin/bash
>> piglit/usr/lib/piglit/tests/spec/arb_shader_texture_lod/compiler/make_tex_lod_tests.sh:#!/bin/bash
>> piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct-const.sh:#!/bin/bash
>> piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct.sh:#!/bin/bash
>> piglit/usr/lib/piglit/tests/spec/glsl-1.20/compiler/built-in-functions/outerProduct-invalid-parameters.sh:#!/bin/bash
>> piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_lod_tests.sh:#!/bin/bash
>> piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_rect_tests.sh:#!/bin/bash
>>
>> The bash scripts are in the tests directory, we had planned to move the
>> tests into the ptest pkg, but that would make piglit unusable without
>> installing piglit-ptest.
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta/recipes-graphics/piglit/piglit_git.bb |    5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-graphics/piglit/piglit_git.bb b/meta/recipes-graphics/piglit/piglit_git.bb
>> index 5c013ef..f468120 100644
>> --- a/meta/recipes-graphics/piglit/piglit_git.bb
>> +++ b/meta/recipes-graphics/piglit/piglit_git.bb
>> @@ -45,4 +45,7 @@ do_install() {
>>
>>   FILES_${PN}-dbg += "${libdir}/piglit/*/.debug/"
>>
>> -RDEPENDS_${PN} = "python waffle python-json python-subprocess python-multiprocessing python-textutils python-netserver python-shell mesa-demos"
>> +RDEPENDS_${PN} = "python waffle python-json python-subprocess \
>> +	python-multiprocessing python-textutils python-netserver python-shell \
>> +	mesa-demos bash \
>> +	"
>> --
>
> Hi Robert,
>
> how about to split out the tests into an extra package and let the package depends on bash?

That was the initial plan, but it didn't work as Ross commented, please
see this thread for more info:

http://lists.openembedded.org/pipermail/openembedded-core/2014-August/096438.html

// Robert

>
> Bye Henning
>

Re: [PATCH 1/1] piglit: add bash to RDEPENDS_piglit

[Burton, Ross]

On 2 September 2014 10:52, Henning Heinold
<henning@itconsulting-heinold.de> wrote:
> how about to split out the tests into an extra package and let the package depends on bash?

Piglit is a test suite.  A test suite without tests doesn't make sense. :)

Ross

Re: [PATCH 1/1] piglit: add bash to RDEPENDS_piglit

[Burton, Ross]

On 2 September 2014 10:41, Robert Yang <liezhi.yang@windriver.com> wrote:
> The bash scripts are in the tests directory, we had planned to move the
> tests into the ptest pkg, but that would make piglit unusable without
> installing piglit-ptest.

Will there be a follow-up to add the ptest support?

Ross

Re: [PATCH 1/1] piglit: add bash to RDEPENDS_piglit

[Robert Yang]

On 09/02/2014 06:19 PM, Burton, Ross wrote:
> On 2 September 2014 10:41, Robert Yang <liezhi.yang@windriver.com> wrote:
>> The bash scripts are in the tests directory, we had planned to move the
>> tests into the ptest pkg, but that would make piglit unusable without
>> installing piglit-ptest.
>
> Will there be a follow-up to add the ptest support?

Yes, I think so, Chong had done that, he will update the ptest patch.

// Robert

>
> Ross
>
>