* [PATCH 0/1] Fix a runtime issue with the create-pull-request script
@ 2015-02-24 19:19 nitin.a.kamble
2015-02-24 19:19 ` [PATCH 1/1] create-pull-request: fix failure with git version 1.8.1.4 nitin.a.kamble
0 siblings, 1 reply; 2+ messages in thread
From: nitin.a.kamble @ 2015-02-24 19:19 UTC (permalink / raw)
To: Openembedded-core, richard.purdie, saul.wold
From: Nitin A Kamble <nitin.a.kamble@intel.com>
This commit fixes the create-pull-request script failure with certain versions of the git.
Thanks,
Nitin
The following changes since commit 4d83a90bfb5a41deb81ca8878363a89fccf95d89:
gst-plugins-package.inc: Avoid dependency on ${PN} from ${PN}-<plugin> (2015-02-24 17:41:44 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib nitin/misc
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=nitin/misc
Nitin A Kamble (1):
create-pull-request: fix failure with git version 1.8.1.4
scripts/create-pull-request | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.8.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH 1/1] create-pull-request: fix failure with git version 1.8.1.4
2015-02-24 19:19 [PATCH 0/1] Fix a runtime issue with the create-pull-request script nitin.a.kamble
@ 2015-02-24 19:19 ` nitin.a.kamble
0 siblings, 0 replies; 2+ messages in thread
From: nitin.a.kamble @ 2015-02-24 19:19 UTC (permalink / raw)
To: Openembedded-core, richard.purdie, saul.wold
From: Nitin A Kamble <nitin.a.kamble@intel.com>
As seen below, this script fails with git versions having more than 3 digit.
$> ../poky.git/scripts/create-pull-request -b nitin/misc -u contrib -r master.origin
fatal: No such ref: :nitin/misc
fatal: Needed a single revision
ERROR: git request-pull reported an error
Fix it by considering only the top 3 digits of the git version.
Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
scripts/create-pull-request | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/create-pull-request b/scripts/create-pull-request
index d83362f..a85c83f 100755
--- a/scripts/create-pull-request
+++ b/scripts/create-pull-request
@@ -178,7 +178,7 @@ git format-patch -M40 --subject-prefix="$PREFIX" -n -o $ODIR --thread=shallow --
# Customize the cover letter
CL="$ODIR/0000-cover-letter.patch"
PM="$ODIR/pull-msg"
-GIT_VERSION=$(`git --version` | tr -d '[:alpha:][:space:].')
+GIT_VERSION=$(`git --version` | tr -d '[:alpha:][:space:].' | sed "s/\(...\)\(.*\)/\1/" )
NEWER_GIT_VERSION=210
if [ $GIT_VERSION -lt $NEWER_GIT_VERSION ]; then
git request-pull $RELATIVE_TO $REMOTE_URL $COMMIT_ID >> "$PM"
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-24 19:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-24 19:19 [PATCH 0/1] Fix a runtime issue with the create-pull-request script nitin.a.kamble
2015-02-24 19:19 ` [PATCH 1/1] create-pull-request: fix failure with git version 1.8.1.4 nitin.a.kamble
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox