* [PATCH 1/1] classes/report-error: expand variable values
2015-07-09 10:40 [PATCH 0/1] Fix report-error BUILDNAME usage Paul Eggleton
@ 2015-07-09 10:40 ` Paul Eggleton
0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggleton @ 2015-07-09 10:40 UTC (permalink / raw)
To: openembedded-core
Even if the values for these variables typically don't contain
expressions, we should be expanding them just in case they do. The
recent fix for BUILDNAME resetting within BitBake now means that
BUILDNAME defaults to "${DATE}${TIME}" for example so we definitely
need to expand that.
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
meta/classes/report-error.bbclass | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/meta/classes/report-error.bbclass b/meta/classes/report-error.bbclass
index 11eee9b..dda0986 100644
--- a/meta/classes/report-error.bbclass
+++ b/meta/classes/report-error.bbclass
@@ -32,11 +32,11 @@ python errorreport_handler () {
if isinstance(e, bb.event.BuildStarted):
bb.utils.mkdirhier(logpath)
data = {}
- machine = e.data.getVar("MACHINE", False)
+ machine = e.data.getVar("MACHINE", True)
data['machine'] = machine
data['build_sys'] = e.data.getVar("BUILD_SYS", True)
- data['nativelsb'] = e.data.getVar("NATIVELSBSTRING", False)
- data['distro'] = e.data.getVar("DISTRO", False)
+ data['nativelsb'] = e.data.getVar("NATIVELSBSTRING", True)
+ data['distro'] = e.data.getVar("DISTRO", True)
data['target_sys'] = e.data.getVar("TARGET_SYS", True)
data['failures'] = []
data['component'] = e.getPkgs()[0]
@@ -73,7 +73,7 @@ python errorreport_handler () {
bb.utils.unlockfile(lock)
failures = jsondata['failures']
if(len(failures) > 0):
- filename = "error_report_" + e.data.getVar("BUILDNAME", False)+".txt"
+ filename = "error_report_" + e.data.getVar("BUILDNAME", True) + ".txt"
datafile = errorreport_savedata(e, jsondata, filename)
bb.note("The errors for this build are stored in %s\nYou can send the errors to a reports server by running:\n send-error-report %s [-s server]" % (datafile, datafile))
bb.note("The contents of these logs will be posted in public if you use the above command with the default server. Please ensure you remove any identifying or proprietary information when prompted before sending.")
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread