Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] Fix ext SDK building with shared sstate-cache
@ 2015-10-16 10:34 Paul Eggleton
  2015-10-16 10:34 ` [PATCH 1/1] scripts/gen-lockedsig-cache: fix race with temp file creation Paul Eggleton
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Eggleton @ 2015-10-16 10:34 UTC (permalink / raw)
  To: openembedded-core

The following changes since commit 10e5df3503632a6e1c54612055b19f7258c3ae2f:

  lib/oe/image.py: Fix dependency handling for compressed types (2015-10-14 18:08:22 +0300)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib paule/extsdk-sstate-race
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/extsdk-sstate-race

Paul Eggleton (1):
  scripts/gen-lockedsig-cache: fix race with temp file creation

 scripts/gen-lockedsig-cache | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.1.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] scripts/gen-lockedsig-cache: fix race with temp file creation
  2015-10-16 10:34 [PATCH 0/1] Fix ext SDK building with shared sstate-cache Paul Eggleton
@ 2015-10-16 10:34 ` Paul Eggleton
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggleton @ 2015-10-16 10:34 UTC (permalink / raw)
  To: openembedded-core

As part of populating the sstate-cache with an artifact (.tgz file) we
create a temp file and then atomically move it to the final name. Due to
the glob used in this script such temp files were being matched, and
between the time they were matched and the time the script started
copying files, the temp file may have vanished.

This fixes random "No such file or directory" failures building the
extensible SDK on build setups where the sstate-cache directory is shared
amongst multiple build machines.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 scripts/gen-lockedsig-cache | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/gen-lockedsig-cache b/scripts/gen-lockedsig-cache
index c93b2c0..806c1e4 100755
--- a/scripts/gen-lockedsig-cache
+++ b/scripts/gen-lockedsig-cache
@@ -34,6 +34,10 @@ for s in sigs:
     files |= set(glob.glob(p))
 
 for f in files:
+    _, ext = os.path.splitext(f)
+    if not ext in ['.tgz', '.siginfo', '.sig']:
+        # Most likely a temp file, skip it
+        continue
     dst = f.replace(sys.argv[2], sys.argv[3])
     destdir = os.path.dirname(dst)
     mkdir(destdir)
-- 
2.1.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-16 10:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-16 10:34 [PATCH 0/1] Fix ext SDK building with shared sstate-cache Paul Eggleton
2015-10-16 10:34 ` [PATCH 1/1] scripts/gen-lockedsig-cache: fix race with temp file creation Paul Eggleton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox