[PATCH 0/2] Fix more potential build failures

[PATCH 0/2] Fix more potential build failures

[Jussi Kukkonen]

Decided to run a build/cleansstate/wipe-sysroot/re-build cycle for
all recipes in world: Only found the intltool failures Ross already
sent patches for and these two.

 Jussi

The following changes since commit 6c1c01392d91f512e2949ad1d57a75a8077478ba:

  build-appliance-image: Update to krogoth head revision (2016-04-19 21:26:33 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib jku/more-build-fixes
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/more-build-fixes

Jussi Kukkonen (2):
  babeltrace: Let autotools.bbclass run autoreconf
  gcc-sanitizers: Depend on target gcc

 meta/recipes-devtools/gcc/gcc-sanitizers.inc  | 2 +-
 meta/recipes-kernel/lttng/babeltrace_1.3.1.bb | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)

-- 
2.1.4

[PATCH 1/2] babeltrace: Let autotools.bbclass run autoreconf

[Jussi Kukkonen]

When bootstrap calls autoreconf, it won't have AC_LOCAL set properly
so shared scripts may not be found: glib-2.0.m4 in this case.

Remove custom bootstrap code so autotools class handles this.

Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
---
 meta/recipes-kernel/lttng/babeltrace_1.3.1.bb | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/meta/recipes-kernel/lttng/babeltrace_1.3.1.bb b/meta/recipes-kernel/lttng/babeltrace_1.3.1.bb
index 1766026..6f4cb85 100644
--- a/meta/recipes-kernel/lttng/babeltrace_1.3.1.bb
+++ b/meta/recipes-kernel/lttng/babeltrace_1.3.1.bb
@@ -18,7 +18,3 @@ SRC_URI = "git://git.efficios.com/babeltrace.git;branch=stable-1.3 \
 "
 
 S = "${WORKDIR}/git"
-
-do_configure_prepend () {
-	( cd ${S}; ${S}/bootstrap )
-}
-- 
2.1.4

[PATCH 2/2] gcc-sanitizers: Depend on target gcc

[Jussi Kukkonen]

Without this the target gcc might not be in the sysroot
leading to configure failure.

Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
---
 meta/recipes-devtools/gcc/gcc-sanitizers.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gcc/gcc-sanitizers.inc b/meta/recipes-devtools/gcc/gcc-sanitizers.inc
index 6091a0b..df4e297 100644
--- a/meta/recipes-devtools/gcc/gcc-sanitizers.inc
+++ b/meta/recipes-devtools/gcc/gcc-sanitizers.inc
@@ -50,7 +50,7 @@ do_install () {
 
 INHIBIT_DEFAULT_DEPS = "1"
 ALLOW_EMPTY_${PN} = "1"
-DEPENDS = "gcc-runtime"
+DEPENDS = "gcc-runtime virtual/${TARGET_PREFIX}gcc"
 
 BBCLASSEXTEND = "nativesdk"
 
-- 
2.1.4

Re: [PATCH 2/2] gcc-sanitizers: Depend on target gcc

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]


> On Apr 22, 2016, at 6:26 AM, Jussi Kukkonen <jussi.kukkonen@intel.com> wrote:
> 
> Without this the target gcc might not be in the sysroot
> leading to configure failure.

you might want to correct the comment to say cross gcc. Thats whats added to DEPENDS here
and not target gcc.

> 
> Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
> ---
> meta/recipes-devtools/gcc/gcc-sanitizers.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/gcc/gcc-sanitizers.inc b/meta/recipes-devtools/gcc/gcc-sanitizers.inc
> index 6091a0b..df4e297 100644
> --- a/meta/recipes-devtools/gcc/gcc-sanitizers.inc
> +++ b/meta/recipes-devtools/gcc/gcc-sanitizers.inc
> @@ -50,7 +50,7 @@ do_install () {
> 
> INHIBIT_DEFAULT_DEPS = "1"
> ALLOW_EMPTY_${PN} = "1"
> -DEPENDS = "gcc-runtime"
> +DEPENDS = "gcc-runtime virtual/${TARGET_PREFIX}gcc"
> 
> BBCLASSEXTEND = "nativesdk"
> 
> --
> 2.1.4
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH 2/2] gcc-sanitizers: Depend on target gcc

[Dan McGregor]

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

On 22 Apr 2016 7:27 a.m., "Jussi Kukkonen" <jussi.kukkonen@intel.com> wrote:
>
> Without this the target gcc might not be in the sysroot
> leading to configure failure.
>
> Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
> ---
>  meta/recipes-devtools/gcc/gcc-sanitizers.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-sanitizers.inc
b/meta/recipes-devtools/gcc/gcc-sanitizers.inc
> index 6091a0b..df4e297 100644
> --- a/meta/recipes-devtools/gcc/gcc-sanitizers.inc
> +++ b/meta/recipes-devtools/gcc/gcc-sanitizers.inc
> @@ -50,7 +50,7 @@ do_install () {
>
>  INHIBIT_DEFAULT_DEPS = "1"
>  ALLOW_EMPTY_${PN} = "1"
> -DEPENDS = "gcc-runtime"
> +DEPENDS = "gcc-runtime virtual/${TARGET_PREFIX}gcc"
>
>  BBCLASSEXTEND = "nativesdk"
>
> --
> 2.1.4
>

I agree with Khem. Otherwise looks good to me.

> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #2: Type: text/html, Size: 1670 bytes --]

Re: [PATCH 2/2] gcc-sanitizers: Depend on target gcc

[Jussi Kukkonen]

On 22 April 2016 at 20:21, Khem Raj <raj.khem@gmail.com> wrote:
>> On Apr 22, 2016, at 6:26 AM, Jussi Kukkonen <jussi.kukkonen@intel.com> wrote:
>>
>> Without this the target gcc might not be in the sysroot
>> leading to configure failure.
>
> you might want to correct the comment to say cross gcc. Thats whats added to DEPENDS here
> and not target gcc.

Thanks. I've force pushed the above change in the repo:

  git://git.yoctoproject.org/poky-contrib jku/more-build-fixes
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/more-build-fixes

Jussi