[PATCHv3 0/1] selftest: Add test to check imports from other layers

[PATCHv3 0/1] selftest: Add test to check imports from other layers

[mariano.lopez]

From: Mariano Lopez <mariano.lopez@linux.intel.com>

This patch adds a test to check selftest itself, the
feature to import tests from other layers.

Changes in v2:

- Renamed tests based on Benjamin's comment

Changes in v3:

- Refactor test to not use oe-selftest within oe-selftest

The following changes since commit 1bf1e2c208ad137b9b91ca0687d6fb9486045dfd:

  bitbake: toaster-tests: add class SeleniumTestCaseBase for browser tests (2016-07-20 10:38:52 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib mariano/bug9770v3
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=mariano/bug9770v3

Mariano Lopez (1):
  selftest/seltest.py: Add test to check imports from other layers

 meta-selftest/lib/oeqa/selftest/external-layer.py | 14 +++++++
 meta/lib/oeqa/selftest/selftest.py                | 50 +++++++++++++++++++++++
 2 files changed, 64 insertions(+)
 create mode 100644 meta-selftest/lib/oeqa/selftest/external-layer.py
 create mode 100644 meta/lib/oeqa/selftest/selftest.py

-- 
2.6.6

[PATCHv3 1/1] selftest/seltest.py: Add test to check imports from other layers

[mariano.lopez]

From: Mariano Lopez <mariano.lopez@linux.intel.com>

This tests adds a check of selftest itself to verify if can
add test from other layers.

[YOCTO #9770]

Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com>
---
 meta-selftest/lib/oeqa/selftest/external-layer.py | 14 +++++++
 meta/lib/oeqa/selftest/selftest.py                | 50 +++++++++++++++++++++++
 2 files changed, 64 insertions(+)
 create mode 100644 meta-selftest/lib/oeqa/selftest/external-layer.py
 create mode 100644 meta/lib/oeqa/selftest/selftest.py

diff --git a/meta-selftest/lib/oeqa/selftest/external-layer.py b/meta-selftest/lib/oeqa/selftest/external-layer.py
new file mode 100644
index 0000000..224ab36
--- /dev/null
+++ b/meta-selftest/lib/oeqa/selftest/external-layer.py
@@ -0,0 +1,14 @@
+from oeqa.selftest.base import oeSelfTest
+from oeqa.utils.decorators import testcase
+
+class ImportedTests(oeSelfTest):
+
+    def test_unconditional_pass(self):
+        """
+        Summary: Doesn't check anything, used to check import test from other layers.
+        Expected: 1. Pass unconditionally
+        Product: oe-core
+        Author: Mariano Lopez <mariano.lopez@intel.comr
+        """
+
+        self.assertEqual(True, True, msg = "Impossible to fail this test")
diff --git a/meta/lib/oeqa/selftest/selftest.py b/meta/lib/oeqa/selftest/selftest.py
new file mode 100644
index 0000000..7850c4b
--- /dev/null
+++ b/meta/lib/oeqa/selftest/selftest.py
@@ -0,0 +1,50 @@
+import importlib
+import oeqa.selftest
+from oeqa.selftest.base import oeSelfTest
+from oeqa.utils.commands import runCmd
+from oeqa.utils.decorators import testcase
+
+class ExternalLayer(oeSelfTest):
+
+    def test_list_imported(self):
+        """
+        Summary: Checks functionality to import tests from other layers.
+        Expected: 1. File "external-layer.py" must be in
+                     oeqa.selftest.__path__
+                  2. test_unconditional_pass method must exists
+                     in ImportedTests class
+        Product: oe-core
+        Author: Mariano Lopez <mariano.lopez@intel.com>
+        """
+
+        #test_name = "external-layer.ImportedTests.test_unconditional_pass"
+        test_file = "external-layer.py"
+        test_module = "oeqa.selftest.external-layer"
+        method_name = "test_unconditional_pass"
+
+        # Check if "external-layer.py" is in oeqa path
+        found_file = search_test_file(test_file)
+        self.assertTrue(found_file, msg="Can't find %s in the oeqa path" % test_file)
+
+        # Import oeqa.selftest.external-layer module and search for
+        # test_unconditional_pass method of ImportedTests class
+        found_method = search_method(test_module, method_name)
+        self.assertTrue(method_name, msg="Can't find %s method" % method_name)
+
+def search_test_file(file_name):
+    for layer_path in oeqa.selftest.__path__:
+        for _, _, files in os.walk(layer_path):
+            for f in files:
+                if f == file_name:
+                    return True
+    return False
+
+def search_method(module, method):
+    modlib = importlib.import_module(module)
+    for var in vars(modlib):
+        klass = vars(modlib)[var]
+        if isinstance(klass, type(oeSelfTest)) and issubclass(klass, oeSelfTest):
+            for m in dir(klass):
+                if m == method:
+                    return True
+    return False
-- 
2.6.6