Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] run-postinsts: Use opkg/dpkg to configure when possible
@ 2016-11-04 13:16 Jussi Kukkonen
  2016-11-04 13:16 ` [PATCH 1/1] " Jussi Kukkonen
  0 siblings, 1 reply; 2+ messages in thread
From: Jussi Kukkonen @ 2016-11-04 13:16 UTC (permalink / raw)
  To: openembedded-core

run-postinst has not been using package managers to configure the
packages: the code was there all along but a bug prevented it from
being used.

I was hesitating sending this a bit as it felt quite difficult to test
comprehensively and the change is not completely trivial: as an example
the order of postinsts will likely change as it's now handled by the
package manager instead of OE. I can still run more tests if anyone
has good ideas...



Cheers, 
  Jussi


The following changes since commit c3d2df883a9d6d5036277114339673656d89a728:

  oeqa/selftest/kernel.py: Add new file destined for kernel related tests (2016-11-01 10:05:46 +0000)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib jku/10478
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/10478

Jussi Kukkonen (1):
  run-postinsts: Use opkg/dpkg to configure when possible

 .../recipes-devtools/run-postinsts/run-postinsts/run-postinsts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

-- 
2.1.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] run-postinsts: Use opkg/dpkg to configure when possible
  2016-11-04 13:16 [PATCH 0/1] run-postinsts: Use opkg/dpkg to configure when possible Jussi Kukkonen
@ 2016-11-04 13:16 ` Jussi Kukkonen
  0 siblings, 0 replies; 2+ messages in thread
From: Jussi Kukkonen @ 2016-11-04 13:16 UTC (permalink / raw)
  To: openembedded-core

Currently run-postinsts script has code to run postinst scripts
via opkg/dpkg configure but that code is never used. The advantage
of using package managers instead of just executing the scripts is
to keep the package manager DB updated.

Fix the script so that the package managers are used when appropriate.
Also use $localstatedir for the opkg runtime file location.

Fixes [YOCTO #10478].

Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
---
 .../recipes-devtools/run-postinsts/run-postinsts/run-postinsts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts
index 04ba394..10f2118 100755
--- a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts
+++ b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts
@@ -16,23 +16,25 @@ pm_installed=false
 for pm in $backend_list; do
 	pi_dir="#SYSCONFDIR#/$pm-postinsts"
 
-	[ -d $pi_dir ] && break
+	if [ ! -d $pi_dir ]; then
+		continue
+	fi
 
+	# found the package manager, it has postinsts
 	case $pm in
 		"deb")
 			if [ -s "#LOCALSTATEDIR#/lib/dpkg/status" ]; then
 				pm_installed=true
-				break
 			fi
 			;;
 
 		"ipk")
-			if [ -s "/var/lib/opkg/status" ]; then
+			if [ -s "#LOCALSTATEDIR#/lib/opkg/status" ]; then
 				pm_installed=true
-				break
 			fi
 			;;
 	esac
+	break
 done
 
 remove_rcsd_link () {
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-04 13:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-04 13:16 [PATCH 0/1] run-postinsts: Use opkg/dpkg to configure when possible Jussi Kukkonen
2016-11-04 13:16 ` [PATCH 1/1] " Jussi Kukkonen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox