[PATCH 0/1] trace-cmd: fix QA warning

[PATCH 0/1] trace-cmd: fix QA warning

[Dengke Du]

The following changes since commit c3d2df883a9d6d5036277114339673656d89a728:

  oeqa/selftest/kernel.py: Add new file destined for kernel related tests (2016-11-01 10:05:46 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib dengke/fix-trace_cmd-QA-warning
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=dengke/fix-trace_cmd-QA-warning

Dengke Du (1):
  trace-cmd: fix QA warning

 meta/recipes-kernel/trace-cmd/trace-cmd_git.bb | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.7.4

[PATCH 1/1] trace-cmd: fix QA warning

[Dengke Du]

Add PACKAGECONFIG for audit.

Signed-off-by: Dengke Du <dengke.du@windriver.com>
---
 meta/recipes-kernel/trace-cmd/trace-cmd_git.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd_git.bb b/meta/recipes-kernel/trace-cmd/trace-cmd_git.bb
index dd9a8a0..05f5f9a 100644
--- a/meta/recipes-kernel/trace-cmd/trace-cmd_git.bb
+++ b/meta/recipes-kernel/trace-cmd/trace-cmd_git.bb
@@ -9,6 +9,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
                     file://trace-input.c;beginline=5;endline=8;md5=3ec82f43bbe0cfb5951ff414ef4d44d0 \
 "
 
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[audit] = ",,audit"
+
 EXTRA_OEMAKE = "\
     'prefix=${prefix}' \
     'bindir=${bindir}' \
@@ -20,6 +23,7 @@ EXTRA_OEMAKE = "\
     'libdir=${@oe.path.relative(prefix, libdir)}' \
     \
     NO_PYTHON=1 \
+    ${@bb.utils.contains('PACKAGECONFIG', 'audit', '', 'NO_AUDIT=1', d)} \
 "
 
 do_compile_prepend() {
-- 
2.7.4

Re: [PATCH 1/1] trace-cmd: fix QA warning

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 753 bytes --]

On 5 November 2016 at 05:29, Dengke Du <dengke.du@windriver.com> wrote:

> +PACKAGECONFIG ??= ""
> +PACKAGECONFIG[audit] = ",,audit"
> +
>  EXTRA_OEMAKE = "\
>      'prefix=${prefix}' \
>      'bindir=${bindir}' \
> @@ -20,6 +23,7 @@ EXTRA_OEMAKE = "\
>      'libdir=${@oe.path.relative(prefix, libdir)}' \
>      \
>      NO_PYTHON=1 \
> +    ${@bb.utils.contains('PACKAGECONFIG', 'audit', '', 'NO_AUDIT=1', d)}
> \
>  "
>

A neater way of doing this would be:

PACKAGECONFIG ??= ""
PACKAGECONFIG[audit] = ',NO_AUDIT=1,audit'
EXTRA_OECMAKE = ".... ${PACKAGECONFIG_CONFARGS}"

This works as the PACKAGECONFIG expansion adds the active expressions to
PACKAGECONFIG_CONFARGS, so you can add that directly to EXTRA_OEMAKE.

Ross

[-- Attachment #2: Type: text/html, Size: 1592 bytes --]