[PATCH 0/1] populate_sdk_ext.bbclass: check unfsd before create it

[PATCH 0/1] populate_sdk_ext.bbclass: check unfsd before create it

[Robert Yang]

The following changes since commit 58de12eaaac9c60bb8fc84a3a965ef86d2a39ae0:

  distro_check: partial rewrite to make it work again (2016-11-06 23:35:23 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/ext
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/ext

Robert Yang (1):
  populate_sdk_ext.bbclass: check unfsd before create it

 meta/classes/populate_sdk_ext.bbclass | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.9.0

[PATCH 1/1] populate_sdk_ext.bbclass: check unfsd before create it

[Robert Yang]

Fixed when nativesdk-unfs3 is installed:
$ bitbake <image> -c populate_sdk_ext
| Traceback (most recent call last):
|   File "/path/to/oe-core/scripts/lnr", line 21, in <module>
|     os.symlink(target, linkname)
| FileExistsError: [Errno 17] File exists: '../../../../tmp/sysroots/x86_64-linux/usr/bin/unfsd' -> '/path/to/9.0/sysroots/x86_64-wrlinuxsdk-linux/usr/bin/unfsd'

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/populate_sdk_ext.bbclass | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
index a0856d4..26b5ca6 100644
--- a/meta/classes/populate_sdk_ext.bbclass
+++ b/meta/classes/populate_sdk_ext.bbclass
@@ -502,9 +502,10 @@ install_tools() {
 	done
 	# We can't use the same method as above because files in the sysroot won't exist at this point
 	# (they get populated from sstate on installation)
-	if [ "${SDK_INCLUDE_TOOLCHAIN}" == "1" ] ; then
+	unfsd_path="${SDK_OUTPUT}/${SDKPATHNATIVE}${bindir_nativesdk}/unfsd"
+	if [ "${SDK_INCLUDE_TOOLCHAIN}" == "1" -a ! -e $unfsd_path ] ; then
 		binrelpath=${@os.path.relpath(d.getVar('STAGING_BINDIR_NATIVE',True), d.getVar('TOPDIR', True))}
-		lnr ${SDK_OUTPUT}/${SDKPATH}/$binrelpath/unfsd ${SDK_OUTPUT}/${SDKPATHNATIVE}${bindir_nativesdk}/unfsd
+		lnr ${SDK_OUTPUT}/${SDKPATH}/$binrelpath/unfsd $unfsd_path
 	fi
 	touch ${SDK_OUTPUT}/${SDKPATH}/.devtoolbase
 
-- 
2.9.0

Re: ✗ patchtest: failure for populate_sdk_ext.bbclass: check unfsd before create it

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

On 7 November 2016 at 08:55, Patchwork <patchwork@patchwork.openembedded.org
> wrote:

> Test Name        test_signed_off_by_presence
> Proposed Fix     Sign off the patch
> Commit shortlog  populate_sdk_ext.bbclass: check unfsd before create it
>

The patch has a s-o-b, so this is a false positive.  Is this checking the
cover letter instead of the patch?

Ross

[-- Attachment #2: Type: text/html, Size: 902 bytes --]