* [PATCH 0/1] kernel-devsrc: remove symlink source @ 2016-11-29 9:16 Robert Yang 2016-11-29 9:16 ` [PATCH 1/1] " Robert Yang 2017-02-16 8:17 ` [PATCH 0/1] " Robert Yang 0 siblings, 2 replies; 5+ messages in thread From: Robert Yang @ 2016-11-29 9:16 UTC (permalink / raw) To: openembedded-core The following changes since commit af280990bff4a484fd8a18e3442b56a0a39b7611: Revert "classes/populate_sdk_ext: require uninative" (2016-11-28 14:49:37 +0000) are available in the git repository at: git://git.openembedded.org/openembedded-core-contrib rbt/kernel http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/kernel Robert Yang (1): kernel-devsrc: remove symlink source meta/recipes-kernel/linux/kernel-devsrc.bb | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.9.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] kernel-devsrc: remove symlink source 2016-11-29 9:16 [PATCH 0/1] kernel-devsrc: remove symlink source Robert Yang @ 2016-11-29 9:16 ` Robert Yang 2016-11-29 10:57 ` Bruce Ashfield 2017-02-16 8:17 ` [PATCH 0/1] " Robert Yang 1 sibling, 1 reply; 5+ messages in thread From: Robert Yang @ 2016-11-29 9:16 UTC (permalink / raw) To: openembedded-core Fixed: $ rpm -qplv tmp/deploy/rpm/qemuppc/kernel-devsrc-1.0-r0.qemuppc.rpm | grep kernel/source /usr/src/kernel/source -> /buildarea/lyang1/test_yocto/tmp/work/qemuppc-poky-linux/kernel-devsrc/1.0-r0/image/usr/src/kernel It is generated by kernel's "make clean _mrproper_scripts", the kernel-devsrc includeds full sources, this symlink is not needed, and the path is invalid on target, so remove it. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- meta/recipes-kernel/linux/kernel-devsrc.bb | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb index 9fd2e08..b182936 100644 --- a/meta/recipes-kernel/linux/kernel-devsrc.bb +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb @@ -53,6 +53,13 @@ do_install() { # architecture (since scripts and helpers are native format). KBUILD_OUTPUT="$kerneldir" oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean _mrproper_scripts + # make clean generates an absolute path symlink called "source" + # in $kerneldir points to $kerneldir, which doesn't make any + # sense, so remove it. + if [ -L $kerneldir/source ]; then + bbnote "Removing $kerneldir/source" + rm -f $kerneldir/source + fi # As of Linux kernel version 3.0.1, the clean target removes # arch/powerpc/lib/crtsavres.o which is present in -- 2.9.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] kernel-devsrc: remove symlink source 2016-11-29 9:16 ` [PATCH 1/1] " Robert Yang @ 2016-11-29 10:57 ` Bruce Ashfield 2016-11-30 2:21 ` Robert Yang 0 siblings, 1 reply; 5+ messages in thread From: Bruce Ashfield @ 2016-11-29 10:57 UTC (permalink / raw) To: Robert Yang; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 2178 bytes --] On Tue, Nov 29, 2016 at 4:16 AM, Robert Yang <liezhi.yang@windriver.com> wrote: > Fixed: > $ rpm -qplv tmp/deploy/rpm/qemuppc/kernel-devsrc-1.0-r0.qemuppc.rpm | > grep kernel/source > /usr/src/kernel/source -> /buildarea/lyang1/test_yocto/ > tmp/work/qemuppc-poky-linux/kernel-devsrc/1.0-r0/image/usr/src/kernel > > It is generated by kernel's "make clean _mrproper_scripts", the > kernel-devsrc includeds full sources, this symlink is not needed, and > the path is invalid on target, so remove it. > > Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > --- > meta/recipes-kernel/linux/kernel-devsrc.bb | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb > b/meta/recipes-kernel/linux/kernel-devsrc.bb > index 9fd2e08..b182936 100644 > --- a/meta/recipes-kernel/linux/kernel-devsrc.bb > +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb > @@ -53,6 +53,13 @@ do_install() { > # architecture (since scripts and helpers are native format). > KBUILD_OUTPUT="$kerneldir" > oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" > clean _mrproper_scripts > + # make clean generates an absolute path symlink called "source" > + # in $kerneldir points to $kerneldir, which doesn't make any > + # sense, so remove it. > + if [ -L $kerneldir/source ]; then > + bbnote "Removing $kerneldir/source" > This message needs to be clarified. When that comes out, I'd read it and think "it is removing my kernel source". Maybe: bbnote "Removing $kerneldir/source symlink" is better. Bruce > + rm -f $kerneldir/source > + fi > > # As of Linux kernel version 3.0.1, the clean target removes > # arch/powerpc/lib/crtsavres.o which is present in > -- > 2.9.0 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" [-- Attachment #2: Type: text/html, Size: 3732 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] kernel-devsrc: remove symlink source 2016-11-29 10:57 ` Bruce Ashfield @ 2016-11-30 2:21 ` Robert Yang 0 siblings, 0 replies; 5+ messages in thread From: Robert Yang @ 2016-11-30 2:21 UTC (permalink / raw) To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer On 11/29/2016 06:57 PM, Bruce Ashfield wrote: > > > On Tue, Nov 29, 2016 at 4:16 AM, Robert Yang <liezhi.yang@windriver.com > <mailto:liezhi.yang@windriver.com>> wrote: > > Fixed: > $ rpm -qplv tmp/deploy/rpm/qemuppc/kernel-devsrc-1.0-r0.qemuppc.rpm | grep > kernel/source > /usr/src/kernel/source -> > /buildarea/lyang1/test_yocto/tmp/work/qemuppc-poky-linux/kernel-devsrc/1.0-r0/image/usr/src/kernel > > It is generated by kernel's "make clean _mrproper_scripts", the > kernel-devsrc includeds full sources, this symlink is not needed, and > the path is invalid on target, so remove it. > > Signed-off-by: Robert Yang <liezhi.yang@windriver.com > <mailto:liezhi.yang@windriver.com>> > --- > meta/recipes-kernel/linux/kernel-devsrc.bb <http://kernel-devsrc.bb> | 7 > +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb > <http://kernel-devsrc.bb> b/meta/recipes-kernel/linux/kernel-devsrc.bb > <http://kernel-devsrc.bb> > index 9fd2e08..b182936 100644 > --- a/meta/recipes-kernel/linux/kernel-devsrc.bb <http://kernel-devsrc.bb> > +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb <http://kernel-devsrc.bb> > @@ -53,6 +53,13 @@ do_install() { > # architecture (since scripts and helpers are native format). > KBUILD_OUTPUT="$kerneldir" > oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean > _mrproper_scripts > + # make clean generates an absolute path symlink called "source" > + # in $kerneldir points to $kerneldir, which doesn't make any > + # sense, so remove it. > + if [ -L $kerneldir/source ]; then > + bbnote "Removing $kerneldir/source" > > > This message needs to be clarified. When that comes out, I'd read it and think > "it is removing my kernel source". > > Maybe: > > bbnote "Removing $kerneldir/source symlink" > > is better. Thanks, updated in the repo: diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb index 9fd2e08..7004261 100644 --- a/meta/recipes-kernel/linux/kernel-devsrc.bb +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb @@ -53,6 +53,13 @@ do_install() { # architecture (since scripts and helpers are native format). KBUILD_OUTPUT="$kerneldir" oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean _mrproper_scripts + # make clean generates an absolute path symlink called "source" + # in $kerneldir points to $kerneldir, which doesn't make any + # sense, so remove it. + if [ -L $kerneldir/source ]; then + bbnote "Removing $kerneldir/source symlink" + rm -f $kerneldir/source + fi # As of Linux kernel version 3.0.1, the clean target removes # arch/powerpc/lib/crtsavres.o which is present in // Robert > > Bruce > > > + rm -f $kerneldir/source > + fi > > # As of Linux kernel version 3.0.1, the clean target removes > # arch/powerpc/lib/crtsavres.o which is present in > -- > 2.9.0 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > <mailto:Openembedded-core@lists.openembedded.org> > http://lists.openembedded.org/mailman/listinfo/openembedded-core > <http://lists.openembedded.org/mailman/listinfo/openembedded-core> > > > > > -- > "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its > end" ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/1] kernel-devsrc: remove symlink source 2016-11-29 9:16 [PATCH 0/1] kernel-devsrc: remove symlink source Robert Yang 2016-11-29 9:16 ` [PATCH 1/1] " Robert Yang @ 2017-02-16 8:17 ` Robert Yang 1 sibling, 0 replies; 5+ messages in thread From: Robert Yang @ 2017-02-16 8:17 UTC (permalink / raw) To: openembedded-core Ping. // Robert On 11/29/2016 05:16 PM, Robert Yang wrote: > The following changes since commit af280990bff4a484fd8a18e3442b56a0a39b7611: > > Revert "classes/populate_sdk_ext: require uninative" (2016-11-28 14:49:37 +0000) > > are available in the git repository at: > > git://git.openembedded.org/openembedded-core-contrib rbt/kernel > http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/kernel > > Robert Yang (1): > kernel-devsrc: remove symlink source > > meta/recipes-kernel/linux/kernel-devsrc.bb | 7 +++++++ > 1 file changed, 7 insertions(+) > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-16 8:17 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-29 9:16 [PATCH 0/1] kernel-devsrc: remove symlink source Robert Yang 2016-11-29 9:16 ` [PATCH 1/1] " Robert Yang 2016-11-29 10:57 ` Bruce Ashfield 2016-11-30 2:21 ` Robert Yang 2017-02-16 8:17 ` [PATCH 0/1] " Robert Yang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox