[PATCH 0/1] Use weak assignment for SERIAL_CONSOLES in qemu configuration files

Openembedded Core Discussions
 help / color / mirror / Atom feed

* [PATCH 0/1] Use weak assignment for SERIAL_CONSOLES in qemu configuration files
@ 2016-12-09  7:43 Chen Qi
  2016-12-09  7:43 ` [PATCH 1/1] " Chen Qi
  0 siblings, 1 reply; 4+ messages in thread
From: Chen Qi @ 2016-12-09  7:43 UTC (permalink / raw)
  To: openembedded-core

The following changes since commit ad00a31fbe93e073a2d83616efcd08c5a7ef37c9:

  gdb-cross-canadian: Depend on nativesdk-python3-importlib (2016-12-08 10:26:15 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib ChenQi/qemu-console
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/qemu-console

Chen Qi (1):
  Use weak assignment for SERIAL_CONSOLES in qemu configuration files

 meta/conf/machine/qemuarm.conf    | 2 +-
 meta/conf/machine/qemuarm64.conf  | 2 +-
 meta/conf/machine/qemumips.conf   | 2 +-
 meta/conf/machine/qemumips64.conf | 2 +-
 meta/conf/machine/qemuppc.conf    | 2 +-
 meta/conf/machine/qemux86-64.conf | 2 +-
 meta/conf/machine/qemux86.conf    | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

-- 
1.9.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] Use weak assignment for SERIAL_CONSOLES in qemu configuration files
  2016-12-09  7:43 [PATCH 0/1] Use weak assignment for SERIAL_CONSOLES in qemu configuration files Chen Qi
@ 2016-12-09  7:43 ` Chen Qi
  2016-12-09  7:55   ` Robert P. J. Day
  0 siblings, 1 reply; 4+ messages in thread
From: Chen Qi @ 2016-12-09  7:43 UTC (permalink / raw)
  To: openembedded-core

Use weak assignment for SERIAL_CONSOLES in qemu configuration files so that
the value could serve as a default value and could be easily overridden in
configuration files like local.conf.

When using the default value for SERAIL_CONSOLES in qemux86-64,we would have
annoying messages on console complaining about respawning getty on ttyS1.
Although the value is set by purpose, at least we need to provide an easy way
to override it.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/conf/machine/qemuarm.conf    | 2 +-
 meta/conf/machine/qemuarm64.conf  | 2 +-
 meta/conf/machine/qemumips.conf   | 2 +-
 meta/conf/machine/qemumips64.conf | 2 +-
 meta/conf/machine/qemuppc.conf    | 2 +-
 meta/conf/machine/qemux86-64.conf | 2 +-
 meta/conf/machine/qemux86.conf    | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/meta/conf/machine/qemuarm.conf b/meta/conf/machine/qemuarm.conf
index 17402ef..f9d6dd7 100644
--- a/meta/conf/machine/qemuarm.conf
+++ b/meta/conf/machine/qemuarm.conf
@@ -8,7 +8,7 @@ require conf/machine/include/tune-arm926ejs.inc
 
 KERNEL_IMAGETYPE = "zImage"
 
-SERIAL_CONSOLES = "115200;ttyAMA0 115200;ttyAMA1"
+SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;ttyAMA1"
 
 # For runqemu
 QB_SYSTEM_NAME = "qemu-system-arm"
diff --git a/meta/conf/machine/qemuarm64.conf b/meta/conf/machine/qemuarm64.conf
index df2010c..e70538a 100644
--- a/meta/conf/machine/qemuarm64.conf
+++ b/meta/conf/machine/qemuarm64.conf
@@ -7,7 +7,7 @@ require conf/machine/include/qemu.inc
 
 KERNEL_IMAGETYPE = "Image"
 
-SERIAL_CONSOLES = "38400;ttyAMA0 38400;hvc0"
+SERIAL_CONSOLES ?= "38400;ttyAMA0 38400;hvc0"
 
 # For runqemu
 QB_SYSTEM_NAME = "qemu-system-aarch64"
diff --git a/meta/conf/machine/qemumips.conf b/meta/conf/machine/qemumips.conf
index 3182ea1..986315a 100644
--- a/meta/conf/machine/qemumips.conf
+++ b/meta/conf/machine/qemumips.conf
@@ -9,6 +9,6 @@ require conf/machine/include/qemuboot-mips.inc
 KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
-SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
+SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
 
 MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
diff --git a/meta/conf/machine/qemumips64.conf b/meta/conf/machine/qemumips64.conf
index 9529f4c..3f91cbe 100644
--- a/meta/conf/machine/qemumips64.conf
+++ b/meta/conf/machine/qemumips64.conf
@@ -9,6 +9,6 @@ require conf/machine/include/qemuboot-mips.inc
 KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
-SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
+SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
 
 MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
diff --git a/meta/conf/machine/qemuppc.conf b/meta/conf/machine/qemuppc.conf
index 8703c20..9d174bc 100644
--- a/meta/conf/machine/qemuppc.conf
+++ b/meta/conf/machine/qemuppc.conf
@@ -9,7 +9,7 @@ TARGET_CC_KERNEL_ARCH = "-mno-spe"
 
 KERNEL_IMAGETYPE = "vmlinux"
 
-SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
+SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
 
 # For runqemu
 QB_SYSTEM_NAME = "qemu-system-ppc"
diff --git a/meta/conf/machine/qemux86-64.conf b/meta/conf/machine/qemux86-64.conf
index 3117ca1..150d745 100644
--- a/meta/conf/machine/qemux86-64.conf
+++ b/meta/conf/machine/qemux86-64.conf
@@ -14,7 +14,7 @@ require conf/machine/include/qemuboot-x86.inc
 
 KERNEL_IMAGETYPE = "bzImage"
 
-SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
+SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
 
 XSERVER = "xserver-xorg \
            ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'mesa-driver-swrast xserver-xorg-extension-glx', '', d)} \
diff --git a/meta/conf/machine/qemux86.conf b/meta/conf/machine/qemux86.conf
index 7785999..8997f6b 100644
--- a/meta/conf/machine/qemux86.conf
+++ b/meta/conf/machine/qemux86.conf
@@ -13,7 +13,7 @@ require conf/machine/include/qemuboot-x86.inc
 
 KERNEL_IMAGETYPE = "bzImage"
 
-SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
+SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
 
 XSERVER = "xserver-xorg \
            ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'mesa-driver-swrast xserver-xorg-extension-glx', '', d)} \
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] Use weak assignment for SERIAL_CONSOLES in qemu configuration files
  2016-12-09  7:43 ` [PATCH 1/1] " Chen Qi
@ 2016-12-09  7:55   ` Robert P. J. Day
  2016-12-12  7:56     ` ChenQi
  0 siblings, 1 reply; 4+ messages in thread
From: Robert P. J. Day @ 2016-12-09  7:55 UTC (permalink / raw)
  To: Chen Qi; +Cc: openembedded-core

On Fri, 9 Dec 2016, Chen Qi wrote:

> Use weak assignment for SERIAL_CONSOLES in qemu configuration files so that
> the value could serve as a default value and could be easily overridden in
> configuration files like local.conf.
>
> When using the default value for SERAIL_CONSOLES in qemux86-64,we would have
                                   ^^^^^^


rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] Use weak assignment for SERIAL_CONSOLES in qemu configuration files
  2016-12-09  7:55   ` Robert P. J. Day
@ 2016-12-12  7:56     ` ChenQi
  0 siblings, 0 replies; 4+ messages in thread
From: ChenQi @ 2016-12-12  7:56 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: openembedded-core

On 12/09/2016 03:55 PM, Robert P. J. Day wrote:
> On Fri, 9 Dec 2016, Chen Qi wrote:
>
>> Use weak assignment for SERIAL_CONSOLES in qemu configuration files so that
>> the value could serve as a default value and could be easily overridden in
>> configuration files like local.conf.
>>
>> When using the default value for SERAIL_CONSOLES in qemux86-64,we would have
>                                     ^^^^^^
>
>
> rday
>
Thanks for spotting this.

I've fixed the typo and updated the remote repo.

   git://git.openembedded.org/openembedded-core-contrib ChenQi/qemu-console
   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/qemu-console

Best Regards,

Chen Qi



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-12-12  7:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-09  7:43 [PATCH 0/1] Use weak assignment for SERIAL_CONSOLES in qemu configuration files Chen Qi
2016-12-09  7:43 ` [PATCH 1/1] " Chen Qi
2016-12-09  7:55   ` Robert P. J. Day
2016-12-12  7:56     ` ChenQi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox