[PATCH 0/1] wic: improve error message

[PATCH 0/1] wic: improve error message

[Chen Qi]

The following changes since commit 2acc741dd02cd796b396484a8676250a8f97c975:

  maintainers.inc: Add maintainers to go-native and vulkan software package recipes (2017-03-29 16:37:28 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib ChenQi/wic-error-msg
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/wic-error-msg

Chen Qi (1):
  wic: improve error message

 scripts/lib/wic/utils/misc.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

[PATCH 1/1] wic: improve error message

[Chen Qi]

When using `wic create mkefidisk -e core-image-minimal', the following
error message appeared.

  Please bake it with 'bitbake parted-native' and try again.

However, following this command doesn't do any help. The same problem
still appeared.

The problem is that when we 'bitbake parted-native', it doesn't have
anything to do with core-image-minimal. And the required tool 'parted'
is not under core-image-minimal's recipe-sysroot-native directory.

Improve the error message so that following it could get things done.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 scripts/lib/wic/utils/misc.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/wic/utils/misc.py b/scripts/lib/wic/utils/misc.py
index c941112..1b0ab3b 100644
--- a/scripts/lib/wic/utils/misc.py
+++ b/scripts/lib/wic/utils/misc.py
@@ -131,7 +131,7 @@ def exec_native_cmd(cmd_and_args, native_sysroot, catch=3, pseudo=""):
               "was not found (see details above).\n\n" % prog
         recipe = NATIVE_RECIPES.get(prog)
         if recipe:
-            msg += "Please bake it with 'bitbake %s-native' "\
+            msg += "Please make sure wic-tools have %s-native in its DEPENDS, bake it with 'bitbake wic-tools' "\
                    "and try again.\n" % recipe
         else:
             msg += "Wic failed to find a recipe to build native %s. Please "\
-- 
1.9.1

Re: [PATCH 1/1] wic: improve error message

[Gary Thomas]

On 2017-03-30 10:37, Chen Qi wrote:
> When using `wic create mkefidisk -e core-image-minimal', the following
> error message appeared.
>
>   Please bake it with 'bitbake parted-native' and try again.
>
> However, following this command doesn't do any help. The same problem
> still appeared.
>
> The problem is that when we 'bitbake parted-native', it doesn't have
> anything to do with core-image-minimal. And the required tool 'parted'
> is not under core-image-minimal's recipe-sysroot-native directory.
>
> Improve the error message so that following it could get things done.

Why not just fix the wic-tools recipe directly and not push it off onto the user?

>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  scripts/lib/wic/utils/misc.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/wic/utils/misc.py b/scripts/lib/wic/utils/misc.py
> index c941112..1b0ab3b 100644
> --- a/scripts/lib/wic/utils/misc.py
> +++ b/scripts/lib/wic/utils/misc.py
> @@ -131,7 +131,7 @@ def exec_native_cmd(cmd_and_args, native_sysroot, catch=3, pseudo=""):
>                "was not found (see details above).\n\n" % prog
>          recipe = NATIVE_RECIPES.get(prog)
>          if recipe:
> -            msg += "Please bake it with 'bitbake %s-native' "\
> +            msg += "Please make sure wic-tools have %s-native in its DEPENDS, bake it with 'bitbake wic-tools' "\
>                     "and try again.\n" % recipe
>          else:
>              msg += "Wic failed to find a recipe to build native %s. Please "\
>


-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [PATCH 1/1] wic: improve error message

[ChenQi]

On 03/30/2017 04:54 PM, Gary Thomas wrote:
> On 2017-03-30 10:37, Chen Qi wrote:
>> When using `wic create mkefidisk -e core-image-minimal', the following
>> error message appeared.
>>
>>   Please bake it with 'bitbake parted-native' and try again.
>>
>> However, following this command doesn't do any help. The same problem
>> still appeared.
>>
>> The problem is that when we 'bitbake parted-native', it doesn't have
>> anything to do with core-image-minimal. And the required tool 'parted'
>> is not under core-image-minimal's recipe-sysroot-native directory.
>>
>> Improve the error message so that following it could get things done.
>
> Why not just fix the wic-tools recipe directly and not push it off 
> onto the user?
>

wic-tools does have 'parted-native' in its DEPENDS.
I met this error when I used wic command before I executed `bitbake 
wic-tools'.

What's important here is, when an error message suggests the user to do 
something, the suggestion should at least have some chance to work. But 
following the current error message has no chance to fix things.

Best Regards,
Chen Qi

>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>  scripts/lib/wic/utils/misc.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/lib/wic/utils/misc.py 
>> b/scripts/lib/wic/utils/misc.py
>> index c941112..1b0ab3b 100644
>> --- a/scripts/lib/wic/utils/misc.py
>> +++ b/scripts/lib/wic/utils/misc.py
>> @@ -131,7 +131,7 @@ def exec_native_cmd(cmd_and_args, native_sysroot, 
>> catch=3, pseudo=""):
>>                "was not found (see details above).\n\n" % prog
>>          recipe = NATIVE_RECIPES.get(prog)
>>          if recipe:
>> -            msg += "Please bake it with 'bitbake %s-native' "\
>> +            msg += "Please make sure wic-tools have %s-native in its 
>> DEPENDS, bake it with 'bitbake wic-tools' "\
>>                     "and try again.\n" % recipe
>>          else:
>>              msg += "Wic failed to find a recipe to build native %s. 
>> Please "\
>>
>
>