[PATCH 0/1] expat: upgrade to 2.2.2

[PATCH 0/1] expat: upgrade to 2.2.2

[Dengke Du]

The following changes since commit 81498aac9560fbeaeb58eaada32ce80e0ea51628:

  yocto-project-qs: Updated Next Steps list (2017-07-12 00:28:16 +0100)

are available in the git repository at:

  https://github.com/DengkeDu/openembedded-core.git dengke/expat-upgrade-2.2.2
  https://github.com//tree/dengke/expat-upgrade-2.2.2

Dengke Du (1):
  expat: upgrade to 2.2.2

 meta/recipes-core/expat/expat_2.2.1.bb | 5 -----
 meta/recipes-core/expat/expat_2.2.2.bb | 5 +++++
 2 files changed, 5 insertions(+), 5 deletions(-)
 delete mode 100644 meta/recipes-core/expat/expat_2.2.1.bb
 create mode 100644 meta/recipes-core/expat/expat_2.2.2.bb

-- 
2.7.4

[PATCH 1/1] expat: upgrade to 2.2.2

[Dengke Du]

The expat 2.2.2:

    using getrandom syscall on linux 3.17+, so when we compiling expat-native
    on the kernel older than 3.17, that would be failed.

Signed-off-by: Dengke Du <dengke.du@windriver.com>
---
 meta/recipes-core/expat/expat_2.2.1.bb | 5 -----
 meta/recipes-core/expat/expat_2.2.2.bb | 5 +++++
 2 files changed, 5 insertions(+), 5 deletions(-)
 delete mode 100644 meta/recipes-core/expat/expat_2.2.1.bb
 create mode 100644 meta/recipes-core/expat/expat_2.2.2.bb

diff --git a/meta/recipes-core/expat/expat_2.2.1.bb b/meta/recipes-core/expat/expat_2.2.1.bb
deleted file mode 100644
index 47827c5..0000000
--- a/meta/recipes-core/expat/expat_2.2.1.bb
+++ /dev/null
@@ -1,5 +0,0 @@
-require expat.inc
-LIC_FILES_CHKSUM = "file://COPYING;md5=5b8620d98e49772d95fc1d291c26aa79"
-
-SRC_URI[md5sum] = "d9c3baeab58774cefc2f04faf29f2cf8"
-SRC_URI[sha256sum] = "1868cadae4c82a018e361e2b2091de103cd820aaacb0d6cfa49bd2cd83978885"
diff --git a/meta/recipes-core/expat/expat_2.2.2.bb b/meta/recipes-core/expat/expat_2.2.2.bb
new file mode 100644
index 0000000..dfa014b
--- /dev/null
+++ b/meta/recipes-core/expat/expat_2.2.2.bb
@@ -0,0 +1,5 @@
+require expat.inc
+LIC_FILES_CHKSUM = "file://COPYING;md5=5b8620d98e49772d95fc1d291c26aa79"
+
+SRC_URI[md5sum] = "1ede9a41223c78528b8c5d23e69a2667"
+SRC_URI[sha256sum] = "4376911fcf81a23ebd821bbabc26fd933f3ac74833f74924342c29aad2c86046"
-- 
2.7.4

Re: [PATCH 1/1] expat: upgrade to 2.2.2

[Dengke Du]

Hi Ross

Do we need to add a patch to glibc to support the ubuntu 14.04 (or 
kernel version older than 3.17)?


On 2017年07月18日 14:01, Dengke Du wrote:
> The expat 2.2.2:
>
>      using getrandom syscall on linux 3.17+, so when we compiling expat-native
>      on the kernel older than 3.17, that would be failed.
>
> Signed-off-by: Dengke Du <dengke.du@windriver.com>
> ---
>   meta/recipes-core/expat/expat_2.2.1.bb | 5 -----
>   meta/recipes-core/expat/expat_2.2.2.bb | 5 +++++
>   2 files changed, 5 insertions(+), 5 deletions(-)
>   delete mode 100644 meta/recipes-core/expat/expat_2.2.1.bb
>   create mode 100644 meta/recipes-core/expat/expat_2.2.2.bb
>
> diff --git a/meta/recipes-core/expat/expat_2.2.1.bb b/meta/recipes-core/expat/expat_2.2.1.bb
> deleted file mode 100644
> index 47827c5..0000000
> --- a/meta/recipes-core/expat/expat_2.2.1.bb
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -require expat.inc
> -LIC_FILES_CHKSUM = "file://COPYING;md5=5b8620d98e49772d95fc1d291c26aa79"
> -
> -SRC_URI[md5sum] = "d9c3baeab58774cefc2f04faf29f2cf8"
> -SRC_URI[sha256sum] = "1868cadae4c82a018e361e2b2091de103cd820aaacb0d6cfa49bd2cd83978885"
> diff --git a/meta/recipes-core/expat/expat_2.2.2.bb b/meta/recipes-core/expat/expat_2.2.2.bb
> new file mode 100644
> index 0000000..dfa014b
> --- /dev/null
> +++ b/meta/recipes-core/expat/expat_2.2.2.bb
> @@ -0,0 +1,5 @@
> +require expat.inc
> +LIC_FILES_CHKSUM = "file://COPYING;md5=5b8620d98e49772d95fc1d291c26aa79"
> +
> +SRC_URI[md5sum] = "1ede9a41223c78528b8c5d23e69a2667"
> +SRC_URI[sha256sum] = "4376911fcf81a23ebd821bbabc26fd933f3ac74833f74924342c29aad2c86046"

Re: [PATCH 1/1] expat: upgrade to 2.2.2

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

On 18 July 2017 at 07:01, Dengke Du <dengke.du@windriver.com> wrote:

>     using getrandom syscall on linux 3.17+, so when we compiling expat
> -native
>     on the kernel older than 3.17, that would be failed.
>

It's failing on Debian 8, which is kernel 4.9.0:

| ../expat-2.2.2/lib/xmlparse.c:56:3: error: #error You do not have support
for any sources of high quality entropy enabled. For end user security,
that is probably not what you want. Your options include: * Linux + glibc
>=2.25 (getrandom): HAVE_GETRANDOM, * Linux + glibc <2.25 (syscall
SYS_getrandom): HAVE_SYSCALL_GETRANDOM, * BSD / macOS (arc4random_buf):
HAVE_ARC4RANDOM_BUF, * libbsd (arc4random_buf): HAVE_ARC4RANDOM_BUF +
HAVE_LIBBSD, * Windows (RtlGenRandom): _WIN32. If insist on not using any
of these, bypass this error by defining XML_POOR_ENTROPY; you have been
warned. For CMake, one way to pass the define is: cmake
-DCMAKE_C_FLAGS="-pipe -O2 -DHAVE_SYSCALL_GETRANDOM" . If you have reasons
to patch this detection code away or need changes to the build system,
please open a bug. Thank you!

(
https://autobuilder.yocto.io/builders/nightly-ppc/builds/379/steps/BuildImages/logs/stdio
)

I suspect the detection code is well and truly broken.

Ross

[-- Attachment #2: Type: text/html, Size: 1900 bytes --]

Re: [PATCH 1/1] expat: upgrade to 2.2.2

[Khem Raj]

On Sat, Jul 22, 2017 at 2:24 AM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 18 July 2017 at 07:01, Dengke Du <dengke.du@windriver.com> wrote:
>>
>>     using getrandom syscall on linux 3.17+, so when we compiling
>> expat-native
>>     on the kernel older than 3.17, that would be failed.
>
>
> It's failing on Debian 8, which is kernel 4.9.0:
>
> | ../expat-2.2.2/lib/xmlparse.c:56:3: error: #error You do not have support
> for any sources of high quality entropy enabled. For end user security, that
> is probably not what you want. Your options include: * Linux + glibc >=2.25
> (getrandom): HAVE_GETRANDOM, * Linux + glibc <2.25 (syscall SYS_getrandom):
> HAVE_SYSCALL_GETRANDOM, * BSD / macOS (arc4random_buf): HAVE_ARC4RANDOM_BUF,
> * libbsd (arc4random_buf): HAVE_ARC4RANDOM_BUF + HAVE_LIBBSD, * Windows
> (RtlGenRandom): _WIN32. If insist on not using any of these, bypass this
> error by defining XML_POOR_ENTROPY; you have been warned. For CMake, one way
> to pass the define is: cmake -DCMAKE_C_FLAGS="-pipe -O2
> -DHAVE_SYSCALL_GETRANDOM" . If you have reasons to patch this detection code
> away or need changes to the build system, please open a bug. Thank you!
>
> (https://autobuilder.yocto.io/builders/nightly-ppc/builds/379/steps/BuildImages/logs/stdio)
>
> I suspect the detection code is well and truly broken.
>

I posted another patch doing this upgrade. I wonder if it has same
issue. it works on my 3.12 kernel based host.

> Ross
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Re: [PATCH 1/1] expat: upgrade to 2.2.2

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 2085 bytes --]

I didn't see that upgrade, but yes it will.

expat 2.2.2 demands either getrandom() from glibc (2.25 onwards) or
SYS_getrandom (not sure what glibc added this, but its not in Debian 8's
2.19.

Ross

On 22 July 2017 at 16:19, Khem Raj <raj.khem@gmail.com> wrote:

> On Sat, Jul 22, 2017 at 2:24 AM, Burton, Ross <ross.burton@intel.com>
> wrote:
> >
> > On 18 July 2017 at 07:01, Dengke Du <dengke.du@windriver.com> wrote:
> >>
> >>     using getrandom syscall on linux 3.17+, so when we compiling
> >> expat-native
> >>     on the kernel older than 3.17, that would be failed.
> >
> >
> > It's failing on Debian 8, which is kernel 4.9.0:
> >
> > | ../expat-2.2.2/lib/xmlparse.c:56:3: error: #error You do not have
> support
> > for any sources of high quality entropy enabled. For end user security,
> that
> > is probably not what you want. Your options include: * Linux + glibc
> >=2.25
> > (getrandom): HAVE_GETRANDOM, * Linux + glibc <2.25 (syscall
> SYS_getrandom):
> > HAVE_SYSCALL_GETRANDOM, * BSD / macOS (arc4random_buf):
> HAVE_ARC4RANDOM_BUF,
> > * libbsd (arc4random_buf): HAVE_ARC4RANDOM_BUF + HAVE_LIBBSD, * Windows
> > (RtlGenRandom): _WIN32. If insist on not using any of these, bypass this
> > error by defining XML_POOR_ENTROPY; you have been warned. For CMake, one
> way
> > to pass the define is: cmake -DCMAKE_C_FLAGS="-pipe -O2
> > -DHAVE_SYSCALL_GETRANDOM" . If you have reasons to patch this detection
> code
> > away or need changes to the build system, please open a bug. Thank you!
> >
> > (https://autobuilder.yocto.io/builders/nightly-ppc/builds/
> 379/steps/BuildImages/logs/stdio)
> >
> > I suspect the detection code is well and truly broken.
> >
>
> I posted another patch doing this upgrade. I wonder if it has same
> issue. it works on my 3.12 kernel based host.
>
> > Ross
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
>

[-- Attachment #2: Type: text/html, Size: 3134 bytes --]

Re: [PATCH 1/1] expat: upgrade to 2.2.2

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 2478 bytes --]

I've filed a bug upstream about the failure on Debian 8:
https://github.com/libexpat/libexpat/issues/97

Defining XML_POOR_ENTROPY will allow expat to fall back to weak entropy on
hosts that don't have direct support for getrandom().

Ross

On 24 July 2017 at 11:20, Burton, Ross <ross.burton@intel.com> wrote:

> I didn't see that upgrade, but yes it will.
>
> expat 2.2.2 demands either getrandom() from glibc (2.25 onwards) or
> SYS_getrandom (not sure what glibc added this, but its not in Debian 8's
> 2.19.
>
> Ross
>
> On 22 July 2017 at 16:19, Khem Raj <raj.khem@gmail.com> wrote:
>
>> On Sat, Jul 22, 2017 at 2:24 AM, Burton, Ross <ross.burton@intel.com>
>> wrote:
>> >
>> > On 18 July 2017 at 07:01, Dengke Du <dengke.du@windriver.com> wrote:
>> >>
>> >>     using getrandom syscall on linux 3.17+, so when we compiling
>> >> expat-native
>> >>     on the kernel older than 3.17, that would be failed.
>> >
>> >
>> > It's failing on Debian 8, which is kernel 4.9.0:
>> >
>> > | ../expat-2.2.2/lib/xmlparse.c:56:3: error: #error You do not have
>> support
>> > for any sources of high quality entropy enabled. For end user security,
>> that
>> > is probably not what you want. Your options include: * Linux + glibc
>> >=2.25
>> > (getrandom): HAVE_GETRANDOM, * Linux + glibc <2.25 (syscall
>> SYS_getrandom):
>> > HAVE_SYSCALL_GETRANDOM, * BSD / macOS (arc4random_buf):
>> HAVE_ARC4RANDOM_BUF,
>> > * libbsd (arc4random_buf): HAVE_ARC4RANDOM_BUF + HAVE_LIBBSD, * Windows
>> > (RtlGenRandom): _WIN32. If insist on not using any of these, bypass this
>> > error by defining XML_POOR_ENTROPY; you have been warned. For CMake,
>> one way
>> > to pass the define is: cmake -DCMAKE_C_FLAGS="-pipe -O2
>> > -DHAVE_SYSCALL_GETRANDOM" . If you have reasons to patch this detection
>> code
>> > away or need changes to the build system, please open a bug. Thank you!
>> >
>> > (https://autobuilder.yocto.io/builders/nightly-ppc/builds/37
>> 9/steps/BuildImages/logs/stdio)
>> >
>> > I suspect the detection code is well and truly broken.
>> >
>>
>> I posted another patch doing this upgrade. I wonder if it has same
>> issue. it works on my 3.12 kernel based host.
>>
>> > Ross
>> >
>> > --
>> > _______________________________________________
>> > Openembedded-core mailing list
>> > Openembedded-core@lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> >
>>
>
>

[-- Attachment #2: Type: text/html, Size: 4260 bytes --]

Re: [PATCH 1/1] expat: upgrade to 2.2.2

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

On 24 July 2017 at 11:23, Burton, Ross <ross.burton@intel.com> wrote:

> I've filed a bug upstream about the failure on Debian 8:
> https://github.com/libexpat/libexpat/issues/97
>

And this bug is now resolved.  expat in git can read /dev/urandom directly
if it doesn't find the syscalls it wants.

Ross

[-- Attachment #2: Type: text/html, Size: 749 bytes --]

Re: [PATCH 1/1] expat: upgrade to 2.2.2

[Khem Raj]

On Thu, Aug 3, 2017 at 9:42 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 24 July 2017 at 11:23, Burton, Ross <ross.burton@intel.com> wrote:
>>
>> I've filed a bug upstream about the failure on Debian 8:
>> https://github.com/libexpat/libexpat/issues/97
>
>
> And this bug is now resolved.  expat in git can read /dev/urandom directly
> if it doesn't find the syscalls it wants.

Sounds good. Denke, when you refresh patch please include this patch along

http://git.openembedded.org/openembedded-core-contrib/tree/meta/recipes-core/expat/expat/libtool-tag.patch?h=kraj/master&id=01929853a8346ba0fc27090150ebc506d1c5cd1e

which was not there in your v1.

>
> Ross

Re: [PATCH 1/1] expat: upgrade to 2.2.2

[Dengke Du]

OK!


On 2017年08月04日 00:48, Khem Raj wrote:
> On Thu, Aug 3, 2017 at 9:42 AM, Burton, Ross <ross.burton@intel.com> wrote:
>> On 24 July 2017 at 11:23, Burton, Ross <ross.burton@intel.com> wrote:
>>> I've filed a bug upstream about the failure on Debian 8:
>>> https://github.com/libexpat/libexpat/issues/97
>>
>> And this bug is now resolved.  expat in git can read /dev/urandom directly
>> if it doesn't find the syscalls it wants.
> Sounds good. Denke, when you refresh patch please include this patch along
>
> http://git.openembedded.org/openembedded-core-contrib/tree/meta/recipes-core/expat/expat/libtool-tag.patch?h=kraj/master&id=01929853a8346ba0fc27090150ebc506d1c5cd1e
>
> which was not there in your v1.
>
>> Ross