[PATCH V2 0/1] ovmf: fix do_compile error when len(tmp)=410

[PATCH V2 0/1] ovmf: fix do_compile error when len(tmp)=410

[Dengke Du]

Changed in V2:
	Add the MAX_LONG_FILE_PATH to 1023.

The following changes since commit 8b4f16a9cbbaf521461f699b7264fac2ac872581:

  mesa-gl: Fix build after recent mesa PACKAGECONFIG changes (2017-09-05 15:01:02 +0100)

are available in the git repository at:

  https://github.com/DengkeDu/openembedded-core.git dengke/fix-ovmf-do-compile-error-when-enable-long-file-path
  https://github.com//tree/dengke/fix-ovmf-do-compile-error-when-enable-long-file-path

Dengke Du (1):
  ovmf: fix do_compile error when len(tmp)=410

 .../ovmf/0004-ovmf-enable-long-path-file.patch     | 28 ++++++++++++++++++++++
 meta/recipes-core/ovmf/ovmf_git.bb                 |  3 ++-
 2 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-file.patch

-- 
2.8.1

[PATCH V2 1/1] ovmf: fix do_compile error when len(tmp)=410

[Dengke Du]

[YOCTO #11354]

Signed-off-by: Dengke Du <dengke.du@windriver.com>
---
 .../ovmf/0004-ovmf-enable-long-path-file.patch     | 28 ++++++++++++++++++++++
 meta/recipes-core/ovmf/ovmf_git.bb                 |  3 ++-
 2 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-file.patch

diff --git a/meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-file.patch b/meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-file.patch
new file mode 100644
index 0000000..9cc85ad
--- /dev/null
+++ b/meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-file.patch
@@ -0,0 +1,28 @@
+From 032fc6b1f7691bd537fd2a6bd13821fcf3c45e64 Mon Sep 17 00:00:00 2001
+From: Dengke Du <dengke.du@windriver.com>
+Date: Mon, 11 Sep 2017 02:21:55 -0400
+Subject: [PATCH] ovmf: enable long path file
+
+Upstream-Status: Pending
+
+Signed-off-by: Dengke Du <dengke.du@windriver.com>
+---
+ BaseTools/Source/C/Common/CommonLib.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/BaseTools/Source/C/Common/CommonLib.h b/BaseTools/Source/C/Common/CommonLib.h
+index 2041b89..8116aa2 100644
+--- a/BaseTools/Source/C/Common/CommonLib.h
++++ b/BaseTools/Source/C/Common/CommonLib.h
+@@ -19,7 +19,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+ #include <Common/BuildVersion.h>
+ #define PRINTED_GUID_BUFFER_SIZE  37  // including null-termination
+ 
+-#define MAX_LONG_FILE_PATH 500
++#define MAX_LONG_FILE_PATH 1023
+ 
+ #ifdef __cplusplus
+ extern "C" {
+-- 
+2.8.1
+
diff --git a/meta/recipes-core/ovmf/ovmf_git.bb b/meta/recipes-core/ovmf/ovmf_git.bb
index 1872c95..50c01aa 100644
--- a/meta/recipes-core/ovmf/ovmf_git.bb
+++ b/meta/recipes-core/ovmf/ovmf_git.bb
@@ -11,10 +11,11 @@ PACKAGECONFIG ??= ""
 PACKAGECONFIG[secureboot] = ",,,"
 
 SRC_URI = "git://github.com/tianocore/edk2.git;branch=master \
+	file://0001-ia32-Dont-use-pie.patch \
 	file://0002-ovmf-update-path-to-native-BaseTools.patch \
 	file://0003-BaseTools-makefile-adjust-to-build-in-under-bitbake.patch \
+	file://0004-ovmf-enable-long-path-file.patch \
 	file://VfrCompile-increase-path-length-limit.patch \
-	file://0001-ia32-Dont-use-pie.patch \
 	file://no-stack-protector-all-archs.patch \
         "
 UPSTREAM_VERSION_UNKNOWN = "1"
-- 
2.8.1

Re: [PATCH V2 1/1] ovmf: fix do_compile error when len(tmp)=410

[Patrick Ohly]

On Mon, 2017-09-11 at 21:20 -0400, Dengke Du wrote:
> diff --git a/meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-
> file.patch b/meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-
> file.patch
> new file mode 100644
> index 0000000..9cc85ad
> --- /dev/null
> +++ b/meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-
> file.patch
> @@ -0,0 +1,28 @@
> +From 032fc6b1f7691bd537fd2a6bd13821fcf3c45e64 Mon Sep 17 00:00:00
> 2001
> +From: Dengke Du <dengke.du@windriver.com>
> +Date: Mon, 11 Sep 2017 02:21:55 -0400
> +Subject: [PATCH] ovmf: enable long path file
> +
> +Upstream-Status: Pending

Pending which action? I.e. what's the next step?

To me this patch looks more like local customization to fit into path
lengths used by the OE build system, so "Inappropriate" might be more
reasonable.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.

Re: [PATCH V2 1/1] ovmf: fix do_compile error when len(tmp)=410

[Dengke Du]

On 2017年09月12日 15:46, Patrick Ohly wrote:
> On Mon, 2017-09-11 at 21:20 -0400, Dengke Du wrote:
>> diff --git a/meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-
>> file.patch b/meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-
>> file.patch
>> new file mode 100644
>> index 0000000..9cc85ad
>> --- /dev/null
>> +++ b/meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-
>> file.patch
>> @@ -0,0 +1,28 @@
>> +From 032fc6b1f7691bd537fd2a6bd13821fcf3c45e64 Mon Sep 17 00:00:00
>> 2001
>> +From: Dengke Du <dengke.du@windriver.com>
>> +Date: Mon, 11 Sep 2017 02:21:55 -0400
>> +Subject: [PATCH] ovmf: enable long path file
>> +
>> +Upstream-Status: Pending
> Pending which action? I.e. what's the next step?
>
> To me this patch looks more like local customization to fit into path
> lengths used by the OE build system, so "Inappropriate" might be more
> reasonable.
>
Yes, you are right, it just fit for OE build system.