Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] recipetool: create: fix failure handling included dicts
@ 2017-11-12 22:00 Paul Eggleton
  2017-11-12 22:00 ` [PATCH 1/1] " Paul Eggleton
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Eggleton @ 2017-11-12 22:00 UTC (permalink / raw)
  To: openembedded-core

The following changes since commit a17f3ec910366e9e7551fa24fbc07929b9584341:

  dhcp: fix build issue with libxml2 support (2017-11-10 14:44:31 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib paule/recipetool-fix2
  http://cgit.openembedded.org/openembedded-core-contrib/log/?h=paule/recipetool-fix2

Paul Eggleton (1):
  recipetool: create: fix failure handling included dicts

 scripts/lib/recipetool/create_buildsys_python.py | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.9.5



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] recipetool: create: fix failure handling included dicts
  2017-11-12 22:00 [PATCH 0/1] recipetool: create: fix failure handling included dicts Paul Eggleton
@ 2017-11-12 22:00 ` Paul Eggleton
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggleton @ 2017-11-12 22:00 UTC (permalink / raw)
  To: openembedded-core

If a setup dict in a python setup.py file pulled in the contents of
another dict (e.g.  **otherdict), then we got an error when mapping
the keys because the key is None in that case. Skip those keys to avoid
the error (we pick up the values directly in any case).

A quick reproducer for this issue:

recipetool create https://files.pythonhosted.org/packages/source/p/pyqtgraph/pyqtgraph-0.10.0.tar.gz

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 scripts/lib/recipetool/create_buildsys_python.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/lib/recipetool/create_buildsys_python.py b/scripts/lib/recipetool/create_buildsys_python.py
index ec5449b..5bd2aa3 100644
--- a/scripts/lib/recipetool/create_buildsys_python.py
+++ b/scripts/lib/recipetool/create_buildsys_python.py
@@ -356,6 +356,8 @@ class PythonRecipeHandler(RecipeHandler):
         # Naive mapping of setup() arguments to PKG-INFO field names
         for d in [info, non_literals]:
             for key, value in list(d.items()):
+                if key is None:
+                    continue
                 new_key = _map(key)
                 if new_key != key:
                     del d[key]
-- 
2.9.5



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-12 22:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-12 22:00 [PATCH 0/1] recipetool: create: fix failure handling included dicts Paul Eggleton
2017-11-12 22:00 ` [PATCH 1/1] " Paul Eggleton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox