* [PATCH 0/1]
@ 2017-11-21 0:21 Amanda Brindle
2017-11-21 0:21 ` [PATCH 1/1] scripts/contrib/bbvars.py: Remove dead code Amanda Brindle
2017-11-21 0:35 ` ✗ patchtest: failure for " Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Amanda Brindle @ 2017-11-21 0:21 UTC (permalink / raw)
To: openembedded-core; +Cc: paul.eggleton
The following changes since commit 4ed19ac8c19afd56d445d84e02b622cb056b8359:
poky: Switch to post release name/version (2017-11-14 17:26:58 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib abrindle/bbvars_tinfoil2
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=abrindle/bbvars_tinfoil2
Amanda Brindle (1):
scripts/contrib/bbvars.py: Remove dead code
scripts/contrib/bbvars.py | 52 ++---------------------------------------------
1 file changed, 2 insertions(+), 50 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] scripts/contrib/bbvars.py: Remove dead code
2017-11-21 0:21 [PATCH 0/1] Amanda Brindle
@ 2017-11-21 0:21 ` Amanda Brindle
2017-11-21 0:35 ` ✗ patchtest: failure for " Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Amanda Brindle @ 2017-11-21 0:21 UTC (permalink / raw)
To: openembedded-core; +Cc: paul.eggleton
Removed the -m option since this script now searches through all
recipes in the configuration. Also removed dead code, which includes
the functions recipe_bbvars() and collect_bbvars().
---
scripts/contrib/bbvars.py | 52 ++---------------------------------------------
1 file changed, 2 insertions(+), 50 deletions(-)
diff --git a/scripts/contrib/bbvars.py b/scripts/contrib/bbvars.py
index 556f652..286b5a9 100755
--- a/scripts/contrib/bbvars.py
+++ b/scripts/contrib/bbvars.py
@@ -32,48 +32,12 @@ scriptpath.add_bitbake_lib_path()
import bb.tinfoil
def usage():
- print('Usage: %s -d FILENAME [-d FILENAME]* -m METADIR [-m MATADIR]*' % os.path.basename(sys.argv[0]))
+ print('Usage: %s -d FILENAME [-d FILENAME]*' % os.path.basename(sys.argv[0]))
print(' -d FILENAME documentation file to search')
print(' -h, --help display this help and exit')
- print(' -m METADIR meta directory to search for recipes')
print(' -t FILENAME documentation config file (for doc tags)')
print(' -T Only display variables with doc tags (requires -t)')
-def recipe_bbvars(recipe):
- ''' Return a unique set of every bbvar encountered in the recipe '''
- prog = re.compile("[A-Z_]+")
- vset = set()
- try:
- r = open(recipe)
- except IOError as err:
- print('WARNING: Failed to open recipe ', recipe)
- print(err.args[1])
-
- for line in r:
- # Strip any comments from the line
- line = line.rsplit('#')[0]
- vset = vset.union(set(prog.findall(line)))
- r.close()
-
- bbvars = {}
- for v in vset:
- bbvars[v] = 1
-
- return bbvars
-
-def collect_bbvars(metadir):
- ''' Walk the metadir and collect the bbvars from each recipe found '''
- bbvars = {}
- for root,dirs,files in os.walk(metadir):
- for name in files:
- if name.find(".bb") >= 0:
- for key in recipe_bbvars(os.path.join(root,name)).keys():
- if key in bbvars:
- bbvars[key] = bbvars[key] + 1
- else:
- bbvars[key] = 1
- return bbvars
-
def bbvar_is_documented(var, documented_vars):
''' Check if variable (var) is in the list of documented variables(documented_vars) '''
if var in documented_vars:
@@ -112,7 +76,6 @@ def bbvar_doctag(var, docconf):
def main():
docfiles = []
- metadirs = []
bbvars = set()
undocumented = []
docconf = ""
@@ -136,12 +99,6 @@ def main():
else:
print('ERROR: documentation file %s is not a regular file' % a)
sys.exit(3)
- elif o == '-m':
- if os.path.isdir(a):
- metadirs.append(a)
- else:
- print('ERROR: meta directory %s is not a directory' % a)
- sys.exit(4)
elif o == "-t":
if os.path.isfile(a):
docconf = a
@@ -155,11 +112,6 @@ def main():
usage()
sys.exit(5)
- if len(metadirs) == 0:
- print('ERROR: no metadir specified')
- usage()
- sys.exit(6)
-
if onlydoctags and docconf == "":
print('ERROR: no docconf specified')
usage()
@@ -196,7 +148,7 @@ def main():
bbvars_update(data)
# Collect variables from all recipes
- for recipe in tinfoil.all_recipe_files():
+ for recipe in tinfoil.all_recipe_files(variants=False):
print("Checking %s" % recipe)
for data in tinfoil.parse_recipe_file(recipe):
bbvars_update(data)
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✗ patchtest: failure for scripts/contrib/bbvars.py: Remove dead code
2017-11-21 0:21 [PATCH 0/1] Amanda Brindle
2017-11-21 0:21 ` [PATCH 1/1] scripts/contrib/bbvars.py: Remove dead code Amanda Brindle
@ 2017-11-21 0:35 ` Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-11-21 0:35 UTC (permalink / raw)
To: Amanda Brindle; +Cc: openembedded-core
== Series Details ==
Series: scripts/contrib/bbvars.py: Remove dead code
Revision: 1
URL : https://patchwork.openembedded.org/series/9885/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Patch [1/1] scripts/contrib/bbvars.py: Remove dead code
Issue Patch is missing Signed-off-by [test_signed_off_by_presence]
Suggested fix Sign off the patch (either manually or with "git commit --amend -s")
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/1]
@ 2017-10-30 21:56 Amanda Brindle
0 siblings, 0 replies; 6+ messages in thread
From: Amanda Brindle @ 2017-10-30 21:56 UTC (permalink / raw)
To: openembedded-core; +Cc: paul.eggleton
The following changes since commit 65d23bd7986615fdfb0f1717b615534a2a14ab80:
README.qemu: qemuppc64 is not supported (2017-10-16 23:54:31 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib abrindle/bbvars_tinfoil
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=abrindle/bbvars_tinfoil
Amanda Brindle (1):
scripts/contrib/bbvars.py: Rewrite to use tinfoil
scripts/contrib/bbvars.py | 90 ++++++++++++++++++++++++++++++++++-------------
1 file changed, 66 insertions(+), 24 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/1]
@ 2013-06-18 15:20 Bruce Ashfield
2013-06-18 15:22 ` Bruce Ashfield
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Ashfield @ 2013-06-18 15:20 UTC (permalink / raw)
To: richard.purdie; +Cc: openembedded-core
Richard/Saul,
Here's the integration of a change from Khem to fix the gcc 4.8 ARM
boot issues.
I'm still seeing some quasi random issues, but this definitely fixes
the issue at hand, gets us up and running and is much better than
what we had before.
The patch pretty much says everything else:
linux-yocto/3.8: fix gcc 4.8 ARM boot issues
Updating the linux-yocto-3.8 SRCREVs to fix a boot issue with ARM boards
when gcc 4.8 is used.
Without the following mainline backports:
f200475 ARM: 7670/1: fix the memset fix
8215b0e ARM: 7668/1: fix memset-related crashes caused by recent GCC (4.7.2) optimizations
The following trap will be seen on boot:
[<c00fc3b8>] (kmem_cache_alloc_trace+0x54/0x210) from [<c039f074>] (con_insert_unipair+0xcc/0x11c)
[<c039f074>] (con_insert_unipair+0xcc/0x11c) from [<c039fec8>] (con_set_default_unimap+0xfc/0x198)
[<c039fec8>] (con_set_default_unimap+0xfc/0x198) from [<c07ee258>] (console_map_init+0x44/0x58)
[<c07ee258>] (console_map_init+0x44/0x58) from [<c07ee738>] (vty_init+0x16c/0x1b0)
[<c07ee738>] (vty_init+0x16c/0x1b0) from [<c07edb68>] (tty_init+0x108/0x148)
[<c07edb68>] (tty_init+0x108/0x148) from [<c07eead0>] (chr_dev_init+0xb4/0xd8)
[<c07eead0>] (chr_dev_init+0xb4/0xd8) from [<c0008a18>] (do_one_initcall+0x11c/0x18c)
[<c0008a18>] (do_one_initcall+0x11c/0x18c) from [<c07d89d0>] (kernel_init_freeable+0x16c/0x254)
[<c07d89d0>] (kernel_init_freeable+0x16c/0x254) from [<c05a3810>] (kernel_init+0x18/0x160)
[<c05a3810>] (kernel_init+0x18/0x160) from [<c000e530>] (ret_from_fork+0x14/0x20)
Code: e593a000 e35a0000 0a000020 e5943014 (e79a1003)
---[ end trace e6c62de166779f86 ]---
Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
Moderate stress and board testing shows the fix to hold, and it is good for
broader testing.
[YOCTO #4549]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Cheers,
Bruce
The following changes since commit 1dd643b142c69ac9035e29bff11d02201638dc65:
licences: Add SGI license (2013-06-17 16:45:37 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib zedd/kernel
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel
Bruce Ashfield (1):
linux-yocto/3.8: fix gcc 4.8 ARM boot issues
meta/recipes-kernel/linux/linux-yocto-rt_3.8.bb | 6 +++---
meta/recipes-kernel/linux/linux-yocto-tiny_3.8.bb | 4 ++--
meta/recipes-kernel/linux/linux-yocto_3.8.bb | 14 +++++++-------
3 files changed, 12 insertions(+), 12 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/1]
2013-06-18 15:20 Bruce Ashfield
@ 2013-06-18 15:22 ` Bruce Ashfield
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Ashfield @ 2013-06-18 15:22 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
Apologies for the "no subject" email.
The rest is fine, just the guy typing it up had an itchy trigger finger!
Cheers,
Bruce
On Tue, Jun 18, 2013 at 11:20 AM, Bruce Ashfield
<bruce.ashfield@windriver.com> wrote:
> Richard/Saul,
>
> Here's the integration of a change from Khem to fix the gcc 4.8 ARM
> boot issues.
>
> I'm still seeing some quasi random issues, but this definitely fixes
> the issue at hand, gets us up and running and is much better than
> what we had before.
>
> The patch pretty much says everything else:
>
> linux-yocto/3.8: fix gcc 4.8 ARM boot issues
>
> Updating the linux-yocto-3.8 SRCREVs to fix a boot issue with ARM boards
> when gcc 4.8 is used.
>
> Without the following mainline backports:
>
> f200475 ARM: 7670/1: fix the memset fix
> 8215b0e ARM: 7668/1: fix memset-related crashes caused by recent GCC (4.7.2) optimizations
>
> The following trap will be seen on boot:
>
> [<c00fc3b8>] (kmem_cache_alloc_trace+0x54/0x210) from [<c039f074>] (con_insert_unipair+0xcc/0x11c)
> [<c039f074>] (con_insert_unipair+0xcc/0x11c) from [<c039fec8>] (con_set_default_unimap+0xfc/0x198)
> [<c039fec8>] (con_set_default_unimap+0xfc/0x198) from [<c07ee258>] (console_map_init+0x44/0x58)
> [<c07ee258>] (console_map_init+0x44/0x58) from [<c07ee738>] (vty_init+0x16c/0x1b0)
> [<c07ee738>] (vty_init+0x16c/0x1b0) from [<c07edb68>] (tty_init+0x108/0x148)
> [<c07edb68>] (tty_init+0x108/0x148) from [<c07eead0>] (chr_dev_init+0xb4/0xd8)
> [<c07eead0>] (chr_dev_init+0xb4/0xd8) from [<c0008a18>] (do_one_initcall+0x11c/0x18c)
> [<c0008a18>] (do_one_initcall+0x11c/0x18c) from [<c07d89d0>] (kernel_init_freeable+0x16c/0x254)
> [<c07d89d0>] (kernel_init_freeable+0x16c/0x254) from [<c05a3810>] (kernel_init+0x18/0x160)
> [<c05a3810>] (kernel_init+0x18/0x160) from [<c000e530>] (ret_from_fork+0x14/0x20)
> Code: e593a000 e35a0000 0a000020 e5943014 (e79a1003)
> ---[ end trace e6c62de166779f86 ]---
> Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
>
> Moderate stress and board testing shows the fix to hold, and it is good for
> broader testing.
>
> [YOCTO #4549]
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>
> Cheers,
>
> Bruce
>
> The following changes since commit 1dd643b142c69ac9035e29bff11d02201638dc65:
>
> licences: Add SGI license (2013-06-17 16:45:37 +0100)
>
> are available in the git repository at:
>
> git://git.pokylinux.org/poky-contrib zedd/kernel
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel
>
> Bruce Ashfield (1):
> linux-yocto/3.8: fix gcc 4.8 ARM boot issues
>
> meta/recipes-kernel/linux/linux-yocto-rt_3.8.bb | 6 +++---
> meta/recipes-kernel/linux/linux-yocto-tiny_3.8.bb | 4 ++--
> meta/recipes-kernel/linux/linux-yocto_3.8.bb | 14 +++++++-------
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> --
> 1.7.10.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-21 0:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-21 0:21 [PATCH 0/1] Amanda Brindle
2017-11-21 0:21 ` [PATCH 1/1] scripts/contrib/bbvars.py: Remove dead code Amanda Brindle
2017-11-21 0:35 ` ✗ patchtest: failure for " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2017-10-30 21:56 [PATCH 0/1] Amanda Brindle
2013-06-18 15:20 Bruce Ashfield
2013-06-18 15:22 ` Bruce Ashfield
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox