Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] ltp: add runtime depends ltp-staticdev
@ 2017-12-01  6:58 Dengke Du
  2017-12-01  6:58 ` [PATCH 1/1] " Dengke Du
  0 siblings, 1 reply; 6+ messages in thread
From: Dengke Du @ 2017-12-01  6:58 UTC (permalink / raw)
  To: openembedded-core

The following changes since commit ed48e7b4f0d11bf20e0be44d8403fc16dd6d4411:

  usbutils: remove uclibc-specific patch (2017-11-30 10:49:22 +0000)

are available in the git repository at:

  https://github.com/DengkeDu/openembedded-core.git fix-nm01-failed
  https://github.com//tree/fix-nm01-failed

Dengke Du (1):
  ltp: add runtime depends ltp-staticdev

 meta/recipes-extended/ltp/ltp_20170929.bb | 1 +
 1 file changed, 1 insertion(+)

-- 
2.8.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ltp: add runtime depends ltp-staticdev
  2017-12-01  6:58 [PATCH 0/1] ltp: add runtime depends ltp-staticdev Dengke Du
@ 2017-12-01  6:58 ` Dengke Du
  2017-12-01 14:51   ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Dengke Du @ 2017-12-01  6:58 UTC (permalink / raw)
  To: openembedded-core

The test case nm01 depends on /opt/ltp/testcases/data/nm01/lib.a in
ltp-staticdev package.

Signed-off-by: Dengke Du <dengke.du@windriver.com>
---
 meta/recipes-extended/ltp/ltp_20170929.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-extended/ltp/ltp_20170929.bb b/meta/recipes-extended/ltp/ltp_20170929.bb
index 93a59b3..6fd280c 100644
--- a/meta/recipes-extended/ltp/ltp_20170929.bb
+++ b/meta/recipes-extended/ltp/ltp_20170929.bb
@@ -108,6 +108,7 @@ RDEPENDS_${PN} = "\
 FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a /opt/ltp/testcases/data/nm01/lib.a"
 
 FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/* /opt/ltp/scenario_groups/* /opt/ltp/testcases/bin/* /opt/ltp/testcases/bin/*/bin/* /opt/ltp/testscripts/* /opt/ltp/testcases/open_posix_testsuite/* /opt/ltp/testcases/open_posix_testsuite/conformance/* /opt/ltp/testcases/open_posix_testsuite/Documentation/* /opt/ltp/testcases/open_posix_testsuite/functional/* /opt/ltp/testcases/open_posix_testsuite/include/* /opt/ltp/testcases/open_posix_testsuite/scripts/* /opt/ltp/testcases/open_posix_testsuite/stress/* /opt/ltp/testcases/open_posix_testsuite/tools/*"
+RDEPENDES_${PN} += "${PN}-staticdev"
 
 # Avoid generated binaries stripping. Otherwise some of the ltp tests such as ldd01 & nm01 fails
 INHIBIT_PACKAGE_STRIP = "1"
-- 
2.8.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ltp: add runtime depends ltp-staticdev
  2017-12-01  6:58 ` [PATCH 1/1] " Dengke Du
@ 2017-12-01 14:51   ` Khem Raj
  2017-12-01 16:01     ` Tim Orling
  2017-12-01 16:26     ` Burton, Ross
  0 siblings, 2 replies; 6+ messages in thread
From: Khem Raj @ 2017-12-01 14:51 UTC (permalink / raw)
  To: Dengke Du; +Cc: Patches and discussions about the oe-core layer

On Thu, Nov 30, 2017 at 10:58 PM, Dengke Du <dengke.du@windriver.com> wrote:
> The test case nm01 depends on /opt/ltp/testcases/data/nm01/lib.a in
> ltp-staticdev package.
>

perhaps its better to create a packaging exception to include this static
library to be packaged into ${PN}

> Signed-off-by: Dengke Du <dengke.du@windriver.com>
> ---
>  meta/recipes-extended/ltp/ltp_20170929.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-extended/ltp/ltp_20170929.bb b/meta/recipes-extended/ltp/ltp_20170929.bb
> index 93a59b3..6fd280c 100644
> --- a/meta/recipes-extended/ltp/ltp_20170929.bb
> +++ b/meta/recipes-extended/ltp/ltp_20170929.bb
> @@ -108,6 +108,7 @@ RDEPENDS_${PN} = "\
>  FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a /opt/ltp/testcases/data/nm01/lib.a"
>
>  FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/* /opt/ltp/scenario_groups/* /opt/ltp/testcases/bin/* /opt/ltp/testcases/bin/*/bin/* /opt/ltp/testscripts/* /opt/ltp/testcases/open_posix_testsuite/* /opt/ltp/testcases/open_posix_testsuite/conformance/* /opt/ltp/testcases/open_posix_testsuite/Documentation/* /opt/ltp/testcases/open_posix_testsuite/functional/* /opt/ltp/testcases/open_posix_testsuite/include/* /opt/ltp/testcases/open_posix_testsuite/scripts/* /opt/ltp/testcases/open_posix_testsuite/stress/* /opt/ltp/testcases/open_posix_testsuite/tools/*"
> +RDEPENDES_${PN} += "${PN}-staticdev"
>
>  # Avoid generated binaries stripping. Otherwise some of the ltp tests such as ldd01 & nm01 fails
>  INHIBIT_PACKAGE_STRIP = "1"
> --
> 2.8.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ltp: add runtime depends ltp-staticdev
  2017-12-01 14:51   ` Khem Raj
@ 2017-12-01 16:01     ` Tim Orling
  2017-12-04  1:18       ` Dengke Du
  2017-12-01 16:26     ` Burton, Ross
  1 sibling, 1 reply; 6+ messages in thread
From: Tim Orling @ 2017-12-01 16:01 UTC (permalink / raw)
  To: dengke.du@windriver.com; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 2272 bytes --]

On Fri, Dec 1, 2017 at 6:52 AM Khem Raj <raj.khem@gmail.com> wrote:

> On Thu, Nov 30, 2017 at 10:58 PM, Dengke Du <dengke.du@windriver.com>
> wrote:
> > The test case nm01 depends on /opt/ltp/testcases/data/nm01/lib.a in
> > ltp-staticdev package.
> >
>
> perhaps its better to create a packaging exception to include this static
> library to be packaged into ${PN}
>
> > Signed-off-by: Dengke Du <dengke.du@windriver.com>
> > ---
> >  meta/recipes-extended/ltp/ltp_20170929.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/recipes-extended/ltp/ltp_20170929.bb
> b/meta/recipes-extended/ltp/ltp_20170929.bb
> > index 93a59b3..6fd280c 100644
> > --- a/meta/recipes-extended/ltp/ltp_20170929.bb
> > +++ b/meta/recipes-extended/ltp/ltp_20170929.bb
> > @@ -108,6 +108,7 @@ RDEPENDS_${PN} = "\
> >  FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a
> /opt/ltp/testcases/data/nm01/lib.a"
> >
> >  FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/*
> /opt/ltp/scenario_groups/* /opt/ltp/testcases/bin/*
> /opt/ltp/testcases/bin/*/bin/* /opt/ltp/testscripts/*
> /opt/ltp/testcases/open_posix_testsuite/*
> /opt/ltp/testcases/open_posix_testsuite/conformance/*
> /opt/ltp/testcases/open_posix_testsuite/Documentation/*
> /opt/ltp/testcases/open_posix_testsuite/functional/*
> /opt/ltp/testcases/open_posix_testsuite/include/*
> /opt/ltp/testcases/open_posix_testsuite/scripts/*
> /opt/ltp/testcases/open_posix_testsuite/stress/*
> /opt/ltp/testcases/open_posix_testsuite/tools/*"
> > +RDEPENDES_${PN} += "${PN}-staticdev"
>

Typo in RDEPENDS
Please make sure you test patches before submitting. This could not have
worked as intended.

>
> >  # Avoid generated binaries stripping. Otherwise some of the ltp tests
> such as ldd01 & nm01 fails
> >  INHIBIT_PACKAGE_STRIP = "1"
> > --
> > 2.8.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3869 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ltp: add runtime depends ltp-staticdev
  2017-12-01 14:51   ` Khem Raj
  2017-12-01 16:01     ` Tim Orling
@ 2017-12-01 16:26     ` Burton, Ross
  1 sibling, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2017-12-01 16:26 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

On 1 December 2017 at 14:51, Khem Raj <raj.khem@gmail.com> wrote:

> On Thu, Nov 30, 2017 at 10:58 PM, Dengke Du <dengke.du@windriver.com>
> wrote:
> > The test case nm01 depends on /opt/ltp/testcases/data/nm01/lib.a in
> > ltp-staticdev package.
> >
>
> perhaps its better to create a packaging exception to include this static
> library to be packaged into ${PN}


Definitely.  For ltp I suspect the standard PN PN-dev PN-staticdev split is
entirely pointless, so just don't create those extra packages and silence
the QA checks.

Ross

[-- Attachment #2: Type: text/html, Size: 978 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ltp: add runtime depends ltp-staticdev
  2017-12-01 16:01     ` Tim Orling
@ 2017-12-04  1:18       ` Dengke Du
  0 siblings, 0 replies; 6+ messages in thread
From: Dengke Du @ 2017-12-04  1:18 UTC (permalink / raw)
  To: Tim Orling; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 3047 bytes --]

Sorry for my errors, I have added the "ltp-staticdev" to my 
IMAGE_INSTALL_append,

so the nm01 test case have passed.


On 2017年12月02日 00:01, Tim Orling wrote:
> On Fri, Dec 1, 2017 at 6:52 AM Khem Raj <raj.khem@gmail.com 
> <mailto:raj.khem@gmail.com>> wrote:
>
>     On Thu, Nov 30, 2017 at 10:58 PM, Dengke Du
>     <dengke.du@windriver.com <mailto:dengke.du@windriver.com>> wrote:
>     > The test case nm01 depends on /opt/ltp/testcases/data/nm01/lib.a in
>     > ltp-staticdev package.
>     >
>
>     perhaps its better to create a packaging exception to include this
>     static
>     library to be packaged into ${PN}
>
>     > Signed-off-by: Dengke Du <dengke.du@windriver.com
>     <mailto:dengke.du@windriver.com>>
>     > ---
>     >  meta/recipes-extended/ltp/ltp_20170929.bb
>     <http://ltp_20170929.bb> | 1 +
>     >  1 file changed, 1 insertion(+)
>     >
>     > diff --git a/meta/recipes-extended/ltp/ltp_20170929.bb
>     <http://ltp_20170929.bb>
>     b/meta/recipes-extended/ltp/ltp_20170929.bb <http://ltp_20170929.bb>
>     > index 93a59b3..6fd280c 100644
>     > --- a/meta/recipes-extended/ltp/ltp_20170929.bb
>     <http://ltp_20170929.bb>
>     > +++ b/meta/recipes-extended/ltp/ltp_20170929.bb
>     <http://ltp_20170929.bb>
>     > @@ -108,6 +108,7 @@ RDEPENDS_${PN} = "\
>     >  FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a
>     /opt/ltp/testcases/data/nm01/lib.a"
>     >
>     >  FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/*
>     /opt/ltp/scenario_groups/* /opt/ltp/testcases/bin/*
>     /opt/ltp/testcases/bin/*/bin/* /opt/ltp/testscripts/*
>     /opt/ltp/testcases/open_posix_testsuite/*
>     /opt/ltp/testcases/open_posix_testsuite/conformance/*
>     /opt/ltp/testcases/open_posix_testsuite/Documentation/*
>     /opt/ltp/testcases/open_posix_testsuite/functional/*
>     /opt/ltp/testcases/open_posix_testsuite/include/*
>     /opt/ltp/testcases/open_posix_testsuite/scripts/*
>     /opt/ltp/testcases/open_posix_testsuite/stress/*
>     /opt/ltp/testcases/open_posix_testsuite/tools/*"
>     > +RDEPENDES_${PN} += "${PN}-staticdev"
>
>
> Typo in RDEPENDS
> Please make sure you test patches before submitting. This could not 
> have worked as intended.
>
>     >
>     >  # Avoid generated binaries stripping. Otherwise some of the ltp
>     tests such as ldd01 & nm01 fails
>     >  INHIBIT_PACKAGE_STRIP = "1"
>     > --
>     > 2.8.1
>     >
>     > --
>     > _______________________________________________
>     > Openembedded-core mailing list
>     > Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>


[-- Attachment #2: Type: text/html, Size: 6305 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-12-04  1:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-01  6:58 [PATCH 0/1] ltp: add runtime depends ltp-staticdev Dengke Du
2017-12-01  6:58 ` [PATCH 1/1] " Dengke Du
2017-12-01 14:51   ` Khem Raj
2017-12-01 16:01     ` Tim Orling
2017-12-04  1:18       ` Dengke Du
2017-12-01 16:26     ` Burton, Ross

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox