[PATCH 0/1] systemd: fix PACKAGECONFIG for lz4

[PATCH 0/1] systemd: fix PACKAGECONFIG for lz4

[Robert Yang]

The following changes since commit 978472c58629d1448399207873bbead96b27102e:

  image.bbclass: Add additional bb.debug to help track 12304 (2017-12-18 18:02:12 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/systemd_lz4
  http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/systemd_lz4

Robert Yang (1):
  systemd: fix PACKAGECONFIG for lz4

 meta/recipes-core/systemd/systemd_234.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

[PATCH 1/1] systemd: fix PACKAGECONFIG for lz4

[Robert Yang]

Fixed:
MACHINE = "qemux86-64"
PACKAGECONFIG_append_pn-systemd = "lz4"
DISTRO_FEATURES_append = " systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED += "sysvinit"
VIRTUAL-RUNTIME_init_manager = "systemd"
VIRTUAL-RUNTIME_initscripts = "systemd-compat-units"

$ bitbake core-image-minimal
$ runqemu tmp/deploy/images/qemux86-64/ nographic
/sbin/init: error while loading shared libraries: liblz4.so.1: cannot open shared object file: No such file or directory

Add lz4 to RDEPENDS to fix the problem.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-core/systemd/systemd_234.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/systemd/systemd_234.bb b/meta/recipes-core/systemd/systemd_234.bb
index 778b868..ed82c33 100644
--- a/meta/recipes-core/systemd/systemd_234.bb
+++ b/meta/recipes-core/systemd/systemd_234.bb
@@ -122,7 +122,7 @@ PACKAGECONFIG[ldconfig] = "--enable-ldconfig,--disable-ldconfig"
 PACKAGECONFIG[libidn] = "--enable-libidn,--disable-libidn,libidn"
 PACKAGECONFIG[localed] = "--enable-localed,--disable-localed"
 PACKAGECONFIG[logind] = "--enable-logind,--disable-logind"
-PACKAGECONFIG[lz4] = "--enable-lz4,--disable-lz4,lz4"
+PACKAGECONFIG[lz4] = "--enable-lz4,--disable-lz4,lz4,lz4"
 PACKAGECONFIG[machined] = "--enable-machined,--disable-machined"
 PACKAGECONFIG[manpages] = "--enable-manpages,--disable-manpages,libxslt-native xmlto-native docbook-xml-dtd4-native docbook-xsl-stylesheets-native"
 PACKAGECONFIG[microhttpd] = "--enable-microhttpd,--disable-microhttpd,libmicrohttpd"
-- 
2.7.4

Re: [PATCH 1/1] systemd: fix PACKAGECONFIG for lz4

[ChenQi]

The problem seems to be that the lz4 packaging problem.
lz4-ptest is packages as liblz4 and is installed instead of the lz4 package.

Best Regards,
Chen Qi

On 12/21/2017 12:41 PM, Robert Yang wrote:
> Fixed:
> MACHINE = "qemux86-64"
> PACKAGECONFIG_append_pn-systemd = "lz4"
> DISTRO_FEATURES_append = " systemd"
> DISTRO_FEATURES_BACKFILL_CONSIDERED += "sysvinit"
> VIRTUAL-RUNTIME_init_manager = "systemd"
> VIRTUAL-RUNTIME_initscripts = "systemd-compat-units"
>
> $ bitbake core-image-minimal
> $ runqemu tmp/deploy/images/qemux86-64/ nographic
> /sbin/init: error while loading shared libraries: liblz4.so.1: cannot open shared object file: No such file or directory
>
> Add lz4 to RDEPENDS to fix the problem.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>   meta/recipes-core/systemd/systemd_234.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/systemd/systemd_234.bb b/meta/recipes-core/systemd/systemd_234.bb
> index 778b868..ed82c33 100644
> --- a/meta/recipes-core/systemd/systemd_234.bb
> +++ b/meta/recipes-core/systemd/systemd_234.bb
> @@ -122,7 +122,7 @@ PACKAGECONFIG[ldconfig] = "--enable-ldconfig,--disable-ldconfig"
>   PACKAGECONFIG[libidn] = "--enable-libidn,--disable-libidn,libidn"
>   PACKAGECONFIG[localed] = "--enable-localed,--disable-localed"
>   PACKAGECONFIG[logind] = "--enable-logind,--disable-logind"
> -PACKAGECONFIG[lz4] = "--enable-lz4,--disable-lz4,lz4"
> +PACKAGECONFIG[lz4] = "--enable-lz4,--disable-lz4,lz4,lz4"
>   PACKAGECONFIG[machined] = "--enable-machined,--disable-machined"
>   PACKAGECONFIG[manpages] = "--enable-manpages,--disable-manpages,libxslt-native xmlto-native docbook-xml-dtd4-native docbook-xsl-stylesheets-native"
>   PACKAGECONFIG[microhttpd] = "--enable-microhttpd,--disable-microhttpd,libmicrohttpd"

Re: [PATCH 1/1] systemd: fix PACKAGECONFIG for lz4

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

On 21 December 2017 at 05:55, ChenQi <Qi.Chen@windriver.com> wrote:

> The problem seems to be that the lz4 packaging problem.
> lz4-ptest is packages as liblz4 and is installed instead of the lz4
> package.
>

So that's because lz4-ptest ships a copy of the build tree (so has a
liblz5.so.*) and is before lz4 in PACKAGES.

I've got a patch here to remove the ptest bits from lz4 as shipping an
entire build tree isn't a good idea, and will look at fixing debian.bbclass
so it doesn't consider libraries outside of $libdir et al.

Ross

[-- Attachment #2: Type: text/html, Size: 917 bytes --]

Re: [PATCH 1/1] systemd: fix PACKAGECONFIG for lz4

[Robert Yang]

Hi Ross,

On 12/21/2017 10:17 PM, Burton, Ross wrote:
> On 21 December 2017 at 05:55, ChenQi <Qi.Chen@windriver.com 
> <mailto:Qi.Chen@windriver.com>> wrote:
> 
>     The problem seems to be that the lz4 packaging problem.
>     lz4-ptest is packages as liblz4 and is installed instead of the lz4 package.
> 
> 
> So that's because lz4-ptest ships a copy of the build tree (so has a 
> liblz5.so.*) and is before lz4 in PACKAGES.
> 
> I've got a patch here to remove the ptest bits from lz4 as shipping an entire 
> build tree isn't a good idea, and will look at fixing debian.bbclass so it 
> doesn't consider libraries outside of $libdir et al.

Thank you very much.

// Robert

> 
> Ross