[PATCH 0/2] e2fsprogs: fixes for ptest

[PATCH 0/2] e2fsprogs: fixes for ptest

[jackie.huang]

From: Jackie Huang <jackie.huang@windriver.com>


--
The following changes since commit 385944254d0ef88bd6450a221a54cbcb40020b42:

  tcmode-default.inc: drop preferred version of gzip-native (2018-01-31 17:01:20 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib.git jhuang0/d_e2fsprogs-ptest_180202_0
  http://git.pokylinux.org/cgit.cgi//log/?h=jhuang0/d_e2fsprogs-ptest_180202_0

Jackie Huang (2):
  e2fsprogs: only quiet debugfs for native package
  e2fsprogs: fix the hardcoded paths for ptest

 meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

-- 
2.11.0

[PATCH 1/2] e2fsprogs: only quiet debugfs for native package

[jackie.huang]

From: Jackie Huang <jackie.huang@windriver.com>

Many test cases expect the output of running commands for debugfs,
the patch quiet-debugfs.patch suppress the output so ptest failed:
| 292 tests succeeded   47 tests failed

The patch was meant to suppress the output in do_rootfs according
to the original commit:
======================
commit 13a8d3869b0fe0ebdddcee37fb48c5b9cdf718ba
Author: Ross Burton <ross.burton@intel.com>
Date: Mon Dec 23 13:38:34 2013 +0000

    e2fsprogs: silence debugfs

    debugfs echos the commands when it is executing a script, but as the scripts
    used at rootfs time are long this massively inflates the do_rootfs log.

    Comment out the echo so that the rootfs isn't 20K lines longer than it needs to
    be.

    Signed-off-by: Ross Burton <ross.burton@intel.com>
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
======================

So only apply the patch for native package, then the ptest will
be pass for target package.

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb
index b5cfc6810b..a53585db47 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb
@@ -1,7 +1,6 @@
 require e2fsprogs.inc
 
 SRC_URI += "file://remove.ldconfig.call.patch \
-            file://quiet-debugfs.patch \
             file://run-ptest \
             file://ptest.patch \
             file://Revert-mke2fs-enable-the-metadata_csum-and-64bit-fea.patch \
@@ -10,7 +9,9 @@ SRC_URI += "file://remove.ldconfig.call.patch \
             file://0001-libext2fs-fix-build-failure-in-swapfs.c-on-big-endia.patch \
             "
 
-SRC_URI_append_class-native = " file://e2fsprogs-fix-missing-check-for-permission-denied.patch"
+SRC_URI_append_class-native = " file://e2fsprogs-fix-missing-check-for-permission-denied.patch \
+                                file://quiet-debugfs.patch \
+"
 
 SRCREV = "af2eac481cf426c05ae12b946396980e16c8ab19"
 UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+\.\d+(\.\d+)*)$"
-- 
2.11.0

[PATCH 2/2] e2fsprogs: fix the hardcoded paths for ptest

[jackie.huang]

From: Jackie Huang <jackie.huang@windriver.com>

Fix the hardcoded paths in test scripts and expect
files to avoid issue like:
| cat: ../e2fsck/e2fsck: No such file or directory

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb
index a53585db47..ceaf171585 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb
@@ -104,7 +104,9 @@ do_compile_ptest() {
 do_install_ptest() {
 	cp -R --no-dereference --preserve=mode,links -v ${B}/tests ${D}${PTEST_PATH}/test
 	cp -R --no-dereference --preserve=mode,links -v ${S}/tests/* ${D}${PTEST_PATH}/test
-	sed -e 's!../e2fsck/e2fsck!e2fsck!g' -i ${D}${PTEST_PATH}/test/*/expect*
+	sed -e 's!../e2fsck/e2fsck!e2fsck!g' \
+	    -e 's!../misc/tune2fs!tune2fs!g' -i ${D}${PTEST_PATH}/test/*/expect*
+	sed -e 's!../e2fsck/e2fsck!${base_sbindir}/e2fsck!g' -i ${D}${PTEST_PATH}/test/*/script
 
 	# Remove various files
 	find "${D}${PTEST_PATH}" -type f \
-- 
2.11.0

✗ patchtest: failure for e2fsprogs: fixes for ptest

[Patchwork]

== Series Details ==

Series: e2fsprogs: fixes for ptest
Revision: 1
URL   : https://patchwork.openembedded.org/series/10824/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Patches not removed from tree [test_src_uri_left_files] 
  Suggested fix    Amend the patch containing the software patch file removal
  Patch            quiet-debugfs.patch



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: ✗ patchtest: failure for e2fsprogs: fixes for ptest

[Huang, Jie (Jackie)]

> -----Original Message-----
> From: Patchwork [mailto:patchwork@do.openembedded.org]
> Sent: Friday, February 02, 2018 15:33
> To: Huang, Jie (Jackie)
> Cc: openembedded-core@lists.openembedded.org
> Subject: ✗ patchtest: failure for e2fsprogs: fixes for ptest
> 
> == Series Details ==
> 
> Series: e2fsprogs: fixes for ptest
> Revision: 1
> URL   : https://patchwork.openembedded.org/series/10824/
> State : failure
> 
> == Summary ==
> 
> 
> Thank you for submitting this patch series to OpenEmbedded Core. This is
> an automated response. Several tests have been executed on the proposed
> series by patchtest resulting in the following failures:
> 
> 
> 
> * Issue             Patches not removed from tree [test_src_uri_left_files]
>   Suggested fix    Amend the patch containing the software patch file removal
>   Patch            quiet-debugfs.patch

What I did is moving the "quiet-debugfs.patch" from SRC_URI to SRC_URI_append_class-native,
the patch file is not meant to be removed.

I think the test_src_uri_left_files needs to consider such changes.

Thanks,
Jackie

> 
> 
> 
> If you believe any of these test results are incorrect, please reply to the
> mailing list (openembedded-core@lists.openembedded.org) raising your
> concerns.
> Otherwise we would appreciate you correcting the issues and submitting a
> new
> version of the patchset if applicable. Please ensure you add/increment the
> version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
> [PATCH v3] -> ...).
> 
> ---
> Guidelines:
> https://www.openembedded.org/wiki/Commit_Patch_Message_Guideline
> s
> Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
> Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: ✗ patchtest: failure for e2fsprogs: fixes for ptest

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 2248 bytes --]

Yes, this clearly isn't right.

On 2 February 2018 at 07:52, Huang, Jie (Jackie) <Jackie.Huang@windriver.com
> wrote:

>
>
> > -----Original Message-----
> > From: Patchwork [mailto:patchwork@do.openembedded.org]
> > Sent: Friday, February 02, 2018 15:33
> > To: Huang, Jie (Jackie)
> > Cc: openembedded-core@lists.openembedded.org
> > Subject: ✗ patchtest: failure for e2fsprogs: fixes for ptest
> >
> > == Series Details ==
> >
> > Series: e2fsprogs: fixes for ptest
> > Revision: 1
> > URL   : https://patchwork.openembedded.org/series/10824/
> > State : failure
> >
> > == Summary ==
> >
> >
> > Thank you for submitting this patch series to OpenEmbedded Core. This is
> > an automated response. Several tests have been executed on the proposed
> > series by patchtest resulting in the following failures:
> >
> >
> >
> > * Issue             Patches not removed from tree
> [test_src_uri_left_files]
> >   Suggested fix    Amend the patch containing the software patch file
> removal
> >   Patch            quiet-debugfs.patch
>
> What I did is moving the "quiet-debugfs.patch" from SRC_URI to
> SRC_URI_append_class-native,
> the patch file is not meant to be removed.
>
> I think the test_src_uri_left_files needs to consider such changes.
>
> Thanks,
> Jackie
>
> >
> >
> >
> > If you believe any of these test results are incorrect, please reply to
> the
> > mailing list (openembedded-core@lists.openembedded.org) raising your
> > concerns.
> > Otherwise we would appreciate you correcting the issues and submitting a
> > new
> > version of the patchset if applicable. Please ensure you add/increment
> the
> > version number when sending the new version (i.e. [PATCH] -> [PATCH v2]
> ->
> > [PATCH v3] -> ...).
> >
> > ---
> > Guidelines:
> > https://www.openembedded.org/wiki/Commit_Patch_Message_Guideline
> > s
> > Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
> > Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3718 bytes --]