Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH v2 0/1] waf.bbclass: Throw error if waf doesn't exist
@ 2018-03-22 19:12 Amanda Brindle
  2018-03-22 19:12 ` [PATCH v2 1/1] " Amanda Brindle
  0 siblings, 1 reply; 2+ messages in thread
From: Amanda Brindle @ 2018-03-22 19:12 UTC (permalink / raw)
  To: openembedded-core; +Cc: Amanda Brindle, stephano.cetola

In v2, change bb.warn to bb.fatal

The following changes since commit f49ee61422c867516db252054e993df29f775136:

  systemd-boot: upgrade to 237 (2018-03-20 09:59:33 +0000)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib abrindle/waf_error
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=abrindle/waf_error

Amanda Brindle (1):
  waf.bbclass: Throw error if waf doesn't exist

 meta/classes/waf.bbclass | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.7.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v2 1/1] waf.bbclass: Throw error if waf doesn't exist
  2018-03-22 19:12 [PATCH v2 0/1] waf.bbclass: Throw error if waf doesn't exist Amanda Brindle
@ 2018-03-22 19:12 ` Amanda Brindle
  0 siblings, 0 replies; 2+ messages in thread
From: Amanda Brindle @ 2018-03-22 19:12 UTC (permalink / raw)
  To: openembedded-core; +Cc: Amanda Brindle, stephano.cetola

Before, waf.bbclass would fail to catch FileNotFoundError. Now, it will
catch this error and say that waf doesn't exist.

Fixes [YOCTO 12553]

Signed-off-by: Amanda Brindle <amanda.r.brindle@intel.com>
---
 meta/classes/waf.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/waf.bbclass b/meta/classes/waf.bbclass
index f9a851d..19e9376 100644
--- a/meta/classes/waf.bbclass
+++ b/meta/classes/waf.bbclass
@@ -15,6 +15,8 @@ python waf_preconfigure() {
             d.setVar("WAF_EXTRA_CONF", "--bindir=${bindir} --libdir=${libdir}")
     except subprocess.CalledProcessError as e:
         bb.warn("Unable to execute waf --version, exit code %d. Assuming waf version without bindir/libdir support." % e.returncode)
+    except FileNotFoundError:
+        bb.fatal("waf does not exist in %s" % subsrcdir)
 }
 
 do_configure[prefuncs] += "waf_preconfigure"
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-22 19:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-22 19:12 [PATCH v2 0/1] waf.bbclass: Throw error if waf doesn't exist Amanda Brindle
2018-03-22 19:12 ` [PATCH v2 1/1] " Amanda Brindle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox