* [PATCH 0/1] create-pull-request: handle '/' in subject correctly
@ 2018-05-08 8:34 Chen Qi
2018-05-08 8:34 ` [PATCH 1/1] " Chen Qi
2018-05-16 5:10 ` [PATCH 0/1] " ChenQi
0 siblings, 2 replies; 4+ messages in thread
From: Chen Qi @ 2018-05-08 8:34 UTC (permalink / raw)
To: openembedded-core
The following changes since commit f301a3bc110608c3684c78dd62e276beea73bd94:
settings-daemon: Drop pointless apply=yes in SRC_URI (2018-05-04 13:28:06 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib ChenQi/create-pull-request-fix
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/create-pull-request-fix
Chen Qi (1):
create-pull-request: handle '/' in subject correctly
scripts/create-pull-request | 1 +
1 file changed, 1 insertion(+)
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] create-pull-request: handle '/' in subject correctly
2018-05-08 8:34 [PATCH 0/1] create-pull-request: handle '/' in subject correctly Chen Qi
@ 2018-05-08 8:34 ` Chen Qi
2018-06-06 7:37 ` ChenQi
2018-05-16 5:10 ` [PATCH 0/1] " ChenQi
1 sibling, 1 reply; 4+ messages in thread
From: Chen Qi @ 2018-05-08 8:34 UTC (permalink / raw)
To: openembedded-core
When subject contains '/', we will meet the following error when
using create-pull-request.
sed: -e expression #1, char 59: unknown option to `s'
The problem is not critical. But it's better to fix it.
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
scripts/create-pull-request | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/create-pull-request b/scripts/create-pull-request
index 280880b..b4cf706 100755
--- a/scripts/create-pull-request
+++ b/scripts/create-pull-request
@@ -278,6 +278,7 @@ fi
# Replace the SUBJECT token with it.
if [ -n "$SUBJECT" ]; then
+ SUBJECT="`echo $SUBJECT | sed -e 's#/#\\\\/#g'`"
sed -i -e "s/\*\*\* SUBJECT HERE \*\*\*/$SUBJECT/" "$CL"
fi
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] create-pull-request: handle '/' in subject correctly
2018-05-08 8:34 ` [PATCH 1/1] " Chen Qi
@ 2018-06-06 7:37 ` ChenQi
0 siblings, 0 replies; 4+ messages in thread
From: ChenQi @ 2018-06-06 7:37 UTC (permalink / raw)
To: openembedded-core
ping
On 05/08/2018 04:34 PM, Chen Qi wrote:
> When subject contains '/', we will meet the following error when
> using create-pull-request.
>
> sed: -e expression #1, char 59: unknown option to `s'
>
> The problem is not critical. But it's better to fix it.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> scripts/create-pull-request | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/create-pull-request b/scripts/create-pull-request
> index 280880b..b4cf706 100755
> --- a/scripts/create-pull-request
> +++ b/scripts/create-pull-request
> @@ -278,6 +278,7 @@ fi
>
> # Replace the SUBJECT token with it.
> if [ -n "$SUBJECT" ]; then
> + SUBJECT="`echo $SUBJECT | sed -e 's#/#\\\\/#g'`"
> sed -i -e "s/\*\*\* SUBJECT HERE \*\*\*/$SUBJECT/" "$CL"
> fi
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/1] create-pull-request: handle '/' in subject correctly
2018-05-08 8:34 [PATCH 0/1] create-pull-request: handle '/' in subject correctly Chen Qi
2018-05-08 8:34 ` [PATCH 1/1] " Chen Qi
@ 2018-05-16 5:10 ` ChenQi
1 sibling, 0 replies; 4+ messages in thread
From: ChenQi @ 2018-05-16 5:10 UTC (permalink / raw)
To: openembedded-core
ping
On 05/08/2018 04:34 PM, Chen Qi wrote:
> The following changes since commit f301a3bc110608c3684c78dd62e276beea73bd94:
>
> settings-daemon: Drop pointless apply=yes in SRC_URI (2018-05-04 13:28:06 +0100)
>
> are available in the git repository at:
>
> git://git.pokylinux.org/poky-contrib ChenQi/create-pull-request-fix
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/create-pull-request-fix
>
> Chen Qi (1):
> create-pull-request: handle '/' in subject correctly
>
> scripts/create-pull-request | 1 +
> 1 file changed, 1 insertion(+)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-06 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-08 8:34 [PATCH 0/1] create-pull-request: handle '/' in subject correctly Chen Qi
2018-05-08 8:34 ` [PATCH 1/1] " Chen Qi
2018-06-06 7:37 ` ChenQi
2018-05-16 5:10 ` [PATCH 0/1] " ChenQi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox