* [PATCH V3 0/5] Use llvmpile for mesa on x86/x86-64
@ 2018-08-20 18:59 Khem Raj
2018-08-20 18:59 ` [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 Khem Raj
` (4 more replies)
0 siblings, 5 replies; 17+ messages in thread
From: Khem Raj @ 2018-08-20 18:59 UTC (permalink / raw)
To: openembedded-core
This series fixes llvm build to support multilib configurations
Adds dos2unix bbclass to core from meta-oe
Fixes ppc security flags world builds
v2:
Upgrade binutils and gdb
Fix libidb2 cross build issue when build host == target host
v3:
Fix sstate differences between different builds for llvm-native
Fix gdb on x86_64/musl
Import dos2unix recipe into core along with bbclass
The following changes since commit 3cb303ffee8610d41c9a0745d366556c24066bc3:
weston-init: run login before start weston.service (2018-08-20 11:59:44 +0100)
are available in the Git repository at:
git://git.openembedded.org/openembedded-core-contrib kraj/master
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=kraj/master
Khem Raj (5):
mesa: Enable gallium-llvm on x86 and x86_64
gdb: Upgrade to 8.1.1
gdb: Alias rpl_stat to stat() on musl
dos2unix.bbclass: Move to oe-core
llvm: Use HOST_ARCH in LLVM_TARGETS_TO_BUILD for builds
meta/conf/distro/include/maintainers.inc | 1 +
.../gdb/{gdb-8.1.inc => gdb-8.1.1.inc} | 4 +--
...ian_8.1.bb => gdb-cross-canadian_8.1.1.bb} | 0
.../{gdb-cross_8.1.bb => gdb-cross_8.1.1.bb} | 0
.../gdb/{gdb_8.1.bb => gdb_8.1.1.bb} | 2 +-
meta/recipes-devtools/llvm/llvm_git.bb | 11 +++---
meta/recipes-graphics/cairo/cairo.inc | 3 +-
meta/recipes-graphics/mesa/mesa.inc | 3 ++
.../dos2unix/dos2unix_7.4.0.bb | 34 +++++++++++++++++++
9 files changed, 49 insertions(+), 9 deletions(-)
rename meta/recipes-devtools/gdb/{gdb-8.1.inc => gdb-8.1.1.inc} (89%)
rename meta/recipes-devtools/gdb/{gdb-cross-canadian_8.1.bb => gdb-cross-canadian_8.1.1.bb} (100%)
rename meta/recipes-devtools/gdb/{gdb-cross_8.1.bb => gdb-cross_8.1.1.bb} (100%)
rename meta/recipes-devtools/gdb/{gdb_8.1.bb => gdb_8.1.1.bb} (92%)
create mode 100644 meta/recipes-support/dos2unix/dos2unix_7.4.0.bb
--
2.18.0
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 2018-08-20 18:59 [PATCH V3 0/5] Use llvmpile for mesa on x86/x86-64 Khem Raj @ 2018-08-20 18:59 ` Khem Raj 2018-08-27 21:15 ` Andreas Müller 2018-08-20 18:59 ` [PATCH 2/5] gdb: Upgrade to 8.1.1 Khem Raj ` (3 subsequent siblings) 4 siblings, 1 reply; 17+ messages in thread From: Khem Raj @ 2018-08-20 18:59 UTC (permalink / raw) To: openembedded-core Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-graphics/cairo/cairo.inc | 3 ++- meta/recipes-graphics/mesa/mesa.inc | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/meta/recipes-graphics/cairo/cairo.inc b/meta/recipes-graphics/cairo/cairo.inc index 20e0d2c92a..7347f223ff 100644 --- a/meta/recipes-graphics/cairo/cairo.inc +++ b/meta/recipes-graphics/cairo/cairo.inc @@ -22,7 +22,8 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxext" DEPENDS = "libpng fontconfig pixman glib-2.0 zlib" PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 xcb', '', d)} \ - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)}" + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \ + ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'opengl', '', d)}" PACKAGECONFIG[x11] = "--with-x=yes -enable-xlib,--with-x=no --disable-xlib,${X11DEPENDS}" PACKAGECONFIG[xcb] = "--enable-xcb,--disable-xcb,libxcb" diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc index 5afd0db4b7..dd626d9f00 100644 --- a/meta/recipes-graphics/mesa/mesa.inc +++ b/meta/recipes-graphics/mesa/mesa.inc @@ -48,6 +48,9 @@ PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'wayland vulkan', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11 vulkan', 'dri3', '', d)} \ " +PACKAGECONFIG_append_x86 = " gallium-llvm gallium r600" +PACKAGECONFIG_append_x86-64 = " gallium-llvm gallium r600" + # "gbm" requires "dri", "opengl" PACKAGECONFIG[gbm] = "--enable-gbm,--disable-gbm" -- 2.18.0 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 2018-08-20 18:59 ` [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 Khem Raj @ 2018-08-27 21:15 ` Andreas Müller 2018-08-27 22:55 ` Khem Raj 0 siblings, 1 reply; 17+ messages in thread From: Andreas Müller @ 2018-08-27 21:15 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer On Mon, Aug 20, 2018 at 8:59 PM, Khem Raj <raj.khem@gmail.com> wrote: > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/recipes-graphics/cairo/cairo.inc | 3 ++- > meta/recipes-graphics/mesa/mesa.inc | 3 +++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-graphics/cairo/cairo.inc b/meta/recipes-graphics/cairo/cairo.inc > index 20e0d2c92a..7347f223ff 100644 > --- a/meta/recipes-graphics/cairo/cairo.inc > +++ b/meta/recipes-graphics/cairo/cairo.inc > @@ -22,7 +22,8 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxext" > DEPENDS = "libpng fontconfig pixman glib-2.0 zlib" > > PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 xcb', '', d)} \ > - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)}" > + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \ > + ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'opengl', '', d)}" > > PACKAGECONFIG[x11] = "--with-x=yes -enable-xlib,--with-x=no --disable-xlib,${X11DEPENDS}" > PACKAGECONFIG[xcb] = "--enable-xcb,--disable-xcb,libxcb" > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc > index 5afd0db4b7..dd626d9f00 100644 ^ I think this came in accidentaly and it breaks builds when adding packageconfig glesv2: | configure: error: use either --enable-gl=yes or --enable-glesv2=yes. Not both at the same time. Please check Andreas ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 2018-08-27 21:15 ` Andreas Müller @ 2018-08-27 22:55 ` Khem Raj 2018-08-28 6:43 ` Andreas Müller 0 siblings, 1 reply; 17+ messages in thread From: Khem Raj @ 2018-08-27 22:55 UTC (permalink / raw) To: Andreas Müller; +Cc: Patches and discussions about the oe-core layer On Mon, Aug 27, 2018 at 2:15 PM Andreas Müller <schnitzeltony@gmail.com> wrote: > > On Mon, Aug 20, 2018 at 8:59 PM, Khem Raj <raj.khem@gmail.com> wrote: > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > meta/recipes-graphics/cairo/cairo.inc | 3 ++- > > meta/recipes-graphics/mesa/mesa.inc | 3 +++ > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/meta/recipes-graphics/cairo/cairo.inc b/meta/recipes-graphics/cairo/cairo.inc > > index 20e0d2c92a..7347f223ff 100644 > > --- a/meta/recipes-graphics/cairo/cairo.inc > > +++ b/meta/recipes-graphics/cairo/cairo.inc > > @@ -22,7 +22,8 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxext" > > DEPENDS = "libpng fontconfig pixman glib-2.0 zlib" > > > > PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 xcb', '', d)} \ > > - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)}" > > + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \ > > + ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'opengl', '', d)}" > > > > PACKAGECONFIG[x11] = "--with-x=yes -enable-xlib,--with-x=no --disable-xlib,${X11DEPENDS}" > > PACKAGECONFIG[xcb] = "--enable-xcb,--disable-xcb,libxcb" > > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc > > index 5afd0db4b7..dd626d9f00 100644 > ^ I think this came in accidentaly and it breaks builds when adding > packageconfig glesv2: > > | configure: error: use either --enable-gl=yes or --enable-glesv2=yes. > Not both at the same time. do you remove opengl from DISTRO_FEATURES when enabling glesv2 ? try that out. > > Please check > > Andreas ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 2018-08-27 22:55 ` Khem Raj @ 2018-08-28 6:43 ` Andreas Müller 2018-08-28 17:21 ` Andreas Müller 0 siblings, 1 reply; 17+ messages in thread From: Andreas Müller @ 2018-08-28 6:43 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer On Tue, Aug 28, 2018 at 12:55 AM, Khem Raj <raj.khem@gmail.com> wrote: > On Mon, Aug 27, 2018 at 2:15 PM Andreas Müller <schnitzeltony@gmail.com> wrote: >> >> On Mon, Aug 20, 2018 at 8:59 PM, Khem Raj <raj.khem@gmail.com> wrote: >> > Signed-off-by: Khem Raj <raj.khem@gmail.com> >> > --- >> > meta/recipes-graphics/cairo/cairo.inc | 3 ++- >> > meta/recipes-graphics/mesa/mesa.inc | 3 +++ >> > 2 files changed, 5 insertions(+), 1 deletion(-) >> > >> > diff --git a/meta/recipes-graphics/cairo/cairo.inc b/meta/recipes-graphics/cairo/cairo.inc >> > index 20e0d2c92a..7347f223ff 100644 >> > --- a/meta/recipes-graphics/cairo/cairo.inc >> > +++ b/meta/recipes-graphics/cairo/cairo.inc >> > @@ -22,7 +22,8 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxext" >> > DEPENDS = "libpng fontconfig pixman glib-2.0 zlib" >> > >> > PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 xcb', '', d)} \ >> > - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)}" >> > + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \ >> > + ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'opengl', '', d)}" >> > >> > PACKAGECONFIG[x11] = "--with-x=yes -enable-xlib,--with-x=no --disable-xlib,${X11DEPENDS}" >> > PACKAGECONFIG[xcb] = "--enable-xcb,--disable-xcb,libxcb" >> > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc >> > index 5afd0db4b7..dd626d9f00 100644 >> ^ I think this came in accidentaly and it breaks builds when adding >> packageconfig glesv2: >> >> | configure: error: use either --enable-gl=yes or --enable-glesv2=yes. >> Not both at the same time. > > do you remove opengl from DISTRO_FEATURES when enabling glesv2 ? > try that out. > >> Yes of course I can. But this patch is wrong - we don't have gles as distro feature - and it is not even mentioned in commit message why this is done. Andreas ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 2018-08-28 6:43 ` Andreas Müller @ 2018-08-28 17:21 ` Andreas Müller 2018-08-28 17:36 ` Khem Raj 0 siblings, 1 reply; 17+ messages in thread From: Andreas Müller @ 2018-08-28 17:21 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer On Tue, Aug 28, 2018 at 8:43 AM, Andreas Müller <schnitzeltony@gmail.com> wrote: > On Tue, Aug 28, 2018 at 12:55 AM, Khem Raj <raj.khem@gmail.com> wrote: >> On Mon, Aug 27, 2018 at 2:15 PM Andreas Müller <schnitzeltony@gmail.com> wrote: >>> >>> On Mon, Aug 20, 2018 at 8:59 PM, Khem Raj <raj.khem@gmail.com> wrote: >>> > Signed-off-by: Khem Raj <raj.khem@gmail.com> >>> > --- >>> > meta/recipes-graphics/cairo/cairo.inc | 3 ++- >>> > meta/recipes-graphics/mesa/mesa.inc | 3 +++ >>> > 2 files changed, 5 insertions(+), 1 deletion(-) >>> > >>> > diff --git a/meta/recipes-graphics/cairo/cairo.inc b/meta/recipes-graphics/cairo/cairo.inc >>> > index 20e0d2c92a..7347f223ff 100644 >>> > --- a/meta/recipes-graphics/cairo/cairo.inc >>> > +++ b/meta/recipes-graphics/cairo/cairo.inc >>> > @@ -22,7 +22,8 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxext" >>> > DEPENDS = "libpng fontconfig pixman glib-2.0 zlib" >>> > >>> > PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 xcb', '', d)} \ >>> > - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)}" >>> > + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \ >>> > + ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'opengl', '', d)}" >>> > >>> > PACKAGECONFIG[x11] = "--with-x=yes -enable-xlib,--with-x=no --disable-xlib,${X11DEPENDS}" >>> > PACKAGECONFIG[xcb] = "--enable-xcb,--disable-xcb,libxcb" >>> > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc >>> > index 5afd0db4b7..dd626d9f00 100644 >>> ^ I think this came in accidentaly and it breaks builds when adding >>> packageconfig glesv2: >>> >>> | configure: error: use either --enable-gl=yes or --enable-glesv2=yes. >>> Not both at the same time. >> >> do you remove opengl from DISTRO_FEATURES when enabling glesv2 ? >> try that out. >> >>> > Yes of course I can. But this patch is wrong - we don't have gles as > distro feature - and it is not even mentioned in commit message why > this is done. > I am tempted to send a revert for the cairo part: * Cross: It changes defaults valid for long time * Native: As far as I can remember it causes trouble for cairo-native * It went through without mentioning Andreas ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 2018-08-28 17:21 ` Andreas Müller @ 2018-08-28 17:36 ` Khem Raj 2018-08-28 18:28 ` Andreas Müller 0 siblings, 1 reply; 17+ messages in thread From: Khem Raj @ 2018-08-28 17:36 UTC (permalink / raw) To: Andreas Müller; +Cc: Patches and discussions about the oe-core layer Hi Andreas On Tue, Aug 28, 2018 at 10:21 AM Andreas Müller <schnitzeltony@gmail.com> wrote: > > On Tue, Aug 28, 2018 at 8:43 AM, Andreas Müller <schnitzeltony@gmail.com> wrote: > > On Tue, Aug 28, 2018 at 12:55 AM, Khem Raj <raj.khem@gmail.com> wrote: > >> On Mon, Aug 27, 2018 at 2:15 PM Andreas Müller <schnitzeltony@gmail.com> wrote: > >>> > >>> On Mon, Aug 20, 2018 at 8:59 PM, Khem Raj <raj.khem@gmail.com> wrote: > >>> > Signed-off-by: Khem Raj <raj.khem@gmail.com> > >>> > --- > >>> > meta/recipes-graphics/cairo/cairo.inc | 3 ++- > >>> > meta/recipes-graphics/mesa/mesa.inc | 3 +++ > >>> > 2 files changed, 5 insertions(+), 1 deletion(-) > >>> > > >>> > diff --git a/meta/recipes-graphics/cairo/cairo.inc b/meta/recipes-graphics/cairo/cairo.inc > >>> > index 20e0d2c92a..7347f223ff 100644 > >>> > --- a/meta/recipes-graphics/cairo/cairo.inc > >>> > +++ b/meta/recipes-graphics/cairo/cairo.inc > >>> > @@ -22,7 +22,8 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxext" > >>> > DEPENDS = "libpng fontconfig pixman glib-2.0 zlib" > >>> > > >>> > PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 xcb', '', d)} \ > >>> > - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)}" > >>> > + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \ > >>> > + ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'opengl', '', d)}" > >>> > > >>> > PACKAGECONFIG[x11] = "--with-x=yes -enable-xlib,--with-x=no --disable-xlib,${X11DEPENDS}" > >>> > PACKAGECONFIG[xcb] = "--enable-xcb,--disable-xcb,libxcb" > >>> > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc > >>> > index 5afd0db4b7..dd626d9f00 100644 > >>> ^ I think this came in accidentaly and it breaks builds when adding > >>> packageconfig glesv2: > >>> > >>> | configure: error: use either --enable-gl=yes or --enable-glesv2=yes. > >>> Not both at the same time. > >> > >> do you remove opengl from DISTRO_FEATURES when enabling glesv2 ? > >> try that out. > >> > >>> > > Yes of course I can. But this patch is wrong - we don't have gles as > > distro feature - and it is not even mentioned in commit message why > > this is done. > > > I am tempted to send a revert for the cairo part: > > * Cross: It changes defaults valid for long time > * Native: As far as I can remember it causes trouble for cairo-native > * It went through without mentioning opengl as a DISTRO_FEATURE should tie into packageconfigs, the situation before this patch was not ideal, people got to work with it. as seen in the example you cited, we can't mix opengl and gles support in packages. other layers have solved your kind of usecase like below https://github.com/WebPlatformForEmbedded/meta-wpe/blob/master/recipes-graphics/cairo/cairo_%.bbappend > > Andreas ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 2018-08-28 17:36 ` Khem Raj @ 2018-08-28 18:28 ` Andreas Müller 2018-08-28 20:20 ` Khem Raj 0 siblings, 1 reply; 17+ messages in thread From: Andreas Müller @ 2018-08-28 18:28 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer On Tue, Aug 28, 2018 at 7:36 PM, Khem Raj <raj.khem@gmail.com> wrote: > Hi Andreas > > On Tue, Aug 28, 2018 at 10:21 AM Andreas Müller <schnitzeltony@gmail.com> wrote: >> >> On Tue, Aug 28, 2018 at 8:43 AM, Andreas Müller <schnitzeltony@gmail.com> wrote: >> > On Tue, Aug 28, 2018 at 12:55 AM, Khem Raj <raj.khem@gmail.com> wrote: >> >> On Mon, Aug 27, 2018 at 2:15 PM Andreas Müller <schnitzeltony@gmail.com> wrote: >> >>> >> >>> On Mon, Aug 20, 2018 at 8:59 PM, Khem Raj <raj.khem@gmail.com> wrote: >> >>> > Signed-off-by: Khem Raj <raj.khem@gmail.com> >> >>> > --- >> >>> > meta/recipes-graphics/cairo/cairo.inc | 3 ++- >> >>> > meta/recipes-graphics/mesa/mesa.inc | 3 +++ >> >>> > 2 files changed, 5 insertions(+), 1 deletion(-) >> >>> > >> >>> > diff --git a/meta/recipes-graphics/cairo/cairo.inc b/meta/recipes-graphics/cairo/cairo.inc >> >>> > index 20e0d2c92a..7347f223ff 100644 >> >>> > --- a/meta/recipes-graphics/cairo/cairo.inc >> >>> > +++ b/meta/recipes-graphics/cairo/cairo.inc >> >>> > @@ -22,7 +22,8 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxext" >> >>> > DEPENDS = "libpng fontconfig pixman glib-2.0 zlib" >> >>> > >> >>> > PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 xcb', '', d)} \ >> >>> > - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)}" >> >>> > + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \ >> >>> > + ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'opengl', '', d)}" >> >>> > >> >>> > PACKAGECONFIG[x11] = "--with-x=yes -enable-xlib,--with-x=no --disable-xlib,${X11DEPENDS}" >> >>> > PACKAGECONFIG[xcb] = "--enable-xcb,--disable-xcb,libxcb" >> >>> > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc >> >>> > index 5afd0db4b7..dd626d9f00 100644 >> >>> ^ I think this came in accidentaly and it breaks builds when adding >> >>> packageconfig glesv2: >> >>> >> >>> | configure: error: use either --enable-gl=yes or --enable-glesv2=yes. >> >>> Not both at the same time. >> >> >> >> do you remove opengl from DISTRO_FEATURES when enabling glesv2 ? >> >> try that out. >> >> >> >>> >> > Yes of course I can. But this patch is wrong - we don't have gles as >> > distro feature - and it is not even mentioned in commit message why >> > this is done. >> > >> I am tempted to send a revert for the cairo part: >> >> * Cross: It changes defaults valid for long time >> * Native: As far as I can remember it causes trouble for cairo-native >> * It went through without mentioning > > opengl as a DISTRO_FEATURE should tie into packageconfigs, the > situation before this patch was not ideal, people got to work with it. > > as seen in the example you cited, we can't mix opengl and gles support > in packages. other layers have solved your kind of usecase like below > > https://github.com/WebPlatformForEmbedded/meta-wpe/blob/master/recipes-graphics/cairo/cairo_%.bbappend * ^The link is broken * Am quite sure that it breaks cairo-native or dependants (have no logs at hand - it is some time ago) * Again: I consider this a major change and it was not even mentioned/discussed. To me it has nothing to do with 'mesa: Enable gallium-llvm on x86 and x86_64' - btw: what does that fix? Let's close discussion here - I think after all these years here I am able to find a workaround in case of further issues. Thanks for support. Andreas ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 2018-08-28 18:28 ` Andreas Müller @ 2018-08-28 20:20 ` Khem Raj 2018-08-28 20:51 ` Andreas Müller 0 siblings, 1 reply; 17+ messages in thread From: Khem Raj @ 2018-08-28 20:20 UTC (permalink / raw) To: Andreas Müller; +Cc: Patches and discussions about the oe-core layer Hi Andreas On Tue, Aug 28, 2018 at 11:28 AM Andreas Müller <schnitzeltony@gmail.com> wrote: > > On Tue, Aug 28, 2018 at 7:36 PM, Khem Raj <raj.khem@gmail.com> wrote: > > Hi Andreas > > > > On Tue, Aug 28, 2018 at 10:21 AM Andreas Müller <schnitzeltony@gmail.com> wrote: > >> > >> On Tue, Aug 28, 2018 at 8:43 AM, Andreas Müller <schnitzeltony@gmail.com> wrote: > >> > On Tue, Aug 28, 2018 at 12:55 AM, Khem Raj <raj.khem@gmail.com> wrote: > >> >> On Mon, Aug 27, 2018 at 2:15 PM Andreas Müller <schnitzeltony@gmail.com> wrote: > >> >>> > >> >>> On Mon, Aug 20, 2018 at 8:59 PM, Khem Raj <raj.khem@gmail.com> wrote: > >> >>> > Signed-off-by: Khem Raj <raj.khem@gmail.com> > >> >>> > --- > >> >>> > meta/recipes-graphics/cairo/cairo.inc | 3 ++- > >> >>> > meta/recipes-graphics/mesa/mesa.inc | 3 +++ > >> >>> > 2 files changed, 5 insertions(+), 1 deletion(-) > >> >>> > > >> >>> > diff --git a/meta/recipes-graphics/cairo/cairo.inc b/meta/recipes-graphics/cairo/cairo.inc > >> >>> > index 20e0d2c92a..7347f223ff 100644 > >> >>> > --- a/meta/recipes-graphics/cairo/cairo.inc > >> >>> > +++ b/meta/recipes-graphics/cairo/cairo.inc > >> >>> > @@ -22,7 +22,8 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxext" > >> >>> > DEPENDS = "libpng fontconfig pixman glib-2.0 zlib" > >> >>> > > >> >>> > PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 xcb', '', d)} \ > >> >>> > - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)}" > >> >>> > + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \ > >> >>> > + ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'opengl', '', d)}" > >> >>> > > >> >>> > PACKAGECONFIG[x11] = "--with-x=yes -enable-xlib,--with-x=no --disable-xlib,${X11DEPENDS}" > >> >>> > PACKAGECONFIG[xcb] = "--enable-xcb,--disable-xcb,libxcb" > >> >>> > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc > >> >>> > index 5afd0db4b7..dd626d9f00 100644 > >> >>> ^ I think this came in accidentaly and it breaks builds when adding > >> >>> packageconfig glesv2: > >> >>> > >> >>> | configure: error: use either --enable-gl=yes or --enable-glesv2=yes. > >> >>> Not both at the same time. > >> >> > >> >> do you remove opengl from DISTRO_FEATURES when enabling glesv2 ? > >> >> try that out. > >> >> > >> >>> > >> > Yes of course I can. But this patch is wrong - we don't have gles as > >> > distro feature - and it is not even mentioned in commit message why > >> > this is done. > >> > > >> I am tempted to send a revert for the cairo part: > >> > >> * Cross: It changes defaults valid for long time > >> * Native: As far as I can remember it causes trouble for cairo-native > >> * It went through without mentioning > > > > opengl as a DISTRO_FEATURE should tie into packageconfigs, the > > situation before this patch was not ideal, people got to work with it. > > > > as seen in the example you cited, we can't mix opengl and gles support > > in packages. other layers have solved your kind of usecase like below > > > > https://github.com/WebPlatformForEmbedded/meta-wpe/blob/master/recipes-graphics/cairo/cairo_%.bbappend > * ^The link is broken ah see cairo bbappend here https://github.com/WebPlatformForEmbedded/meta-wpe/tree/master/recipes-graphics/cairo > * Am quite sure that it breaks cairo-native or dependants (have no > logs at hand - it is some time ago) > * Again: I consider this a major change and it was not even > mentioned/discussed. To me it has nothing to do with 'mesa: Enable > gallium-llvm on x86 and x86_64' - btw: what does that fix? > gallium is for enabling Gallium llvmpipe driver as rasterizer using llvm IR code generator. > Let's close discussion here - I think after all these years here I am > able to find a workaround in case of further issues. Thanks for > support. > > Andreas ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 2018-08-28 20:20 ` Khem Raj @ 2018-08-28 20:51 ` Andreas Müller 0 siblings, 0 replies; 17+ messages in thread From: Andreas Müller @ 2018-08-28 20:51 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer On Tue, Aug 28, 2018 at 10:20 PM, Khem Raj <raj.khem@gmail.com> wrote: > Hi Andreas > On Tue, Aug 28, 2018 at 11:28 AM Andreas Müller <schnitzeltony@gmail.com> wrote: >> >> On Tue, Aug 28, 2018 at 7:36 PM, Khem Raj <raj.khem@gmail.com> wrote: >> > Hi Andreas >> > >> > On Tue, Aug 28, 2018 at 10:21 AM Andreas Müller <schnitzeltony@gmail.com> wrote: >> >> >> >> On Tue, Aug 28, 2018 at 8:43 AM, Andreas Müller <schnitzeltony@gmail.com> wrote: >> >> > On Tue, Aug 28, 2018 at 12:55 AM, Khem Raj <raj.khem@gmail.com> wrote: >> >> >> On Mon, Aug 27, 2018 at 2:15 PM Andreas Müller <schnitzeltony@gmail.com> wrote: >> >> >>> >> >> >>> On Mon, Aug 20, 2018 at 8:59 PM, Khem Raj <raj.khem@gmail.com> wrote: >> >> >>> > Signed-off-by: Khem Raj <raj.khem@gmail.com> >> >> >>> > --- >> >> >>> > meta/recipes-graphics/cairo/cairo.inc | 3 ++- >> >> >>> > meta/recipes-graphics/mesa/mesa.inc | 3 +++ >> >> >>> > 2 files changed, 5 insertions(+), 1 deletion(-) >> >> >>> > >> >> >>> > diff --git a/meta/recipes-graphics/cairo/cairo.inc b/meta/recipes-graphics/cairo/cairo.inc >> >> >>> > index 20e0d2c92a..7347f223ff 100644 >> >> >>> > --- a/meta/recipes-graphics/cairo/cairo.inc >> >> >>> > +++ b/meta/recipes-graphics/cairo/cairo.inc >> >> >>> > @@ -22,7 +22,8 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxext" >> >> >>> > DEPENDS = "libpng fontconfig pixman glib-2.0 zlib" >> >> >>> > >> >> >>> > PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 xcb', '', d)} \ >> >> >>> > - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)}" >> >> >>> > + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \ >> >> >>> > + ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'opengl', '', d)}" >> >> >>> > >> >> >>> > PACKAGECONFIG[x11] = "--with-x=yes -enable-xlib,--with-x=no --disable-xlib,${X11DEPENDS}" >> >> >>> > PACKAGECONFIG[xcb] = "--enable-xcb,--disable-xcb,libxcb" >> >> >>> > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc >> >> >>> > index 5afd0db4b7..dd626d9f00 100644 >> >> >>> ^ I think this came in accidentaly and it breaks builds when adding >> >> >>> packageconfig glesv2: >> >> >>> >> >> >>> | configure: error: use either --enable-gl=yes or --enable-glesv2=yes. >> >> >>> Not both at the same time. >> >> >> >> >> >> do you remove opengl from DISTRO_FEATURES when enabling glesv2 ? >> >> >> try that out. >> >> >> >> >> >>> >> >> > Yes of course I can. But this patch is wrong - we don't have gles as >> >> > distro feature - and it is not even mentioned in commit message why >> >> > this is done. >> >> > >> >> I am tempted to send a revert for the cairo part: >> >> >> >> * Cross: It changes defaults valid for long time >> >> * Native: As far as I can remember it causes trouble for cairo-native >> >> * It went through without mentioning >> > >> > opengl as a DISTRO_FEATURE should tie into packageconfigs, the >> > situation before this patch was not ideal, people got to work with it. >> > >> > as seen in the example you cited, we can't mix opengl and gles support >> > in packages. other layers have solved your kind of usecase like below >> > >> > https://github.com/WebPlatformForEmbedded/meta-wpe/blob/master/recipes-graphics/cairo/cairo_%.bbappend >> * ^The link is broken > > ah see cairo bbappend here > https://github.com/WebPlatformForEmbedded/meta-wpe/tree/master/recipes-graphics/cairo That is more or less the same I am doing in https://github.com/schnitzeltony/meta-misc/blob/master/appends-packageconfig/oe-core/cairo_%25.bbappend So meta-wpe will break from now on when used together with a distro layer enabling opengl in DISTRO_FEATURES - right? Meanwhile I've checked the native case: It builds fine. To understand why I did: | bitbake -e cairo | grep ^DISTRO_FEATURES | <...> | DISTRO_FEATURES="<...> opengl <...>' | <...> and | bitbake -e cairo-native | grep ^DISTRO_FEATURES | <...> DISTRO_FEATURES="ipv6 x11 xattr pulseaudio bluez5 gobject-introspection-data ldconfig" | <...> Some magic which I can't find right now, removes opengl from DISTRO_FEATURES => You patch does not break anything. Maybe you should send some patch to meta-wpe :) Andreas ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 2/5] gdb: Upgrade to 8.1.1 2018-08-20 18:59 [PATCH V3 0/5] Use llvmpile for mesa on x86/x86-64 Khem Raj 2018-08-20 18:59 ` [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 Khem Raj @ 2018-08-20 18:59 ` Khem Raj 2018-08-20 18:59 ` [PATCH 3/5] gdb: Alias rpl_stat to stat() on musl Khem Raj ` (2 subsequent siblings) 4 siblings, 0 replies; 17+ messages in thread From: Khem Raj @ 2018-08-20 18:59 UTC (permalink / raw) To: openembedded-core Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-devtools/gdb/{gdb-8.1.inc => gdb-8.1.1.inc} | 4 ++-- ...{gdb-cross-canadian_8.1.bb => gdb-cross-canadian_8.1.1.bb} | 0 .../gdb/{gdb-cross_8.1.bb => gdb-cross_8.1.1.bb} | 0 meta/recipes-devtools/gdb/{gdb_8.1.bb => gdb_8.1.1.bb} | 0 4 files changed, 2 insertions(+), 2 deletions(-) rename meta/recipes-devtools/gdb/{gdb-8.1.inc => gdb-8.1.1.inc} (89%) rename meta/recipes-devtools/gdb/{gdb-cross-canadian_8.1.bb => gdb-cross-canadian_8.1.1.bb} (100%) rename meta/recipes-devtools/gdb/{gdb-cross_8.1.bb => gdb-cross_8.1.1.bb} (100%) rename meta/recipes-devtools/gdb/{gdb_8.1.bb => gdb_8.1.1.bb} (100%) diff --git a/meta/recipes-devtools/gdb/gdb-8.1.inc b/meta/recipes-devtools/gdb/gdb-8.1.1.inc similarity index 89% rename from meta/recipes-devtools/gdb/gdb-8.1.inc rename to meta/recipes-devtools/gdb/gdb-8.1.1.inc index 4d9faa2d4b..ad80dd3e4d 100644 --- a/meta/recipes-devtools/gdb/gdb-8.1.inc +++ b/meta/recipes-devtools/gdb/gdb-8.1.1.inc @@ -18,6 +18,6 @@ SRC_URI = "http://ftp.gnu.org/gnu/gdb/gdb-${PV}.tar.xz \ file://package_devel_gdb_patches_120-sigprocmask-invalid-call.patch \ file://gdb-Fix-ia64-defining-TRAP_HWBKPT-before-including-g.patch \ " -SRC_URI[md5sum] = "f46487561f9a16916a8102316f7fd105" -SRC_URI[sha256sum] = "af61a0263858e69c5dce51eab26662ff3d2ad9aa68da9583e8143b5426be4b34" +SRC_URI[md5sum] = "372fa63a53adeee1bfbfd581d8da9e34" +SRC_URI[sha256sum] = "97dcc3169bd430270fc29adb65145846a58c1b55cdbb73382a4a89307bdad03c" diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian_8.1.bb b/meta/recipes-devtools/gdb/gdb-cross-canadian_8.1.1.bb similarity index 100% rename from meta/recipes-devtools/gdb/gdb-cross-canadian_8.1.bb rename to meta/recipes-devtools/gdb/gdb-cross-canadian_8.1.1.bb diff --git a/meta/recipes-devtools/gdb/gdb-cross_8.1.bb b/meta/recipes-devtools/gdb/gdb-cross_8.1.1.bb similarity index 100% rename from meta/recipes-devtools/gdb/gdb-cross_8.1.bb rename to meta/recipes-devtools/gdb/gdb-cross_8.1.1.bb diff --git a/meta/recipes-devtools/gdb/gdb_8.1.bb b/meta/recipes-devtools/gdb/gdb_8.1.1.bb similarity index 100% rename from meta/recipes-devtools/gdb/gdb_8.1.bb rename to meta/recipes-devtools/gdb/gdb_8.1.1.bb -- 2.18.0 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 3/5] gdb: Alias rpl_stat to stat() on musl 2018-08-20 18:59 [PATCH V3 0/5] Use llvmpile for mesa on x86/x86-64 Khem Raj 2018-08-20 18:59 ` [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 Khem Raj 2018-08-20 18:59 ` [PATCH 2/5] gdb: Upgrade to 8.1.1 Khem Raj @ 2018-08-20 18:59 ` Khem Raj 2019-08-12 18:12 ` Andre McCurdy 2018-08-20 18:59 ` [PATCH 4/5] dos2unix.bbclass: Move to oe-core Khem Raj 2018-08-20 18:59 ` [PATCH 5/5] llvm: Use HOST_ARCH in LLVM_TARGETS_TO_BUILD for builds Khem Raj 4 siblings, 1 reply; 17+ messages in thread From: Khem Raj @ 2018-08-20 18:59 UTC (permalink / raw) To: openembedded-core Use CPPFLAGS instead of CFLAGS since there is C++ compiler being used for somefiles Fixes gdb/gdbserver/../../../gdb-8.1.1/gdb/gdbserver/../common/common-utils.c:419: undefined reference to `rpl_stat' | collect2: error: ld returned 1 exit status | make[4]: *** [Makefile:414: libinproctrace.so] Error 1 Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-devtools/gdb/gdb_8.1.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-devtools/gdb/gdb_8.1.1.bb b/meta/recipes-devtools/gdb/gdb_8.1.1.bb index 84ab08ce93..c6eac84dd8 100644 --- a/meta/recipes-devtools/gdb/gdb_8.1.1.bb +++ b/meta/recipes-devtools/gdb/gdb_8.1.1.bb @@ -26,4 +26,4 @@ EOF chmod +x ${WORKDIR}/python fi } -CFLAGS_append_libc-musl = " -Drpl_gettimeofday=gettimeofday" +CPPFLAGS_append_libc-musl = " -Drpl_gettimeofday=gettimeofday -Drpl_stat=stat" -- 2.18.0 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 3/5] gdb: Alias rpl_stat to stat() on musl 2018-08-20 18:59 ` [PATCH 3/5] gdb: Alias rpl_stat to stat() on musl Khem Raj @ 2019-08-12 18:12 ` Andre McCurdy 2019-08-12 18:55 ` Khem Raj 0 siblings, 1 reply; 17+ messages in thread From: Andre McCurdy @ 2019-08-12 18:12 UTC (permalink / raw) To: Khem Raj; +Cc: OE Core mailing list On Mon, Aug 20, 2018 at 12:00 PM Khem Raj <raj.khem@gmail.com> wrote: > > Use CPPFLAGS instead of CFLAGS since there is C++ compiler being used for somefiles > > Fixes > gdb/gdbserver/../../../gdb-8.1.1/gdb/gdbserver/../common/common-utils.c:419: undefined reference to `rpl_stat' > | collect2: error: ld returned 1 exit status > | make[4]: *** [Makefile:414: libinproctrace.so] Error 1 > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/recipes-devtools/gdb/gdb_8.1.1.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/gdb/gdb_8.1.1.bb b/meta/recipes-devtools/gdb/gdb_8.1.1.bb > index 84ab08ce93..c6eac84dd8 100644 > --- a/meta/recipes-devtools/gdb/gdb_8.1.1.bb > +++ b/meta/recipes-devtools/gdb/gdb_8.1.1.bb > @@ -26,4 +26,4 @@ EOF > chmod +x ${WORKDIR}/python > fi > } > -CFLAGS_append_libc-musl = " -Drpl_gettimeofday=gettimeofday" > +CPPFLAGS_append_libc-musl = " -Drpl_gettimeofday=gettimeofday -Drpl_stat=stat" rpl_stat() is a wrapper for stat, so by forcefully redefining rpl_stat to stat you create a local stat() function which recurses infinitely... which causes obvious runtime problems (e.g. gdbserver crashes on startup). Simply removing these additional CPPFLAGS fixes the runtime issues for me (and doesn't trigger the original build failure so presumably something has changed since the patch was originally created...). ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 3/5] gdb: Alias rpl_stat to stat() on musl 2019-08-12 18:12 ` Andre McCurdy @ 2019-08-12 18:55 ` Khem Raj 2019-08-12 19:18 ` Andre McCurdy 0 siblings, 1 reply; 17+ messages in thread From: Khem Raj @ 2019-08-12 18:55 UTC (permalink / raw) To: Andre McCurdy; +Cc: OE Core mailing list On 8/12/19 11:12 AM, Andre McCurdy wrote: > On Mon, Aug 20, 2018 at 12:00 PM Khem Raj <raj.khem@gmail.com> wrote: >> >> Use CPPFLAGS instead of CFLAGS since there is C++ compiler being used for somefiles >> >> Fixes >> gdb/gdbserver/../../../gdb-8.1.1/gdb/gdbserver/../common/common-utils.c:419: undefined reference to `rpl_stat' >> | collect2: error: ld returned 1 exit status >> | make[4]: *** [Makefile:414: libinproctrace.so] Error 1 >> >> Signed-off-by: Khem Raj <raj.khem@gmail.com> >> --- >> meta/recipes-devtools/gdb/gdb_8.1.1.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-devtools/gdb/gdb_8.1.1.bb b/meta/recipes-devtools/gdb/gdb_8.1.1.bb >> index 84ab08ce93..c6eac84dd8 100644 >> --- a/meta/recipes-devtools/gdb/gdb_8.1.1.bb >> +++ b/meta/recipes-devtools/gdb/gdb_8.1.1.bb >> @@ -26,4 +26,4 @@ EOF >> chmod +x ${WORKDIR}/python >> fi >> } >> -CFLAGS_append_libc-musl = " -Drpl_gettimeofday=gettimeofday" >> +CPPFLAGS_append_libc-musl = " -Drpl_gettimeofday=gettimeofday -Drpl_stat=stat" > > rpl_stat() is a wrapper for stat, so by forcefully redefining rpl_stat > to stat you create a local stat() function which recurses > infinitely... which causes obvious runtime problems (e.g. gdbserver > crashes on startup). > > Simply removing these additional CPPFLAGS fixes the runtime issues for > me (and doesn't trigger the original build failure so presumably > something has changed since the patch was originally created...). > I think setting CPPFLAGS is not right way and we can not fully remove it as well because in this case gnulib does not recognize musl as gnu system and detection logic is wrong for musl. So what we should do is remove the above CPPFLAGS settings and instead pass the cached values to configure CACHED_CONFIGUREVARS += "gl_cv_func_gettimeofday_clobber=no" for stat issue it has been fixed [1] so we can just drop it. [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=3c025cfe5efc44eb4dfb03b53dca28e75096dd1e care to send a patch ? Thanks -Khem ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 3/5] gdb: Alias rpl_stat to stat() on musl 2019-08-12 18:55 ` Khem Raj @ 2019-08-12 19:18 ` Andre McCurdy 0 siblings, 0 replies; 17+ messages in thread From: Andre McCurdy @ 2019-08-12 19:18 UTC (permalink / raw) To: Khem Raj; +Cc: OE Core mailing list On Mon, Aug 12, 2019 at 11:55 AM Khem Raj <raj.khem@gmail.com> wrote: > > On 8/12/19 11:12 AM, Andre McCurdy wrote: > > On Mon, Aug 20, 2018 at 12:00 PM Khem Raj <raj.khem@gmail.com> wrote: > >> > >> Use CPPFLAGS instead of CFLAGS since there is C++ compiler being used for somefiles > >> > >> Fixes > >> gdb/gdbserver/../../../gdb-8.1.1/gdb/gdbserver/../common/common-utils.c:419: undefined reference to `rpl_stat' > >> | collect2: error: ld returned 1 exit status > >> | make[4]: *** [Makefile:414: libinproctrace.so] Error 1 > >> > >> Signed-off-by: Khem Raj <raj.khem@gmail.com> > >> --- > >> meta/recipes-devtools/gdb/gdb_8.1.1.bb | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/meta/recipes-devtools/gdb/gdb_8.1.1.bb b/meta/recipes-devtools/gdb/gdb_8.1.1.bb > >> index 84ab08ce93..c6eac84dd8 100644 > >> --- a/meta/recipes-devtools/gdb/gdb_8.1.1.bb > >> +++ b/meta/recipes-devtools/gdb/gdb_8.1.1.bb > >> @@ -26,4 +26,4 @@ EOF > >> chmod +x ${WORKDIR}/python > >> fi > >> } > >> -CFLAGS_append_libc-musl = " -Drpl_gettimeofday=gettimeofday" > >> +CPPFLAGS_append_libc-musl = " -Drpl_gettimeofday=gettimeofday -Drpl_stat=stat" > > > > rpl_stat() is a wrapper for stat, so by forcefully redefining rpl_stat > > to stat you create a local stat() function which recurses > > infinitely... which causes obvious runtime problems (e.g. gdbserver > > crashes on startup). > > > > Simply removing these additional CPPFLAGS fixes the runtime issues for > > me (and doesn't trigger the original build failure so presumably > > something has changed since the patch was originally created...). > > > > I think setting CPPFLAGS is not right way and we can not fully remove it > as well because in this case gnulib does not recognize musl as gnu > system and detection logic is wrong for musl. So what we should do is > remove the above CPPFLAGS settings and instead pass the cached values to > configure > > CACHED_CONFIGUREVARS += "gl_cv_func_gettimeofday_clobber=no" > > for stat issue it has been fixed [1] so we can just drop it. > > [1] > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=3c025cfe5efc44eb4dfb03b53dca28e75096dd1e > > care to send a patch ? Don't really have time right now. For the CACHED_CONFIGUREVARS tweaks you should have a look at the Buildroot solution - it also has similar fixes for strerror() and detection of prfpregset_t. They may be applicable for OE too. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 4/5] dos2unix.bbclass: Move to oe-core 2018-08-20 18:59 [PATCH V3 0/5] Use llvmpile for mesa on x86/x86-64 Khem Raj ` (2 preceding siblings ...) 2018-08-20 18:59 ` [PATCH 3/5] gdb: Alias rpl_stat to stat() on musl Khem Raj @ 2018-08-20 18:59 ` Khem Raj 2018-08-20 18:59 ` [PATCH 5/5] llvm: Use HOST_ARCH in LLVM_TARGETS_TO_BUILD for builds Khem Raj 4 siblings, 0 replies; 17+ messages in thread From: Khem Raj @ 2018-08-20 18:59 UTC (permalink / raw) To: openembedded-core - Import from meta-oe layer - This is useful for many packages where CR-LF needs to be adjusted, many recipes depend on it e.g. meta-multimedia libebml and so on. - Add myself as maintainer for now Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/conf/distro/include/maintainers.inc | 1 + .../dos2unix/dos2unix_7.4.0.bb | 34 +++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 meta/recipes-support/dos2unix/dos2unix_7.4.0.bb diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc index 0d1c72a85f..19bd148700 100644 --- a/meta/conf/distro/include/maintainers.inc +++ b/meta/conf/distro/include/maintainers.inc @@ -134,6 +134,7 @@ RECIPE_MAINTAINER_pn-dmidecode = "Alexander Kanavin <alex.kanavin@gmail.com>" RECIPE_MAINTAINER_pn-dnf = "Alexander Kanavin <alex.kanavin@gmail.com>" RECIPE_MAINTAINER_pn-docbook-xml-dtd4 = "Yi Zhao <yi.zhao@windriver.com>" RECIPE_MAINTAINER_pn-docbook-xsl-stylesheets = "Yi Zhao <yi.zhao@windriver.com>" +RECIPE_MAINTAINER_pn-dos2unit = "Khem Raj <raj.khem@gmail.com>" RECIPE_MAINTAINER_pn-dosfstools = "Yi Zhao <yi.zhao@windriver.com>" RECIPE_MAINTAINER_pn-dpkg = "Aníbal Limón <limon.anibal@gmail.com>" RECIPE_MAINTAINER_pn-dropbear = "Yi Zhao <yi.zhao@windriver.com>" diff --git a/meta/recipes-support/dos2unix/dos2unix_7.4.0.bb b/meta/recipes-support/dos2unix/dos2unix_7.4.0.bb new file mode 100644 index 0000000000..9964315ee7 --- /dev/null +++ b/meta/recipes-support/dos2unix/dos2unix_7.4.0.bb @@ -0,0 +1,34 @@ +SUMMARY = "Convert text file line endings between CRLF and LF" +DESCRIPTION = "The Dos2unix package includes utilities dos2unix and \ +unix2dos to convert plain text files in DOS or Mac format to Unix \ +format and vice versa." +HOMEPAGE = "http://waterlan.home.xs4all.nl/dos2unix.html" +SECTION = "support" + +LICENSE = "BSD-2-Clause" +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=1b78fca784db24f4a40e30b300787f3f" + +SRC_URI = "git://git.code.sf.net/p/dos2unix/dos2unix" + +# Release 7.4.0 +SRCREV = "1182533bde3c1fe65be2ead465e87671faa2c027" + +S = "${WORKDIR}/git/dos2unix" + +inherit gettext perlnative + +# The dos2unix NLS relies on po4a-native, while po4a recipe is +# provided by meta-perl layer, so make it optional here, you +# need have meta-perl in bblayers.conf before enabling nls in +# PACKAGECONFIG. +PACKAGECONFIG ??= "" +PACKAGECONFIG[nls] = "ENABLE_NLS=1,ENABLE_NLS=,po4a-native" + +EXTRA_OEMAKE = "${PACKAGECONFIG_CONFARGS} LDFLAGS_USER='${LDFLAGS}'" +EXTRA_OEMAKE_class-native = "ENABLE_NLS=" + +do_install () { + oe_runmake DESTDIR="${D}${base_prefix}" install +} + +BBCLASSEXTEND = "native nativesdk" -- 2.18.0 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 5/5] llvm: Use HOST_ARCH in LLVM_TARGETS_TO_BUILD for builds 2018-08-20 18:59 [PATCH V3 0/5] Use llvmpile for mesa on x86/x86-64 Khem Raj ` (3 preceding siblings ...) 2018-08-20 18:59 ` [PATCH 4/5] dos2unix.bbclass: Move to oe-core Khem Raj @ 2018-08-20 18:59 ` Khem Raj 4 siblings, 0 replies; 17+ messages in thread From: Khem Raj @ 2018-08-20 18:59 UTC (permalink / raw) To: openembedded-core LLVM_TARGETS_TO_BUILD is needed to represent HOST_ARCH for builds and target specific additions should use class-target override Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-devtools/llvm/llvm_git.bb | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/meta/recipes-devtools/llvm/llvm_git.bb b/meta/recipes-devtools/llvm/llvm_git.bb index d853d4151d..df7c1dddd3 100644 --- a/meta/recipes-devtools/llvm/llvm_git.bb +++ b/meta/recipes-devtools/llvm/llvm_git.bb @@ -44,14 +44,15 @@ def get_llvm_arch(bb, d, arch_var): else: raise bb.parse.SkipRecipe("Cannot map '%s' to a supported LLVM architecture" % a) -def get_llvm_target_arch(bb, d): - return get_llvm_arch(bb, d, 'TARGET_ARCH') +def get_llvm_host_arch(bb, d): + return get_llvm_arch(bb, d, 'HOST_ARCH') + # # Default to build all OE-Core supported target arches (user overridable). # -LLVM_TARGETS ?= "${@get_llvm_target_arch(bb, d)}" -LLVM_TARGETS_prepend_x86 = "AMDGPU;" -LLVM_TARGETS_prepend_x86-64 = "AMDGPU;" +LLVM_TARGETS ?= "${@get_llvm_host_arch(bb, d)}" +LLVM_TARGETS_prepend_class-target_x86 = "AMDGPU;" +LLVM_TARGETS_prepend_class-target_x86-64 = "AMDGPU;" ARM_INSTRUCTION_SET_armv5 = "arm" ARM_INSTRUCTION_SET_armv4t = "arm" -- 2.18.0 ^ permalink raw reply related [flat|nested] 17+ messages in thread
end of thread, other threads:[~2019-08-12 19:18 UTC | newest] Thread overview: 17+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-08-20 18:59 [PATCH V3 0/5] Use llvmpile for mesa on x86/x86-64 Khem Raj 2018-08-20 18:59 ` [PATCH 1/5] mesa: Enable gallium-llvm on x86 and x86_64 Khem Raj 2018-08-27 21:15 ` Andreas Müller 2018-08-27 22:55 ` Khem Raj 2018-08-28 6:43 ` Andreas Müller 2018-08-28 17:21 ` Andreas Müller 2018-08-28 17:36 ` Khem Raj 2018-08-28 18:28 ` Andreas Müller 2018-08-28 20:20 ` Khem Raj 2018-08-28 20:51 ` Andreas Müller 2018-08-20 18:59 ` [PATCH 2/5] gdb: Upgrade to 8.1.1 Khem Raj 2018-08-20 18:59 ` [PATCH 3/5] gdb: Alias rpl_stat to stat() on musl Khem Raj 2019-08-12 18:12 ` Andre McCurdy 2019-08-12 18:55 ` Khem Raj 2019-08-12 19:18 ` Andre McCurdy 2018-08-20 18:59 ` [PATCH 4/5] dos2unix.bbclass: Move to oe-core Khem Raj 2018-08-20 18:59 ` [PATCH 5/5] llvm: Use HOST_ARCH in LLVM_TARGETS_TO_BUILD for builds Khem Raj
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox