[PATCH 0/1] dump_cache.py: Move it from bitbake

[PATCH 0/1] dump_cache.py: Move it from bitbake

[Robert Yang]

The following changes since commit b7f3f7ecfdf26129c5df2d3ee14e73c4633ea5a3:

  yasm: remove (2018-09-11 12:09:04 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/dump
  http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/dump

Robert Yang (1):
  dump_cache.py: Move it from bitbake

 scripts/dump_cache.py | 95 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 95 insertions(+)
 create mode 100755 scripts/dump_cache.py

-- 
2.7.4

[PATCH 1/1] dump_cache.py: Move it from bitbake

[Robert Yang]

Add it to oe-core can make it's easier to use, e.g., we don't need use
/path/to/bitbake/contrib/dump_cache.py to run it, just use dump_cache.py after
the build is initialized.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 scripts/dump_cache.py | 95 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 95 insertions(+)
 create mode 100755 scripts/dump_cache.py

diff --git a/scripts/dump_cache.py b/scripts/dump_cache.py
new file mode 100755
index 0000000..3aaa780
--- /dev/null
+++ b/scripts/dump_cache.py
@@ -0,0 +1,95 @@
+#!/usr/bin/env python3
+# ex:ts=4:sw=4:sts=4:et
+# -*- tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*-
+#
+# Copyright (C) 2012, 2018 Wind River Systems, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 2 as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+#
+# Used for dumping the bb_cache.dat
+#
+import os
+import sys
+import argparse
+
+# External modules
+scripts_path = os.path.dirname(os.path.realpath(__file__))
+lib_path = scripts_path + '/lib'
+sys.path.insert(0, lib_path)
+
+import scriptpath
+# Figure out where is the bitbake/lib/bb since we need bb.siggen and bb.process
+bitbakepath = scriptpath.add_bitbake_lib_path()
+if not bitbakepath:
+    sys.stderr.write("Unable to find bitbake by searching parent directory of this script or PATH\n")
+    sys.exit(1)
+
+from bb.cache import CoreRecipeInfo
+
+import pickle
+
+class DumpCache(object):
+    def __init__(self):
+        parser = argparse.ArgumentParser(
+            description="bb_cache.dat's dumper",
+            epilog="Use %(prog)s --help to get help")
+        parser.add_argument("-r", "--recipe",
+            help="specify the recipe, default: all recipes", action="store")
+        parser.add_argument("-m", "--members",
+            help = "specify the member, use comma as separator for multiple ones, default: all members", action="store", default="")
+        parser.add_argument("-s", "--skip",
+            help = "skip skipped recipes", action="store_true")
+        parser.add_argument("cachefile",
+            help = "specify bb_cache.dat", nargs = 1, action="store", default="")
+
+        self.args = parser.parse_args()
+
+    def main(self):
+        with open(self.args.cachefile[0], "rb") as cachefile:
+            pickled = pickle.Unpickler(cachefile)
+            while True:
+                try:
+                    key = pickled.load()
+                    val = pickled.load()
+                except Exception:
+                    break
+                if isinstance(val, CoreRecipeInfo):
+                    pn = val.pn
+
+                    if self.args.recipe and self.args.recipe != pn:
+                        continue
+
+                    if self.args.skip and val.skipped:
+                        continue
+
+                    if self.args.members:
+                        out = key
+                        for member in self.args.members.split(','):
+                            out += ": %s" % val.__dict__.get(member)
+                        print("%s" % out)
+                    else:
+                        print("%s: %s" % (key, val.__dict__))
+                elif not self.args.recipe:
+                    print("%s %s" % (key, val))
+
+if __name__ == "__main__":
+    try:
+        dump = DumpCache()
+        ret = dump.main()
+    except Exception as esc:
+        ret = 1
+        import traceback
+        traceback.print_exc()
+    sys.exit(ret)
-- 
2.7.4

Re: [PATCH 1/1] dump_cache.py: Move it from bitbake

[Richard Purdie]

On Wed, 2018-09-12 at 16:27 +0800, Robert Yang wrote:
> Add it to oe-core can make it's easier to use, e.g., we don't need
> use
> /path/to/bitbake/contrib/dump_cache.py to run it, just use
> dump_cache.py after
> the build is initialized.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  scripts/dump_cache.py | 95
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100755 scripts/dump_cache.py

Since the script is heavily tied to bitbake itself, I don't think this
change makes sense. The name is also too generic just to insert into
PATH (dump which cache?).

We could move it within bitbake I guess but I have to ask the question,
how many people really need to run this and is the location therefore a
real problem? Any user needing this can like adjust their PATH or
figure out the right path to the script easily enough?

Cheers,

Richard

Re: [PATCH 1/1] dump_cache.py: Move it from bitbake

[Robert Yang]

On 09/12/2018 04:43 PM, Richard Purdie wrote:
> On Wed, 2018-09-12 at 16:27 +0800, Robert Yang wrote:
>> Add it to oe-core can make it's easier to use, e.g., we don't need
>> use
>> /path/to/bitbake/contrib/dump_cache.py to run it, just use
>> dump_cache.py after
>> the build is initialized.
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   scripts/dump_cache.py | 95
>> +++++++++++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 95 insertions(+)
>>   create mode 100755 scripts/dump_cache.py
> 
> Since the script is heavily tied to bitbake itself, I don't think this
> change makes sense. The name is also too generic just to insert into
> PATH (dump which cache?).
> 
> We could move it within bitbake I guess but I have to ask the question,
> how many people really need to run this and is the location therefore a
> real problem? Any user needing this can like adjust their PATH or
> figure out the right path to the script easily enough?

I guess seldom people really uses it since seldom people cares the internal
of the cache. I'm fine to leave it in bitbake, let's drop the patch, thanks.

// Robert

> 
> Cheers,
> 
> Richard
>