Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] go.bbclass: Add -buildmode=pie for non mips arch
@ 2018-09-29  9:44 Robert Yang
  2018-09-29  9:44 ` [PATCH 1/1] " Robert Yang
  0 siblings, 1 reply; 2+ messages in thread
From: Robert Yang @ 2018-09-29  9:44 UTC (permalink / raw)
  To: openembedded-core

The following changes since commit 4dad1568f8f84ec9de4bf7235822f77a8ee6a413:

  glibc-package.inc: correct intention for deleting /usr/lib as needed (2018-09-27 23:39:28 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/go
  http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/go

Robert Yang (1):
  go.bbclass: Add -buildmode=pie for non mips arch

 meta/classes/go.bbclass | 10 ++++++++++
 1 file changed, 10 insertions(+)

-- 
2.7.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] go.bbclass: Add -buildmode=pie for non mips arch
  2018-09-29  9:44 [PATCH 0/1] go.bbclass: Add -buildmode=pie for non mips arch Robert Yang
@ 2018-09-29  9:44 ` Robert Yang
  0 siblings, 0 replies; 2+ messages in thread
From: Robert Yang @ 2018-09-29  9:44 UTC (permalink / raw)
  To: openembedded-core

Fixed QA issue like:
WARNING: runc-docker do_package_qa: QA Issue: ELF binary '/path/to/runc-docker/usr/bin/runc' has relocations in .text [textrel]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/go.bbclass | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
index d33d83e..167d02e 100644
--- a/meta/classes/go.bbclass
+++ b/meta/classes/go.bbclass
@@ -179,3 +179,13 @@ FILES_${PN}-staticdev = "${libdir}/go/pkg"
 
 INSANE_SKIP_${PN} += "ldflags"
 INSANE_SKIP_${PN}-ptest += "ldflags"
+
+# Add -buildmode=pie to GOBUILDFLAGS to satisfy "textrel" QA checking, but mips
+# doesn't support -buildmode=pie, so skip the QA checking for mips and its
+# variants.
+python() {
+    if 'mips' in d.getVar('TARGET_ARCH'):
+        d.appendVar('INSANE_SKIP_%s' % d.getVar('PN'), " textrel")
+    else:
+        d.appendVar('GOBUILDFLAGS', ' -buildmode=pie')
+}
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-29  9:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-29  9:44 [PATCH 0/1] go.bbclass: Add -buildmode=pie for non mips arch Robert Yang
2018-09-29  9:44 ` [PATCH 1/1] " Robert Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox