[PATCH 0/1] base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

[PATCH 0/1] base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

[Robert Yang]

The following changes since commit ebc96f2f612ebc1b7aefb06935bb308fc2e40cfd:

  libtool: Fix ignoring compiler-rt libs (2019-01-26 23:11:39 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/ht
  http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/ht

Robert Yang (1):
  base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

 meta/classes/base.bbclass | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

-- 
2.7.4

[PATCH 1/1] base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

[Robert Yang]

Fixed:
$ export BB_SERVER_TIMEOUT=-1
$ bitbake quilt-native
$ rm -fr tmp
$ bitbake quilt-native
ERROR: Error running gcc  --version: /bin/sh: gcc: command not found

This is because bb.event.ParseStarted fires only once when server is running,
but bb.event.ParseStarted fires every time when build configs are changed, so
use bb.event.ParseStarted to fix the problem.

[YOCTO #13022]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/base.bbclass | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index f1a3c0e..c273a29 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -220,11 +220,18 @@ def buildcfg_neededvars(d):
         bb.fatal('The following variable(s) were not set: %s\nPlease set them directly, or choose a MACHINE or DISTRO that sets them.' % ', '.join(pesteruser))
 
 addhandler base_eventhandler
-base_eventhandler[eventmask] = "bb.event.ConfigParsed bb.event.MultiConfigParsed bb.event.BuildStarted bb.event.RecipePreFinalise bb.runqueue.sceneQueueComplete bb.event.RecipeParsed"
+base_eventhandler[eventmask] = "\
+	bb.event.ParseStarted \
+	bb.event.MultiConfigParsed \
+	bb.event.BuildStarted \
+	bb.event.RecipePreFinalise \
+	bb.runqueue.sceneQueueComplete \
+	bb.event.RecipeParsed \
+"
 python base_eventhandler() {
     import bb.runqueue
 
-    if isinstance(e, bb.event.ConfigParsed):
+    if isinstance(e, bb.event.ParseStarted):
         if not d.getVar("NATIVELSBSTRING", False):
             d.setVar("NATIVELSBSTRING", lsb_distro_identifier(d))
         d.setVar('BB_VERSION', bb.__version__)
-- 
2.7.4

Re: [PATCH 1/1] base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org <openembedded-
> core-bounces@lists.openembedded.org> On Behalf Of Robert Yang
> Sent: den 28 januari 2019 10:19
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 1/1] base.bbclass: Use bb.event.ParseStarted
> for HOSTTOOLS
> 
> Fixed:
> $ export BB_SERVER_TIMEOUT=-1
> $ bitbake quilt-native
> $ rm -fr tmp
> $ bitbake quilt-native
> ERROR: Error running gcc  --version: /bin/sh: gcc: command not found
> 
> This is because bb.event.ParseStarted fires only once when server is running,

I assume you meant bb.event.ConfigParsed above?

> but bb.event.ParseStarted fires every time when build configs are changed, so
> use bb.event.ParseStarted to fix the problem.
> 
> [YOCTO #13022]
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/classes/base.bbclass | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index f1a3c0e..c273a29 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -220,11 +220,18 @@ def buildcfg_neededvars(d):
>          bb.fatal('The following variable(s) were not set: %s\nPlease set them directly, or choose a MACHINE or DISTRO that sets them.' % ', '.join(pesteruser))
> 
>  addhandler base_eventhandler
> -base_eventhandler[eventmask] = "bb.event.ConfigParsed bb.event.MultiConfigParsed bb.event.BuildStarted bb.event.RecipePreFinalise bb.runqueue.sceneQueueComplete bb.event.RecipeParsed"
> +base_eventhandler[eventmask] = "\
> +	bb.event.ParseStarted \
> +	bb.event.MultiConfigParsed \
> +	bb.event.BuildStarted \
> +	bb.event.RecipePreFinalise \
> +	bb.runqueue.sceneQueueComplete \
> +	bb.event.RecipeParsed \
> +"
>  python base_eventhandler() {
>      import bb.runqueue
> 
> -    if isinstance(e, bb.event.ConfigParsed):
> +    if isinstance(e, bb.event.ParseStarted):
>          if not d.getVar("NATIVELSBSTRING", False):
>              d.setVar("NATIVELSBSTRING", lsb_distro_identifier(d))
>          d.setVar('BB_VERSION', bb.__version__)
> --
> 2.7.4

//Peter

Re: [PATCH 1/1] base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

[Robert Yang]

On 1/28/19 7:46 PM, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: openembedded-core-bounces@lists.openembedded.org <openembedded-
>> core-bounces@lists.openembedded.org> On Behalf Of Robert Yang
>> Sent: den 28 januari 2019 10:19
>> To: openembedded-core@lists.openembedded.org
>> Subject: [OE-core] [PATCH 1/1] base.bbclass: Use bb.event.ParseStarted
>> for HOSTTOOLS
>>
>> Fixed:
>> $ export BB_SERVER_TIMEOUT=-1
>> $ bitbake quilt-native
>> $ rm -fr tmp
>> $ bitbake quilt-native
>> ERROR: Error running gcc  --version: /bin/sh: gcc: command not found
>>
>> This is because bb.event.ParseStarted fires only once when server is running,
> 
> I assume you meant bb.event.ConfigParsed above?

Yes, thanks for pointing it out, fixed it in the repo:

git://git.openembedded.org/openembedded-core-contrib rbt/ht

// Robert


> 
>> but bb.event.ParseStarted fires every time when build configs are changed, so
>> use bb.event.ParseStarted to fix the problem.
>>
>> [YOCTO #13022]
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta/classes/base.bbclass | 11 +++++++++--
>>   1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>> index f1a3c0e..c273a29 100644
>> --- a/meta/classes/base.bbclass
>> +++ b/meta/classes/base.bbclass
>> @@ -220,11 +220,18 @@ def buildcfg_neededvars(d):
>>           bb.fatal('The following variable(s) were not set: %s\nPlease set them directly, or choose a MACHINE or DISTRO that sets them.' % ', '.join(pesteruser))
>>
>>   addhandler base_eventhandler
>> -base_eventhandler[eventmask] = "bb.event.ConfigParsed bb.event.MultiConfigParsed bb.event.BuildStarted bb.event.RecipePreFinalise bb.runqueue.sceneQueueComplete bb.event.RecipeParsed"
>> +base_eventhandler[eventmask] = "\
>> +	bb.event.ParseStarted \
>> +	bb.event.MultiConfigParsed \
>> +	bb.event.BuildStarted \
>> +	bb.event.RecipePreFinalise \
>> +	bb.runqueue.sceneQueueComplete \
>> +	bb.event.RecipeParsed \
>> +"
>>   python base_eventhandler() {
>>       import bb.runqueue
>>
>> -    if isinstance(e, bb.event.ConfigParsed):
>> +    if isinstance(e, bb.event.ParseStarted):
>>           if not d.getVar("NATIVELSBSTRING", False):
>>               d.setVar("NATIVELSBSTRING", lsb_distro_identifier(d))
>>           d.setVar('BB_VERSION', bb.__version__)
>> --
>> 2.7.4
> 
> //Peter
> 
> 

Re: [PATCH 1/1] base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

[Robert Yang]

Sorry, this patch doesn't work, it breaks fresh  build's sanity check since
the hosttools are bot ready when run sanity check.

ERROR:  OE-core's config sanity checker detected a potential misconfiguration.
     Either fix the cause of this error or at your own risk disable the checker 
(see sanity.conf).
     Following is the list of potential problems / advisories:

     Please install the following missing utilities: GNU make,C Compiler (gcc 
),C++ Compiler (g++ 
),patch,diffstat,makeinfo,git,bzip2,tar,gzip,gawk,chrpath,wget,cpio,perl,file,which


Please ignore this patch.

// Robert

On 1/28/19 5:19 PM, Robert Yang wrote:
> Fixed:
> $ export BB_SERVER_TIMEOUT=-1
> $ bitbake quilt-native
> $ rm -fr tmp
> $ bitbake quilt-native
> ERROR: Error running gcc  --version: /bin/sh: gcc: command not found
> 
> This is because bb.event.ParseStarted fires only once when server is running,
> but bb.event.ParseStarted fires every time when build configs are changed, so
> use bb.event.ParseStarted to fix the problem.
> 
> [YOCTO #13022]
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>   meta/classes/base.bbclass | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index f1a3c0e..c273a29 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -220,11 +220,18 @@ def buildcfg_neededvars(d):
>           bb.fatal('The following variable(s) were not set: %s\nPlease set them directly, or choose a MACHINE or DISTRO that sets them.' % ', '.join(pesteruser))
>   
>   addhandler base_eventhandler
> -base_eventhandler[eventmask] = "bb.event.ConfigParsed bb.event.MultiConfigParsed bb.event.BuildStarted bb.event.RecipePreFinalise bb.runqueue.sceneQueueComplete bb.event.RecipeParsed"
> +base_eventhandler[eventmask] = "\
> +	bb.event.ParseStarted \
> +	bb.event.MultiConfigParsed \
> +	bb.event.BuildStarted \
> +	bb.event.RecipePreFinalise \
> +	bb.runqueue.sceneQueueComplete \
> +	bb.event.RecipeParsed \
> +"
>   python base_eventhandler() {
>       import bb.runqueue
>   
> -    if isinstance(e, bb.event.ConfigParsed):
> +    if isinstance(e, bb.event.ParseStarted):
>           if not d.getVar("NATIVELSBSTRING", False):
>               d.setVar("NATIVELSBSTRING", lsb_distro_identifier(d))
>           d.setVar('BB_VERSION', bb.__version__)
>