Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] metadata.py: return info after fallback methods
@ 2019-03-07  8:41 Chen Qi
  2019-03-07  8:41 ` [PATCH 1/1] " Chen Qi
  0 siblings, 1 reply; 2+ messages in thread
From: Chen Qi @ 2019-03-07  8:41 UTC (permalink / raw)
  To: openembedded-core

*** BLURB HERE ***
The following changes since commit 525c5e516323ff584f65bed3320626b1d056260d:

  README.poky: Add pointers to key contributions wiki guides (2019-03-06 23:12:27 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib ChenQi/return-info
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/return-info

Chen Qi (1):
  metadata.py: return info after fallback methods

 meta/lib/oeqa/utils/metadata.py | 1 +
 1 file changed, 1 insertion(+)

-- 
1.9.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] metadata.py: return info after fallback methods
  2019-03-07  8:41 [PATCH 0/1] metadata.py: return info after fallback methods Chen Qi
@ 2019-03-07  8:41 ` Chen Qi
  0 siblings, 0 replies; 2+ messages in thread
From: Chen Qi @ 2019-03-07  8:41 UTC (permalink / raw)
  To: openembedded-core

If python3 git module is not installed, we fall back to some git
command to get info. A previous commit (b8d22ed6) accidently deleted
the return statement, causing errors like below.

  Exception: UnboundLocalError: local variable 'InvalidGitRepositoryError' referenced before assignment

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/lib/oeqa/utils/metadata.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/lib/oeqa/utils/metadata.py b/meta/lib/oeqa/utils/metadata.py
index 70a2756..e0808ae 100644
--- a/meta/lib/oeqa/utils/metadata.py
+++ b/meta/lib/oeqa/utils/metadata.py
@@ -76,6 +76,7 @@ def git_rev_info(path):
             info['commit_count'] = int(subprocess.check_output(["git", "rev-list", "--count", "HEAD"], cwd=path).decode('utf-8').strip())
         except subprocess.CalledProcessError:
             pass
+        return info
     try:
         repo = Repo(path, search_parent_directories=True)
     except (InvalidGitRepositoryError, NoSuchPathError):
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-07  8:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-07  8:41 [PATCH 0/1] metadata.py: return info after fallback methods Chen Qi
2019-03-07  8:41 ` [PATCH 1/1] " Chen Qi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox