Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PULL][PATCH 0/2] Implement debian packages GPG signing
@ 2019-04-01 13:49 Xavier Berger
  2019-04-01 13:50 ` [PATCH 1/2] gpg-sign: Add parameters to gpg signature function Xavier Berger
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Xavier Berger @ 2019-04-01 13:49 UTC (permalink / raw)
  To: openembedded-core


The following patches add signing feature for debian packages.


The following changes since commit 3bc700a12d4f21a5c7a1575da0972f9f78b4a091:

  mesa: update 19.0.0 -> 19.0.1 (2019-03-29 08:28:53 +0000)

are available in the git repository at:

  git://push.yoctoproject.org/poky-contrib xberger/deb_sign

Xavier Berger (2):
  gpg-sign: Add parameters to gpg signature function
  package_manager: sign DEB package feeds

 meta/lib/oe/gpg_sign.py        |  6 +++++-
 meta/lib/oe/package_manager.py | 19 ++++++++++++++++---
 2 files changed, 21 insertions(+), 4 deletions(-)

-- 
2.7.4



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] gpg-sign: Add parameters to gpg signature function
  2019-04-01 13:49 [PULL][PATCH 0/2] Implement debian packages GPG signing Xavier Berger
@ 2019-04-01 13:50 ` Xavier Berger
  2019-04-01 13:50 ` [PATCH 2/2] package_manager: sign DEB package feeds Xavier Berger
  2019-04-01 14:50 ` [PULL][PATCH 0/2] Implement debian packages GPG signing Alexander Kanavin
  2 siblings, 0 replies; 6+ messages in thread
From: Xavier Berger @ 2019-04-01 13:50 UTC (permalink / raw)
  To: openembedded-core

output_suffix: If defined, add output_suffix as file name extension.
use_sha256: If True, use sha256 for gpg as digest algorithm

Signed-off-by: Xavier Berger <xavier.berger@bio-logic.net>
---
 meta/lib/oe/gpg_sign.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oe/gpg_sign.py b/meta/lib/oe/gpg_sign.py
index ccd5aee..212ac3a 100644
--- a/meta/lib/oe/gpg_sign.py
+++ b/meta/lib/oe/gpg_sign.py
@@ -49,7 +49,7 @@ class LocalSigner(object):
         for i in range(0, len(files), sign_chunk):
             subprocess.check_output(shlex.split(cmd + ' '.join(files[i:i+sign_chunk])), stderr=subprocess.STDOUT)
 
-    def detach_sign(self, input_file, keyid, passphrase_file, passphrase=None, armor=True):
+    def detach_sign(self, input_file, keyid, passphrase_file, passphrase=None, armor=True, output_suffix=None, use_sha256=False):
         """Create a detached signature of a file"""
 
         if passphrase_file and passphrase:
@@ -62,6 +62,10 @@ class LocalSigner(object):
             cmd += ['--homedir', self.gpg_path]
         if armor:
             cmd += ['--armor']
+        if output_suffix:
+            cmd += ['-o', input_file + "." + output_suffix]
+        if use_sha256:
+            cmd += ['--digest-algo', "SHA256"]
 
         #gpg > 2.1 supports password pipes only through the loopback interface
         #gpg < 2.1 errors out if given unknown parameters
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] package_manager: sign DEB package feeds
  2019-04-01 13:49 [PULL][PATCH 0/2] Implement debian packages GPG signing Xavier Berger
  2019-04-01 13:50 ` [PATCH 1/2] gpg-sign: Add parameters to gpg signature function Xavier Berger
@ 2019-04-01 13:50 ` Xavier Berger
  2019-04-01 14:50 ` [PULL][PATCH 0/2] Implement debian packages GPG signing Alexander Kanavin
  2 siblings, 0 replies; 6+ messages in thread
From: Xavier Berger @ 2019-04-01 13:50 UTC (permalink / raw)
  To: openembedded-core

Implement debian package repository signature.
For each Release file created in repository subdirectory, a signature
Release.gpg is created.

Signature is performed using gpg backend when the following variables
are set in local.conf:
PACKAGE_CLASSES += "sign_package_feed"
PACKAGE_FEED_GPG_NAME = "<Id of GPG key>"
PACKAGE_FEED_GPG_PASSPHRASE_FILE="<path to password file>"

Signed-off-by: Xavier Berger <xavier.berger@bio-logic.net>
---
 meta/lib/oe/package_manager.py | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py
index 2835c1d..215d143 100644
--- a/meta/lib/oe/package_manager.py
+++ b/meta/lib/oe/package_manager.py
@@ -281,6 +281,7 @@ class DpkgIndexer(Indexer):
 
         index_cmds = []
         deb_dirs_found = False
+        index_sign_files = set()
         for arch in arch_list:
             arch_dir = os.path.join(self.deploy_dir, arch)
             if not os.path.isdir(arch_dir):
@@ -290,7 +291,10 @@ class DpkgIndexer(Indexer):
 
             cmd += "%s -fcn Packages > Packages.gz;" % gzip
 
-            with open(os.path.join(arch_dir, "Release"), "w+") as release:
+            release_file = os.path.join(arch_dir, "Release")
+            index_sign_files.add(release_file)
+
+            with open(release_file, "w+") as release:
                 release.write("Label: %s\n" % arch)
 
             cmd += "PSEUDO_UNLOAD=1 %s release . >> Release" % apt_ftparchive
@@ -304,8 +308,17 @@ class DpkgIndexer(Indexer):
             return
 
         oe.utils.multiprocess_launch(create_index, index_cmds, self.d)
-        if self.d.getVar('PACKAGE_FEED_SIGN') == '1':
-            raise NotImplementedError('Package feed signing not implementd for dpkg')
+        if self.d.getVar('PACKAGE_FEED_SIGN', True) == '1':
+            signer = get_signer(self.d, self.d.getVar('PACKAGE_FEED_GPG_BACKEND', True))
+        else:
+            signer = None
+        if signer:
+            for f in index_sign_files:
+                signer.detach_sign(f,
+                                   self.d.getVar('PACKAGE_FEED_GPG_NAME', True),
+                                   self.d.getVar('PACKAGE_FEED_GPG_PASSPHRASE_FILE', True),
+                                   output_suffix="gpg",
+                                   use_sha256=True)
 
 
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PULL][PATCH 0/2] Implement debian packages GPG signing
  2019-04-01 13:49 [PULL][PATCH 0/2] Implement debian packages GPG signing Xavier Berger
  2019-04-01 13:50 ` [PATCH 1/2] gpg-sign: Add parameters to gpg signature function Xavier Berger
  2019-04-01 13:50 ` [PATCH 2/2] package_manager: sign DEB package feeds Xavier Berger
@ 2019-04-01 14:50 ` Alexander Kanavin
  2019-04-02  7:36   ` Xavier Berger
  2 siblings, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2019-04-01 14:50 UTC (permalink / raw)
  To: Xavier Berger; +Cc: OE-core

On Mon, 1 Apr 2019 at 15:57, Xavier Berger <xavier.berger@bio-logic.net> wrote:
> Xavier Berger (2):
>   gpg-sign: Add parameters to gpg signature function
>   package_manager: sign DEB package feeds
>
>  meta/lib/oe/gpg_sign.py        |  6 +++++-
>  meta/lib/oe/package_manager.py | 19 ++++++++++++++++---

How do we make sure this does not regress? Can you add a test case
similar to one for rpm feed signing?

Alex


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PULL][PATCH 0/2] Implement debian packages GPG signing
  2019-04-01 14:50 ` [PULL][PATCH 0/2] Implement debian packages GPG signing Alexander Kanavin
@ 2019-04-02  7:36   ` Xavier Berger
  2019-04-02  8:17     ` Alexander Kanavin
  0 siblings, 1 reply; 6+ messages in thread
From: Xavier Berger @ 2019-04-02  7:36 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: OE-core

Hi Alexender, 

I'm working on test case but I've a lot of things to understand (and setup to perform).
I'm basically taking dnf as example and creating a test for apt. Please let me know if you think my strategy is not correct.

I'll let you know here when it will work.

Xavier

-----Original Message-----
From: Alexander Kanavin <alex.kanavin@gmail.com> 
Sent: lundi 1 avril 2019 16:50
To: Xavier Berger <xavier.berger@bio-logic.net>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PULL][PATCH 0/2] Implement debian packages GPG signing

On Mon, 1 Apr 2019 at 15:57, Xavier Berger <xavier.berger@bio-logic.net> wrote:
> Xavier Berger (2):
>   gpg-sign: Add parameters to gpg signature function
>   package_manager: sign DEB package feeds
>
>  meta/lib/oe/gpg_sign.py        |  6 +++++-
>  meta/lib/oe/package_manager.py | 19 ++++++++++++++++---

How do we make sure this does not regress? Can you add a test case similar to one for rpm feed signing?

Alex

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PULL][PATCH 0/2] Implement debian packages GPG signing
  2019-04-02  7:36   ` Xavier Berger
@ 2019-04-02  8:17     ` Alexander Kanavin
  0 siblings, 0 replies; 6+ messages in thread
From: Alexander Kanavin @ 2019-04-02  8:17 UTC (permalink / raw)
  To: Xavier Berger; +Cc: OE-core

Yes, that is fine. Let me know if something is not clear in that test case.

Btw, the apt version we have is badly out of date (and has a significant security issue I think) so if you can update that, that’d be awesome.

Alex

> On 2 Apr 2019, at 9.36, Xavier Berger <xavier.berger@bio-logic.net> wrote:
> 
> Hi Alexender, 
> 
> I'm working on test case but I've a lot of things to understand (and setup to perform).
> I'm basically taking dnf as example and creating a test for apt. Please let me know if you think my strategy is not correct.
> 
> I'll let you know here when it will work.
> 
> Xavier
> 
> -----Original Message-----
> From: Alexander Kanavin <alex.kanavin@gmail.com> 
> Sent: lundi 1 avril 2019 16:50
> To: Xavier Berger <xavier.berger@bio-logic.net>
> Cc: OE-core <openembedded-core@lists.openembedded.org>
> Subject: Re: [OE-core] [PULL][PATCH 0/2] Implement debian packages GPG signing
> 
>> On Mon, 1 Apr 2019 at 15:57, Xavier Berger <xavier.berger@bio-logic.net> wrote:
>> Xavier Berger (2):
>>  gpg-sign: Add parameters to gpg signature function
>>  package_manager: sign DEB package feeds
>> 
>> meta/lib/oe/gpg_sign.py        |  6 +++++-
>> meta/lib/oe/package_manager.py | 19 ++++++++++++++++---
> 
> How do we make sure this does not regress? Can you add a test case similar to one for rpm feed signing?
> 
> Alex


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-04-02  8:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-01 13:49 [PULL][PATCH 0/2] Implement debian packages GPG signing Xavier Berger
2019-04-01 13:50 ` [PATCH 1/2] gpg-sign: Add parameters to gpg signature function Xavier Berger
2019-04-01 13:50 ` [PATCH 2/2] package_manager: sign DEB package feeds Xavier Berger
2019-04-01 14:50 ` [PULL][PATCH 0/2] Implement debian packages GPG signing Alexander Kanavin
2019-04-02  7:36   ` Xavier Berger
2019-04-02  8:17     ` Alexander Kanavin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox