Re: [PATCH v2 1/1] stress-ng: Add bash to RDEPENDS_stress-ng-bash-completion

Re: [PATCH v2 1/1] stress-ng: Add bash to RDEPENDS_stress-ng-bash-completion

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

On Tue, 6 Aug 2019 at 13:06, Robert Yang <liezhi.yang@windriver.com> wrote:

> Fixed:
> $ bitbake stress-ng bash -ccleansstate && bitbake stress-ng
> ERROR: stress-ng-0.10.00-r0 do_package_qa: QA Issue:
> /usr/share/bash-completion/completions/stress-ng contained in package
> stress-ng-bash-completion requires /bin/bash, but no providers found in
> RDEPENDS_stress-ng-bash-completion? [file-rdeps]
>

 /usr/share/bash-completion/completions/stress-ng has an unnecessary
#!/bin/bash at the start. The correct way to address this is to patch it
out at the source level.

Alex

[-- Attachment #2: Type: text/html, Size: 900 bytes --]

Re: [PATCH v2 1/1] stress-ng: Add bash to RDEPENDS_stress-ng-bash-completion

[Yang, Liezhi]

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

Got it, thanks, will send a v3 tomorrow.

// Robert

Sent from mobile phone

在 2019年8月6日，19:23，Alexander Kanavin <alex.kanavin@gmail.com<mailto:alex.kanavin@gmail.com>> 写道：

On Tue, 6 Aug 2019 at 13:06, Robert Yang <liezhi.yang@windriver.com<mailto:liezhi.yang@windriver.com>> wrote:
Fixed:
$ bitbake stress-ng bash -ccleansstate && bitbake stress-ng
ERROR: stress-ng-0.10.00-r0 do_package_qa: QA Issue: /usr/share/bash-completion/completions/stress-ng contained in package stress-ng-bash-completion requires /bin/bash, but no providers found in RDEPENDS_stress-ng-bash-completion? [file-rdeps]

 /usr/share/bash-completion/completions/stress-ng has an unnecessary #!/bin/bash at the start. The correct way to address this is to patch it out at the source level.

Alex

[-- Attachment #2: Type: text/html, Size: 1501 bytes --]

[PATCH v2 0/1] stress-ng: Add bash to RDEPENDS_stress-ng-bash-completion

[Robert Yang]

* V2
  - Fix RDEPENDS as RP suggested

* V1
  - Initial version

The following changes since commit 88c6be81a5fbed098999fbef5576c5e0bb90cc21:

  opensbi: handle deploy task under sstate (2019-08-06 11:24:27 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/stress-ng
  http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/stress-ng

Robert Yang (1):
  stress-ng: Add bash to RDEPENDS_stress-ng-bash-completion

 meta/recipes-extended/stress-ng/stress-ng_0.10.00.bb | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.7.4

[PATCH v2 1/1] stress-ng: Add bash to RDEPENDS_stress-ng-bash-completion

[Robert Yang]

Fixed:
$ bitbake stress-ng bash -ccleansstate && bitbake stress-ng
ERROR: stress-ng-0.10.00-r0 do_package_qa: QA Issue: /usr/share/bash-completion/completions/stress-ng contained in package stress-ng-bash-completion requires /bin/bash, but no providers found in RDEPENDS_stress-ng-bash-completion? [file-rdeps]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-extended/stress-ng/stress-ng_0.10.00.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-extended/stress-ng/stress-ng_0.10.00.bb b/meta/recipes-extended/stress-ng/stress-ng_0.10.00.bb
index f7faf97..a417cf0 100644
--- a/meta/recipes-extended/stress-ng/stress-ng_0.10.00.bb
+++ b/meta/recipes-extended/stress-ng/stress-ng_0.10.00.bb
@@ -15,6 +15,8 @@ DEPENDS = "coreutils-native"
 
 inherit bash-completion
 
+RDEPENDS_${PN}-bash-completion += "bash"
+
 do_install() {
     oe_runmake DESTDIR=${D} install
 }
-- 
2.7.4