[PATCH v2 0/3] meta: 3 fixes for nativesdk

[PATCH v2 0/3] meta: 3 fixes for nativesdk

[Robert Yang]

* V2:
  - Fix comments from Ross.

* V1
  - Initial version

// Robert

The following changes since commit 95ad5626296380358c8a502a3e04879dab653d78:

  build-appliance-image: Update to master head revision (2019-09-19 20:32:47 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/sdk
  http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/sdk

Robert Yang (3):
  expect: Fix configure error for nativesdk
  apr: Fix configure error for nativesdk
  net-tools: Fix installed-vs-shipped for nativesdk

 meta/recipes-devtools/expect/expect_5.45.4.bb        | 6 +++---
 meta/recipes-extended/net-tools/net-tools_1.60-26.bb | 2 +-
 meta/recipes-support/apr/apr_1.7.0.bb                | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.7.4

[PATCH v2 1/3] expect: Fix configure error for nativesdk

[Robert Yang]

Fixed:
$ bitbake nativesdk-expect
checking for Tcl public headers... configure: error: tcl.h not found.  Please specify its location with --with-tclinclude

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-devtools/expect/expect_5.45.4.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-devtools/expect/expect_5.45.4.bb b/meta/recipes-devtools/expect/expect_5.45.4.bb
index 96eacd9..5f59083 100644
--- a/meta/recipes-devtools/expect/expect_5.45.4.bb
+++ b/meta/recipes-devtools/expect/expect_5.45.4.bb
@@ -44,9 +44,9 @@ do_install_append() {
 }
 
 # Apparently the public Tcl headers are only in /usr/include/tcl8.6
-# when building for the target.
-TCL_INCLUDE_PATH = ""
-TCL_INCLUDE_PATH_class-target = "--with-tclinclude=${STAGING_INCDIR}/tcl8.6"
+# when building for the target and nativesdk.
+TCL_INCLUDE_PATH = "--with-tclinclude=${STAGING_INCDIR}/tcl8.6"
+TCL_INCLUDE_PATH_class-native = ""
 
 EXTRA_OECONF += "--with-tcl=${STAGING_LIBDIR} \
                  --enable-shared \
-- 
2.7.4

[PATCH v2 2/3] apr: Fix configure error for nativesdk

[Robert Yang]

Fixed:
$ bitbake nativesdk-apr
buildconf: libtool not found.
           You need libtool version 1.4 or newer installed

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-support/apr/apr_1.7.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/apr/apr_1.7.0.bb b/meta/recipes-support/apr/apr_1.7.0.bb
index 09a65bf..a9d98be 100644
--- a/meta/recipes-support/apr/apr_1.7.0.bb
+++ b/meta/recipes-support/apr/apr_1.7.0.bb
@@ -1,7 +1,7 @@
 SUMMARY = "Apache Portable Runtime (APR) library"
 HOMEPAGE = "http://apr.apache.org/"
 SECTION = "libs"
-DEPENDS = "util-linux"
+DEPENDS = "util-linux libtool"
 
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=4dfd4cd216828c8cae5de5a12f3844c8 \
-- 
2.7.4

Re: [PATCH v2 2/3] apr: Fix configure error for nativesdk

[Khem Raj]

On Wed, Sep 25, 2019 at 7:52 PM Robert Yang <liezhi.yang@windriver.com> wrote:
>
> Fixed:
> $ bitbake nativesdk-apr
> buildconf: libtool not found.
>            You need libtool version 1.4 or newer installed
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/recipes-support/apr/apr_1.7.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/apr/apr_1.7.0.bb b/meta/recipes-support/apr/apr_1.7.0.bb
> index 09a65bf..a9d98be 100644
> --- a/meta/recipes-support/apr/apr_1.7.0.bb
> +++ b/meta/recipes-support/apr/apr_1.7.0.bb
> @@ -1,7 +1,7 @@
>  SUMMARY = "Apache Portable Runtime (APR) library"
>  HOMEPAGE = "http://apr.apache.org/"
>  SECTION = "libs"
> -DEPENDS = "util-linux"
> +DEPENDS = "util-linux libtool"

hmmm packages usually need libtoolize so please check if thats the
case or maybe patch apr to
do so., thereafter you can just DEPEND on libtool-cross

>
>  LICENSE = "Apache-2.0"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=4dfd4cd216828c8cae5de5a12f3844c8 \
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v2 2/3] apr: Fix configure error for nativesdk

[Robert Yang]

Hi Khem,

On 9/26/19 10:57 AM, Khem Raj wrote:
> On Wed, Sep 25, 2019 at 7:52 PM Robert Yang <liezhi.yang@windriver.com> wrote:
>>
>> Fixed:
>> $ bitbake nativesdk-apr
>> buildconf: libtool not found.
>>             You need libtool version 1.4 or newer installed
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta/recipes-support/apr/apr_1.7.0.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-support/apr/apr_1.7.0.bb b/meta/recipes-support/apr/apr_1.7.0.bb
>> index 09a65bf..a9d98be 100644
>> --- a/meta/recipes-support/apr/apr_1.7.0.bb
>> +++ b/meta/recipes-support/apr/apr_1.7.0.bb
>> @@ -1,7 +1,7 @@
>>   SUMMARY = "Apache Portable Runtime (APR) library"
>>   HOMEPAGE = "http://apr.apache.org/"
>>   SECTION = "libs"
>> -DEPENDS = "util-linux"
>> +DEPENDS = "util-linux libtool"
> 
> hmmm packages usually need libtoolize so please check if thats the
> case or maybe patch apr to
> do so., thereafter you can just DEPEND on libtool-cross

In do_configure:

libtool='${HOST_SYS}-libtool' ./buildconf

So it requires libtool which is x86_64-pokysdk-linux-libtool when build 
nativesdk-apr. The libtool-cross is already in default depends, and it
doesn't work when build nativesdk-apr, so I added libtool to the DEPENDS.

// Robert

> 
>>
>>   LICENSE = "Apache-2.0"
>>   LIC_FILES_CHKSUM = "file://LICENSE;md5=4dfd4cd216828c8cae5de5a12f3844c8 \
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 

Re: [PATCH v2 2/3] apr: Fix configure error for nativesdk

[Khem Raj]

On Wed, Sep 25, 2019 at 10:51 PM Robert Yang <liezhi.yang@windriver.com> wrote:
>
> Hi Khem,
>
> On 9/26/19 10:57 AM, Khem Raj wrote:
> > On Wed, Sep 25, 2019 at 7:52 PM Robert Yang <liezhi.yang@windriver.com> wrote:
> >>
> >> Fixed:
> >> $ bitbake nativesdk-apr
> >> buildconf: libtool not found.
> >>             You need libtool version 1.4 or newer installed
> >>
> >> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> >> ---
> >>   meta/recipes-support/apr/apr_1.7.0.bb | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-support/apr/apr_1.7.0.bb b/meta/recipes-support/apr/apr_1.7.0.bb
> >> index 09a65bf..a9d98be 100644
> >> --- a/meta/recipes-support/apr/apr_1.7.0.bb
> >> +++ b/meta/recipes-support/apr/apr_1.7.0.bb
> >> @@ -1,7 +1,7 @@
> >>   SUMMARY = "Apache Portable Runtime (APR) library"
> >>   HOMEPAGE = "http://apr.apache.org/"
> >>   SECTION = "libs"
> >> -DEPENDS = "util-linux"
> >> +DEPENDS = "util-linux libtool"
> >
> > hmmm packages usually need libtoolize so please check if thats the
> > case or maybe patch apr to
> > do so., thereafter you can just DEPEND on libtool-cross
>
> In do_configure:
>
> libtool='${HOST_SYS}-libtool' ./buildconf
>
> So it requires libtool which is x86_64-pokysdk-linux-libtool when build
> nativesdk-apr. The libtool-cross is already in default depends, and it
> doesn't work when build nativesdk-apr, so I added libtool to the DEPENDS.
>

perhaps something like this might be interesting
https://sources.debian.org/src/apr/1.6.5-1/debian/patches/fix_apr-config.patch/
https://sources.debian.org/src/apr/1.6.5-1/debian/patches/libtoolize_check.patch/

> // Robert
>
> >
> >>
> >>   LICENSE = "Apache-2.0"
> >>   LIC_FILES_CHKSUM = "file://LICENSE;md5=4dfd4cd216828c8cae5de5a12f3844c8 \
> >> --
> >> 2.7.4
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >

Re: [PATCH v2 2/3] apr: Fix configure error for nativesdk

[Robert Yang]

On 9/26/19 10:12 PM, Khem Raj wrote:
> On Wed, Sep 25, 2019 at 10:51 PM Robert Yang <liezhi.yang@windriver.com> wrote:
>>
>> Hi Khem,
>>
>> On 9/26/19 10:57 AM, Khem Raj wrote:
>>> On Wed, Sep 25, 2019 at 7:52 PM Robert Yang <liezhi.yang@windriver.com> wrote:
>>>>
>>>> Fixed:
>>>> $ bitbake nativesdk-apr
>>>> buildconf: libtool not found.
>>>>              You need libtool version 1.4 or newer installed
>>>>
>>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>>> ---
>>>>    meta/recipes-support/apr/apr_1.7.0.bb | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/recipes-support/apr/apr_1.7.0.bb b/meta/recipes-support/apr/apr_1.7.0.bb
>>>> index 09a65bf..a9d98be 100644
>>>> --- a/meta/recipes-support/apr/apr_1.7.0.bb
>>>> +++ b/meta/recipes-support/apr/apr_1.7.0.bb
>>>> @@ -1,7 +1,7 @@
>>>>    SUMMARY = "Apache Portable Runtime (APR) library"
>>>>    HOMEPAGE = "http://apr.apache.org/"
>>>>    SECTION = "libs"
>>>> -DEPENDS = "util-linux"
>>>> +DEPENDS = "util-linux libtool"
>>>
>>> hmmm packages usually need libtoolize so please check if thats the
>>> case or maybe patch apr to
>>> do so., thereafter you can just DEPEND on libtool-cross
>>
>> In do_configure:
>>
>> libtool='${HOST_SYS}-libtool' ./buildconf
>>
>> So it requires libtool which is x86_64-pokysdk-linux-libtool when build
>> nativesdk-apr. The libtool-cross is already in default depends, and it
>> doesn't work when build nativesdk-apr, so I added libtool to the DEPENDS.
>>
> 
> perhaps something like this might be interesting
> https://sources.debian.org/src/apr/1.6.5-1/debian/patches/fix_apr-config.patch/
> https://sources.debian.org/src/apr/1.6.5-1/debian/patches/libtoolize_check.patch/

Thanks, this patch is useful for oe-core, I will add it.

// Robrt

> 
>> // Robert
>>
>>>
>>>>
>>>>    LICENSE = "Apache-2.0"
>>>>    LIC_FILES_CHKSUM = "file://LICENSE;md5=4dfd4cd216828c8cae5de5a12f3844c8 \
>>>> --
>>>> 2.7.4
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
> 

[PATCH v2 3/3] net-tools: Fix installed-vs-shipped for nativesdk

[Robert Yang]

Fixed:
$ bitbake nativesdk-net-tools
ERROR: nativesdk-net-tools-1.60-26-r0 do_package: QA Issue: nativesdk-net-tools: Files/directories were installed but not shipped in any package:
  /usr
  /usr/share
  /usr/share/man
[snip]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-extended/net-tools/net-tools_1.60-26.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/net-tools/net-tools_1.60-26.bb b/meta/recipes-extended/net-tools/net-tools_1.60-26.bb
index b565fd0..5a376e7 100644
--- a/meta/recipes-extended/net-tools/net-tools_1.60-26.bb
+++ b/meta/recipes-extended/net-tools/net-tools_1.60-26.bb
@@ -95,7 +95,7 @@ do_compile() {
 
 do_install() {
 	# We don't need COPTS or LOPTS, but let's be consistent.
-	oe_runmake COPTS="$CFLAGS" LOPTS="$LDFLAGS" 'BASEDIR=${D}' install
+	oe_runmake COPTS="$CFLAGS" LOPTS="$LDFLAGS" BASEDIR=${D} INSTALLNLSDIR=${D}${datadir}/locale mandir=${mandir} install
 
 	if [ "${base_bindir}" != "/bin" ]; then
 		mkdir -p ${D}/${base_bindir}
-- 
2.7.4