public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Exclude OVERRIDES from vardeps for a couple funcs
@ 2020-12-10 20:28 Christopher Larson
  2020-12-10 20:28 ` [PATCH 1/2] grub-efi-cfg: exclude OVERRIDES from build_efi_cfg vardeps Christopher Larson
  2020-12-10 20:28 ` [PATCH 2/2] uboot-extlinux-config: exclude OVERRIDES from do_create_extlinux_config vardeps Christopher Larson
  0 siblings, 2 replies; 3+ messages in thread
From: Christopher Larson @ 2020-12-10 20:28 UTC (permalink / raw)
  To: openembedded-core; +Cc: Christopher Larson

These functions are primarily *appending* configuration entries to the
overrides, they only get it to ensure it's set at all, so doesn't belong
in the vardeps. Having a dependency on OVERRIDES means you cannot use a
bbclass like distrooverrides without changing the signatures of recipes
using this class.

Christopher Larson (2):
  grub-efi-cfg: exclude OVERRIDES from build_efi_cfg vardeps
  uboot-extlinux-config: exclude OVERRIDES from
    do_create_extlinux_config vardeps

 meta/classes/grub-efi-cfg.bbclass          | 1 +
 meta/classes/uboot-extlinux-config.bbclass | 1 +
 2 files changed, 2 insertions(+)

-- 
2.29.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] grub-efi-cfg: exclude OVERRIDES from build_efi_cfg vardeps
  2020-12-10 20:28 [PATCH 0/2] Exclude OVERRIDES from vardeps for a couple funcs Christopher Larson
@ 2020-12-10 20:28 ` Christopher Larson
  2020-12-10 20:28 ` [PATCH 2/2] uboot-extlinux-config: exclude OVERRIDES from do_create_extlinux_config vardeps Christopher Larson
  1 sibling, 0 replies; 3+ messages in thread
From: Christopher Larson @ 2020-12-10 20:28 UTC (permalink / raw)
  To: openembedded-core; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

This function is primarily *appending* configuration entries to the
overrides, it only gets it to ensure it's set at all, so doesn't belong
in the vardeps. Having a dependency on OVERRIDES means you cannot use a
bbclass like distrooverrides without changing the signatures of recipes
using this class.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta/classes/grub-efi-cfg.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/grub-efi-cfg.bbclass b/meta/classes/grub-efi-cfg.bbclass
index 3a2cdd698b..ea21b3de3d 100644
--- a/meta/classes/grub-efi-cfg.bbclass
+++ b/meta/classes/grub-efi-cfg.bbclass
@@ -120,3 +120,4 @@ python build_efi_cfg() {
 
     cfgfile.close()
 }
+build_efi_cfg[vardepsexclude] += "OVERRIDES"
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] uboot-extlinux-config: exclude OVERRIDES from do_create_extlinux_config vardeps
  2020-12-10 20:28 [PATCH 0/2] Exclude OVERRIDES from vardeps for a couple funcs Christopher Larson
  2020-12-10 20:28 ` [PATCH 1/2] grub-efi-cfg: exclude OVERRIDES from build_efi_cfg vardeps Christopher Larson
@ 2020-12-10 20:28 ` Christopher Larson
  1 sibling, 0 replies; 3+ messages in thread
From: Christopher Larson @ 2020-12-10 20:28 UTC (permalink / raw)
  To: openembedded-core; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

This function is primarily *appending* configuration entries to the
overrides, it only gets it to ensure it's set at all, so doesn't belong
in the vardeps. Having a dependency on OVERRIDES means you cannot use a
bbclass like distrooverrides without changing the signatures of recipes
using this class.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta/classes/uboot-extlinux-config.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/uboot-extlinux-config.bbclass b/meta/classes/uboot-extlinux-config.bbclass
index f4bf94be04..be285daa01 100644
--- a/meta/classes/uboot-extlinux-config.bbclass
+++ b/meta/classes/uboot-extlinux-config.bbclass
@@ -153,5 +153,6 @@ python do_create_extlinux_config() {
 }
 UBOOT_EXTLINUX_VARS = "CONSOLE MENU_DESCRIPTION ROOT KERNEL_IMAGE FDTDIR FDT KERNEL_ARGS INITRD"
 do_create_extlinux_config[vardeps] += "${@' '.join(['UBOOT_EXTLINUX_%s_%s' % (v, l) for v in d.getVar('UBOOT_EXTLINUX_VARS').split() for l in d.getVar('UBOOT_EXTLINUX_LABELS').split()])}"
+do_create_extlinux_config[vardepsexclude] += "OVERRIDES"
 
 addtask create_extlinux_config before do_install do_deploy after do_compile
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-10 20:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-10 20:28 [PATCH 0/2] Exclude OVERRIDES from vardeps for a couple funcs Christopher Larson
2020-12-10 20:28 ` [PATCH 1/2] grub-efi-cfg: exclude OVERRIDES from build_efi_cfg vardeps Christopher Larson
2020-12-10 20:28 ` [PATCH 2/2] uboot-extlinux-config: exclude OVERRIDES from do_create_extlinux_config vardeps Christopher Larson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox