[PATCH 0/1] base.bbclass: Fix dangling NATIVELSBSTRING

[PATCH 0/1] base.bbclass: Fix dangling NATIVELSBSTRING

[Robert Yang]

The following changes since commit 23cb39a5fa2a55681e7bc2605f435135cec9173b:

  diffstat: point the license checksum at the license (2021-01-05 13:48:07 +0000)

are available in the Git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/lsb
  http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/lsb

Robert Yang (1):
  base.bbclass: Fix dangling NATIVELSBSTRING

 meta/classes/base.bbclass | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.17.1

[PATCH 1/1] base.bbclass: Fix dangling NATIVELSBSTRING

[Robert Yang]

Fixed:
$ rm -fr tmp; bitbake quilt-native -n
Build Configuration:
[snip]
NATIVELSBSTRING      = "ubuntu-18.04"
[snip]

And when run bitbake again:
$ bitbake quilt-native -n
Build Configuration:
NATIVELSBSTRING      = "universal"

It has been changed from ubuntu-18.04 to universal on the same host and build
directory, this is because it is overridded by NATIVELSBSTRING. This patch
makes it print the correct value.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/base.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 78ae28bb0f4..aeb41efd24d 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -208,6 +208,8 @@ BUILDCFG_FUNCS[type] = "list"
 def buildcfg_vars(d):
     statusvars = oe.data.typed_value('BUILDCFG_VARS', d)
     for var in statusvars:
+        if var == 'NATIVELSBSTRING':
+            var = 'ORIGNATIVELSBSTRING'
         value = d.getVar(var)
         if value is not None:
             yield '%-20s = "%s"' % (var, value)
-- 
2.17.1

Re: [OE-core] [PATCH 1/1] base.bbclass: Fix dangling NATIVELSBSTRING

[Richard Purdie]

On Wed, 2021-01-06 at 04:04 -0800, Robert Yang wrote:
> Fixed:
> $ rm -fr tmp; bitbake quilt-native -n
> Build Configuration:
> [snip]
> NATIVELSBSTRING      = "ubuntu-18.04"
> [snip]
> 
> And when run bitbake again:
> $ bitbake quilt-native -n
> Build Configuration:
> NATIVELSBSTRING      = "universal"
> 
> It has been changed from ubuntu-18.04 to universal on the same host and build
> directory, this is because it is overridded by NATIVELSBSTRING. This patch
> makes it print the correct value.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/classes/base.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index 78ae28bb0f4..aeb41efd24d 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -208,6 +208,8 @@ BUILDCFG_FUNCS[type] = "list"
>  def buildcfg_vars(d):
>      statusvars = oe.data.typed_value('BUILDCFG_VARS', d)
>      for var in statusvars:
> +        if var == 'NATIVELSBSTRING':
> +            var = 'ORIGNATIVELSBSTRING'
>          value = d.getVar(var)
>          if value is not None:
>              yield '%-20s = "%s"' % (var, value)

I agree the display should be consistent and we perhaps need to look
again at how this code is working. I really don't like pretending one
value is another though so this isn't the correct fix.

Cheers,

Richard

[PATCH 0/1] base.bbclass: Fix dangling NATIVELSBSTRING

[Robert Yang]

The following changes since commit 0049f6757f6f956fb4cc77b3df6a672c20b53cf4:

  oeqa qemurunner.py: try to avoid reading one character at a time (2023-02-10 09:25:41 +0000)

are available in the Git repository at:

  https://git.openembedded.org/openembedded-core-contrib rbt/lsb
  http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/lsb

Robert Yang (1):
  base.bbclass: Fix dangling NATIVELSBSTRING

 meta/classes-global/base.bbclass | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-- 
2.39.0