[PATCH 0/1] buildhistory.bbclass: Warn when PRSERV_HOST is not enabled

[PATCH 0/1] buildhistory.bbclass: Warn when PRSERV_HOST is not enabled

[liezhi.yang]

From: Robert Yang <liezhi.yang@windriver.com>

The following changes since commit e556df28f47e754b53e1f46c97dde2b19fd8fad1:

  tcp-wrappers: Remove support (2025-11-10 17:56:48 +0000)

are available in the Git repository at:

  https://github.com/robertlinux/yocto rbt/warn
  https://github.com/robertlinux/yocto/tree/rbt/warn

Robert Yang (1):
  buildhistory.bbclass: Warn when PRSERV_HOST is not enabled

 meta/classes/buildhistory.bbclass | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.49.0

[PATCH 1/1] buildhistory.bbclass: Warn when PRSERV_HOST is not enabled

[liezhi.yang]

From: Robert Yang <liezhi.yang@windriver.com>

The version-going-backwards check may fail without PRServer, and it's not easy
to debug, so warn for that.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/buildhistory.bbclass | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass
index 4a380c10c6..859fded472 100644
--- a/meta/classes/buildhistory.bbclass
+++ b/meta/classes/buildhistory.bbclass
@@ -57,6 +57,11 @@ BUILDHISTORY_PRESERVE = "latest latest_srcrev sysroot"
 PATCH_GIT_USER_EMAIL ?= "buildhistory@oe"
 PATCH_GIT_USER_NAME ?= "OpenEmbedded"
 
+python() {
+    if not d.getVar('PRSERV_HOST'):
+        bb.warn('PRServer is not enabled, version-going-backwards check may fail!')
+}
+
 #
 # Write out the contents of the sysroot
 #
-- 
2.49.0

Re: [OE-core] [PATCH 1/1] buildhistory.bbclass: Warn when PRSERV_HOST is not enabled

[Richard Purdie]

On Sun, 2025-11-16 at 04:18 -0800, Robert Yang via lists.openembedded.org wrote:
> From: Robert Yang <liezhi.yang@windriver.com>
> 
> The version-going-backwards check may fail without PRServer, and it's not easy
> to debug, so warn for that.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/classes/buildhistory.bbclass | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass
> index 4a380c10c6..859fded472 100644
> --- a/meta/classes/buildhistory.bbclass
> +++ b/meta/classes/buildhistory.bbclass
> @@ -57,6 +57,11 @@ BUILDHISTORY_PRESERVE = "latest latest_srcrev sysroot"
>  PATCH_GIT_USER_EMAIL ?= "buildhistory@oe"
>  PATCH_GIT_USER_NAME ?= "OpenEmbedded"
>  
> +python() {
> +    if not d.getVar('PRSERV_HOST'):
> +        bb.warn('PRServer is not enabled, version-going-backwards check may fail!')
> +}
> +


Shouldn't this be conditional on that test being enabled?

Cheers,

Richard

Re: [OE-core] [PATCH 1/1] buildhistory.bbclass: Warn when PRSERV_HOST is not enabled

[Robert Yang]

On 11/17/25 12:27 AM, Richard Purdie wrote:
> On Sun, 2025-11-16 at 04:18 -0800, Robert Yang via lists.openembedded.org wrote:
>> From: Robert Yang <liezhi.yang@windriver.com>
>>
>> The version-going-backwards check may fail without PRServer, and it's not easy
>> to debug, so warn for that.
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta/classes/buildhistory.bbclass | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass
>> index 4a380c10c6..859fded472 100644
>> --- a/meta/classes/buildhistory.bbclass
>> +++ b/meta/classes/buildhistory.bbclass
>> @@ -57,6 +57,11 @@ BUILDHISTORY_PRESERVE = "latest latest_srcrev sysroot"
>>   PATCH_GIT_USER_EMAIL ?= "buildhistory@oe"
>>   PATCH_GIT_USER_NAME ?= "OpenEmbedded"
>>   
>> +python() {
>> +    if not d.getVar('PRSERV_HOST'):
>> +        bb.warn('PRServer is not enabled, version-going-backwards check may fail!')
>> +}
>> +
> 
> 
> Shouldn't this be conditional on that test being enabled?

Yes, you're right, I will send a V2 for it.

// Robert

> 
> Cheers,
> 
> Richard