Re: [PATCH 1/2] xenomai: Add xenomai recipe

[Marek Vasut <marex@denx.de>]

On 01/07/2018 08:27 PM, Alexander Kanavin wrote:
> On 01/07/2018 07:55 PM, Marek Vasut wrote:
>>>> Add recipe for the xenomai. This recipe is used twice, once to build
>>>> the xenomai userspace components and again to patch the kernel with
>>>> the cobalt core. Therefore, the xenomai sources are installed into
>>>> work-shared rather then work to make them accessible to the kernel
>>>> recipe, which triggers the patching.
>>>
>>> What is xenomai? What is a 'cobalt core'? What do they do and who would
>>> want to use them? Please do explain that in the commit message.
>>
>> I guess the link in the xenomai recipe explains it, details are here:
>> http://xenomai.org/installing-xenomai-3-x/
> 
> I need to clarify: all of these questions need to be answered in the
> context of oe-core. Essentially, you need to explain why the recipe
> should be in oe-core and not in its own layer.

Same rationale as for having linux-*-rt with preempt-rt patch.

>>>> +SUMMARY = "Xenomai 3 userspace libraries"
>>>> +DESCRIPTION = "Xenomai 3 userspace libraries"
>>>
>>> ... and here - description cannot be the same as the summary.
>>
>> So do I remove one of them or what's the difference really ?
> 
> Same as the difference between commit summary and commit message.
> Description usually spans several lines, and provides fully formed
> sentences that explain what the software provided by the recipe does.
> 
> Also, an update to maintainers.inc would be appreciated, when adding new
> recipes.

Fine

-- 
Best regards,
Marek Vasut