Re: [PATCH] shadow: 'useradd' copies root's extended attributes

[wenzong fan <wenzong.fan@windriver.com>]

On 01/04/2018 06:41 PM, Patrick Ohly wrote:
> On Thu, 2018-01-04 at 11:18 +0100, José Bollo wrote:
>>> Do you agree to move the patch to Smack specific layer? Such as
>>> meta-security?
>>
>> I agree.
> 
> Layers like meta-security should not modify recipes from other layers,
> at least not by default. That would violate the "Yocto Compatible 2.0"
> rules.
> 
> Besides, it would be harder to maintain in a separate layer - for the
> maintainer of that layer.
> 
> I still think this patch belong into OE-core, even though it is then
> more work for the OE-core maintainer.
> 

If so, I think we should wrapper the logic with:

+#if defined(WITH_ATTR) && !defined(WITH_SELINUX)
+      attr_copy_file (def_template, user_home, NULL, NULL);
+#endif

Or just add a new condition like WITH_SMACK or something.

Thanks
Wenzong