From: Quentin Schulz <quentin.schulz@cherry.de>
To: mike.looijmans@topic.nl,
Richard Purdie <richard.purdie@linuxfoundation.org>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] meta: uboot-config: Fix broken menuconfig for "fitImage" kernel
Date: Tue, 28 May 2024 12:01:33 +0200 [thread overview]
Message-ID: <d943f300-e170-4829-9984-48a3bc6a22e0@cherry.de> (raw)
In-Reply-To: <f3d14378-3a29-45f3-bea4-9a8ad0396a9f@topic.nl>
Hi Mike,
On 5/28/24 7:20 AM, mike.looijmans@topic.nl wrote:
> [You don't often get email from mike.looijmans@topic.nl. Learn why this
> is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On 24-05-2024 12:22, Richard Purdie wrote:
>> On Thu, 2024-05-23 at 15:43 +0200, Quentin Schulz wrote:
>>> I was about to comment on the v2 that this should rather be a class :)
>>> Do we have some information on how/why this is the direction the project
>>> should move towards? What are the pitfalls we're trying to avoid, or
>>> benefits we want to gain? Or is this just some better/best practice we
>>> want to go for?
>> There was a post from me a while back complaining about repeatedly
>> splitting class files into smaller less manageable ones so that people
>> could access some variables without the task/function side effects.
>>
>> I have a belief that more configuration files would help this kind of
>> problem and make classes more specific/focused and usable.
>>
> Okay, so what is now the way forward? v1 or v2?
>
Go for what Richard asked, he's the maintainer after all :) I was merely
trying to understand the position of the project, not suggesting we do
something else.
I think you've already sent a v2, so just wait for reviews or for it to
be merged. If it isn't merged in the next few weeks, then send a
reminder as an answer to your v2 asking for feedback.
Cheers,
Quentin
prev parent reply other threads:[~2024-05-28 10:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.cc544a93-e646-4932-8496-82717a21cde8@emailsignatures365.codetwo.com>
2024-05-21 13:57 ` [PATCH] meta: uboot-config: Fix broken menuconfig for "fitImage" kernel Mike Looijmans
2024-05-21 14:51 ` [OE-core] " Richard Purdie
2024-05-22 5:28 ` mike.looijmans
2024-05-22 5:39 ` Richard Purdie
2024-05-22 6:43 ` mike.looijmans
2024-05-23 13:43 ` Quentin Schulz
2024-05-24 10:03 ` mike.looijmans
2024-05-24 10:22 ` Richard Purdie
2024-05-28 5:20 ` mike.looijmans
2024-05-28 10:01 ` Quentin Schulz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d943f300-e170-4829-9984-48a3bc6a22e0@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=mike.looijmans@topic.nl \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox