[PATCH 1/2] core-image-sato-sdk-ptest: Increase qemu memory to 1GB

[PATCH 1/2] core-image-sato-sdk-ptest: Increase qemu memory to 1GB

[Richard Purdie]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-sato/images/core-image-sato-sdk-ptest.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb b/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb
index 531571ee877..7e3152b4a11 100644
--- a/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb
+++ b/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb
@@ -9,3 +9,6 @@ IMAGE_FEATURES += "ptest-pkgs"
 # box) and explicitly add just 500MB.
 IMAGE_OVERHEAD_FACTOR = "1.0"
 IMAGE_ROOTFS_EXTRA_SPACE = "524288"
+
+# ptests need more memory than standard to avoid the OOM killer
+QB_MEM = "-m 1024"
-- 
2.19.1

[PATCH 2/2] oeqa/runtime/ptest: Ensure OOM errors are logged

[Richard Purdie]

Currently processed being killed by the OOM killer may not be spotted by
ptest-runner. After we complete the tests, check the logs and report if there
were any. This ensures the user is aware of OOM conditions affecting the
ptest results.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/lib/oeqa/runtime/cases/ptest.py | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/runtime/cases/ptest.py b/meta/lib/oeqa/runtime/cases/ptest.py
index 6ae951356d8..2a28ca59a8e 100644
--- a/meta/lib/oeqa/runtime/cases/ptest.py
+++ b/meta/lib/oeqa/runtime/cases/ptest.py
@@ -70,5 +70,13 @@ class PtestRunnerTest(OERuntimeTestCase):
             if failed_testcases:
                 failed_tests[section] = failed_testcases
 
+        failmsg = ""
+        status, output = self.target.run('dmesg | grep "Killed process"', 0)
+        if output:
+            failmsg = "ERROR: Processes were killed by the OOM Killer:\n%s\n" % output
+
         if failed_tests:
-            self.fail("Failed ptests:\n%s" % pprint.pformat(failed_tests))
+            failmsg = failmsg + "Failed ptests:\n%s" % pprint.pformat(failed_tests)
+
+        if failmsg:
+            self.fail(failmsg)
-- 
2.19.1

Re: [PATCH 1/2] core-image-sato-sdk-ptest: Increase qemu memory to 1GB

[akuster808]

On 1/31/19 3:05 PM, Richard Purdie wrote:
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-sato/images/core-image-sato-sdk-ptest.bb | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb b/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb
> index 531571ee877..7e3152b4a11 100644
> --- a/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb
> +++ b/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb
> @@ -9,3 +9,6 @@ IMAGE_FEATURES += "ptest-pkgs"
>  # box) and explicitly add just 500MB.
>  IMAGE_OVERHEAD_FACTOR = "1.0"
>  IMAGE_ROOTFS_EXTRA_SPACE = "524288"
> +
> +# ptests need more memory than standard to avoid the OOM killer
> +QB_MEM = "-m 1024"

Did we have an issue with mips not working with anything larger than
256? or am I miss remembering?

- armin

Re: [PATCH 1/2] core-image-sato-sdk-ptest: Increase qemu memory to 1GB

[Richard Purdie]

On Fri, 2019-02-01 at 08:17 -0800, akuster808 wrote:
> 
> On 1/31/19 3:05 PM, Richard Purdie wrote:
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >  meta/recipes-sato/images/core-image-sato-sdk-ptest.bb | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb
> > b/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb
> > index 531571ee877..7e3152b4a11 100644
> > --- a/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb
> > +++ b/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb
> > @@ -9,3 +9,6 @@ IMAGE_FEATURES += "ptest-pkgs"
> >  # box) and explicitly add just 500MB.
> >  IMAGE_OVERHEAD_FACTOR = "1.0"
> >  IMAGE_ROOTFS_EXTRA_SPACE = "524288"
> > +
> > +# ptests need more memory than standard to avoid the OOM killer
> > +QB_MEM = "-m 1024"
> 
> Did we have an issue with mips not working with anything larger than
> 256? or am I miss remembering?

I think the runqemu code knows about that and limits anything that is
too large to work so this should be safe...

Cheers,

Richard