From: Paul Barker <paul@pbarker.dev>
To: Qi.Chen@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] fixup! runqemu: restore support to run inside SDK
Date: Thu, 19 Mar 2026 11:38:37 +0000 [thread overview]
Message-ID: <e1af42a047ada9dd736c4382b0a7b23fe15e14ac.camel@pbarker.dev> (raw)
In-Reply-To: <20260319043625.3641522-1-Qi.Chen@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
On Wed, 2026-03-18 at 21:36 -0700, Chen Qi via lists.openembedded.org
wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> In previous patch[1], the os.path.exists was accidently called twice.
> This is incorrect.
>
> [1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> scripts/runqemu | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 5587d47865..d84c6fdc1e 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -1005,7 +1005,7 @@ to your build configuration.
> # If the STAGING_BINDIR_NATIVE directories from the config file don't exist
> # and we're in a sourced OE build directory try to extract the paths
> # from `bitbake -e`
> - havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE')))
> + havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE'))
>
> if not havenative:
> if not self.bitbake_e:
Hi,
The commit title contains "fixup!", please could you re-send with a
proper title for this patch?
Best regards,
--
Paul Barker
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
next prev parent reply other threads:[~2026-03-19 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 4:36 [OE-core][PATCH] fixup! runqemu: restore support to run inside SDK Qi.Chen
2026-03-19 11:38 ` Paul Barker [this message]
2026-03-20 7:10 ` ChenQi
2026-03-20 7:15 ` [OE-core][PATCH V2] runqemu: fix the checking of STAGING_BINDIR_NATIVE Qi.Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1af42a047ada9dd736c4382b0a7b23fe15e14ac.camel@pbarker.dev \
--to=paul@pbarker.dev \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox