public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: ChenQi <Qi.Chen@windriver.com>
To: Paul Barker <paul@pbarker.dev>, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] fixup! runqemu: restore support to run inside SDK
Date: Fri, 20 Mar 2026 15:10:31 +0800	[thread overview]
Message-ID: <e281940d-e275-4257-80c8-f534d688cbe6@windriver.com> (raw)
In-Reply-To: <e1af42a047ada9dd736c4382b0a7b23fe15e14ac.camel@pbarker.dev>

On 3/19/26 19:38, Paul Barker wrote:
> On Wed, 2026-03-18 at 21:36 -0700, Chen Qi via lists.openembedded.org
> wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> In previous patch[1], the os.path.exists was accidently called twice.
>> This is incorrect.
>>
>> [1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>   scripts/runqemu | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/runqemu b/scripts/runqemu
>> index 5587d47865..d84c6fdc1e 100755
>> --- a/scripts/runqemu
>> +++ b/scripts/runqemu
>> @@ -1005,7 +1005,7 @@ to your build configuration.
>>           # If the STAGING_BINDIR_NATIVE directories from the config file don't exist
>>           # and we're in a sourced OE build directory try to extract the paths
>>           # from `bitbake -e`
>> -        havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE')))
>> +        havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE'))
>>   
>>           if not havenative:
>>               if not self.bitbake_e:
> Hi,
>
> The commit title contains "fixup!", please could you re-send with a
> proper title for this patch?
>
> Best regards,
>
Got it. I'll send out V2 with another title.

Regards,
Qi



  reply	other threads:[~2026-03-20  7:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  4:36 [OE-core][PATCH] fixup! runqemu: restore support to run inside SDK Qi.Chen
2026-03-19 11:38 ` Paul Barker
2026-03-20  7:10   ` ChenQi [this message]
2026-03-20  7:15 ` [OE-core][PATCH V2] runqemu: fix the checking of STAGING_BINDIR_NATIVE Qi.Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e281940d-e275-4257-80c8-f534d688cbe6@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul@pbarker.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox