[PATCH] sdkext: use simpler kernel module for devtool test

[PATCH] sdkext: use simpler kernel module for devtool test

[Mark Asselstine]

The current devtool test for the building of an out-of-tree kernel
module uses something which requires several "high order" kconfigs to
be set. This results in the test failing, not for expected reasons,
but rather because it depends on specific kernel configuration.

You will get error messages such as

  ERROR: "video_ioctl2"
  [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-driver/v4l2loopback.ko]
  undefined!
  ERROR: "video_unregister_device"
  [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-driver/v4l2loopback.ko]
  undefined!

Using a simpler hello-world kernel module example will only require
that CONFIG_MODULE is enabled, thus avoiding a false positive.

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
---

Richard, it is unclear if I need to match this change in
meta/lib/oeqa/manual/crops.json. Please let me know and I
send a V2 which does this. I am not fond of pointing at
my own github but it was the best option to ensure it will
exist and not be messed with.

 meta/lib/oeqa/sdkext/cases/devtool.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/lib/oeqa/sdkext/cases/devtool.py b/meta/lib/oeqa/sdkext/cases/devtool.py
index 5a02add764..fad98fbb36 100644
--- a/meta/lib/oeqa/sdkext/cases/devtool.py
+++ b/meta/lib/oeqa/sdkext/cases/devtool.py
@@ -73,8 +73,8 @@ class DevtoolTest(OESDKExtTestCase):
             self._run('devtool reset %s' % recipe)
 
     def test_devtool_kernelmodule(self):
-        docfile = 'https://github.com/umlaeute/v4l2loopback.git'
-        recipe = 'v4l2loopback-driver'
+        docfile = 'https://github.com/masselstine/kernel-module-hello-world.git'
+        recipe = 'kernel-module-hello-world'
         self._run('devtool add %s %s' % (recipe, docfile) )
         try:
             self._run('devtool build %s' % recipe)
-- 
2.21.0

Re: [PATCH] sdkext: use simpler kernel module for devtool test

[Richard Purdie]

On Tue, 2019-08-20 at 13:52 -0400, Mark Asselstine wrote:
> The current devtool test for the building of an out-of-tree kernel
> module uses something which requires several "high order" kconfigs to
> be set. This results in the test failing, not for expected reasons,
> but rather because it depends on specific kernel configuration.
> 
> You will get error messages such as
> 
>   ERROR: "video_ioctl2"
>   [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-
> driver/v4l2loopback.ko]
>   undefined!
>   ERROR: "video_unregister_device"
>   [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-
> driver/v4l2loopback.ko]
>   undefined!
> 
> Using a simpler hello-world kernel module example will only require
> that CONFIG_MODULE is enabled, thus avoiding a false positive.
> 
> Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> ---
> 
> Richard, it is unclear if I need to match this change in
> meta/lib/oeqa/manual/crops.json.

Those are manual tests for crops. They probably do also need this
change as it would make them more reliable if/as anyone every automates
them, or runs them manually.

>  Please let me know and I
> send a V2 which does this. I am not fond of pointing at
> my own github but it was the best option to ensure it will
> exist and not be messed with.

The best option may be to put that repo onto git.yoctoproject.org?

Cheers,

Richard

Re: [PATCH] sdkext: use simpler kernel module for devtool test

[Mark Asselstine]

On Wednesday, August 21, 2019 4:57:40 P.M. EDT Richard Purdie wrote:
> On Tue, 2019-08-20 at 13:52 -0400, Mark Asselstine wrote:
> > The current devtool test for the building of an out-of-tree kernel
> > module uses something which requires several "high order" kconfigs to
> > be set. This results in the test failing, not for expected reasons,
> > but rather because it depends on specific kernel configuration.
> > 
> > You will get error messages such as
> > 
> >   ERROR: "video_ioctl2"
> >   [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-
> > 
> > driver/v4l2loopback.ko]
> > 
> >   undefined!
> >   ERROR: "video_unregister_device"
> >   [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-
> > 
> > driver/v4l2loopback.ko]
> > 
> >   undefined!
> > 
> > Using a simpler hello-world kernel module example will only require
> > that CONFIG_MODULE is enabled, thus avoiding a false positive.
> > 
> > Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> > ---
> > 
> > Richard, it is unclear if I need to match this change in
> > meta/lib/oeqa/manual/crops.json.
> 
> Those are manual tests for crops. They probably do also need this
> change as it would make them more reliable if/as anyone every automates
> them, or runs them manually.

I will affect the change there then too in the V2.

> 
> >  Please let me know and I
> > 
> > send a V2 which does this. I am not fond of pointing at
> > my own github but it was the best option to ensure it will
> > exist and not be messed with.
> 
> The best option may be to put that repo onto git.yoctoproject.org?

Not sure I get a vote but as far as the content goes I have no issue with it 
being elsewhere, like git.yoctoproject.org.

Mark

> 
> Cheers,
> 
> Richard