From: Stefano Babic <sbabic@denx.de>
To: Bruce Ashfield <bruce.ashfield@gmail.com>,
Stefano Babic <sbabic@denx.de>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel-yocto: run make config for KBUILD_DEFCONFIG
Date: Wed, 26 Apr 2017 16:29:33 +0200 [thread overview]
Message-ID: <e9988f62-e3f8-e5c5-e8d2-709dcf04075d@denx.de> (raw)
In-Reply-To: <CADkTA4O20RFW1Ju-V4=cpngXgGaTEZ2z1EUC6SiVRfb2fG7pYw@mail.gmail.com>
On 26/04/2017 15:56, Bruce Ashfield wrote:
>
>
> On Wed, Apr 26, 2017 at 9:19 AM, Stefano Babic <sbabic@denx.de
> <mailto:sbabic@denx.de>> wrote:
>
> In case the defconfig was created with "make savedefconfig", it is not
> enough to copy it to defconfig as it is done now. In fact, running make
> ${KBUILD_DEFCONFIG}, as usually when building the kernel outside poky,
> does much more and the resulting .config file is different as the
> starting one.
> The file generated by "make savedefconfig" contains in most cases a
> subset of all options that are required for the kernel, and other
> options are inserted automatically when make is called.
>
> Signed-off-by: Stefano Babic <sbabic@denx.de <mailto:sbabic@denx.de>>
> ---
> meta/classes/kernel-yocto.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-yocto.bbclass
> b/meta/classes/kernel-yocto.bbclass
> index 0330270..27ff8b7 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -109,7 +109,8 @@ do_kernel_metadata() {
> bbwarn "defconfig detected
> in WORKDIR. ${KBUILD_DEFCONFIG} skipped"
> fi
> else
> - cp -f
> ${S}/arch/${ARCH}/configs/${KBUILD_DEFCONFIG} ${WORKDIR}/defconfig
> + oe_runmake -C ${S} O=${B}
> ${KBUILD_DEFCONFIG}
>
>
>
> This would need to be a different mode in the configuration task, not here.
> This routine only gathers inputs, and doesn't process them.
>
Understood.
> I have an open bug for this, and a WIP patch that will go out early in the
> 2.4 release cycle.
>
Got it, thanks for info !
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
prev parent reply other threads:[~2017-04-26 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 13:19 [PATCH] kernel-yocto: run make config for KBUILD_DEFCONFIG Stefano Babic
2017-04-26 13:56 ` Bruce Ashfield
2017-04-26 14:29 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9988f62-e3f8-e5c5-e8d2-709dcf04075d@denx.de \
--to=sbabic@denx.de \
--cc=bruce.ashfield@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox