Openembedded Core Discussions
 help / color / mirror / Atom feed
From: richard.purdie@linuxfoundation.org
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: kernel@pengutronix.de, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] mesa: make gallium swrast target optional
Date: Fri, 14 Jun 2019 13:11:04 +0100	[thread overview]
Message-ID: <ee3249ee4f978ee2ee7c74b0af81fe971ca66300.camel@linuxfoundation.org> (raw)
In-Reply-To: <20190614120448.2wg2523qu67la7mh@pengutronix.de>

On Fri, 2019-06-14 at 14:04 +0200, Marco Felsch wrote:
> On 19-06-14 11:55, Richard Purdie wrote:
> > On Thu, 2019-06-13 at 19:54 +0200, Marco Felsch wrote:
> > > Most of the time we are compiling for embedded targets which have
> > > dedicated hardware combinations. Enabling swrast by default isn't
> > > a
> > > good
> > > solution for such devices because if the hardware render node has
> > > an
> > > issue or doesn't support a special format/request Mesa will
> > > fallback
> > > to
> > > the software renderer. This will make it harder to debug
> > > performance
> > > issues.
> > > 
> > > A better way is to let the user decide if a software renderer is
> > > needed e.g. if the system has no hardware renderer or to have
> > > such a
> > > fallback device. This way the user knows that the software
> > > renderer
> > > is
> > > enabled.
> > > 
> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > ---
> > > v3
> > > - rebased on current master-next branch
> > 
> > I think this breaks the autobuilder:
> > 
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/57/builds/694
> 
> thanks for covering that. Why didn't I get a email?

The patchtest emails come from quick tests. This is a test of full
builds on the autobuilder with batched together patches. The system has
no real knowledge of which patch causes which failure so its a manual
process. We don't have the infrastructure to run all patches through
the full autobuilder tests individually.

>  Anyway thats
> interessting. IMHO it isn't a good solution to rely on that fact that
> the package have some 'random' default enabled drivers. Should we fix
> the qemu configs or should I add:
> 
> PACKAGECONFIG_append_qemuall = " swrast"

The assumption is that swrast makes a good fallback and would be
available in most cases.

I suspect qemuall might not fix beaglebone-yocto or some of the
hardware BSPs.

Its also assumed these packages are shared amongst multiple machines
which may need different drivers.

I suspect this means the defaults should be on but I am happy to have
more PACKAGECONFIG options to control things for people who want to
customise/micro-optimise.

Cheers,

Richard





  reply	other threads:[~2019-06-14 12:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 17:54 [PATCH 1/2] mesa: make gallium swrast target optional Marco Felsch
2019-06-13 17:54 ` [PATCH 2/2] mesa: make gallium virgl " Marco Felsch
2019-06-13 18:17 ` [PATCH 1/2] mesa: make gallium swrast " Martin Jansa
2019-06-13 18:38   ` Marco Felsch
2019-06-13 19:07     ` Martin Jansa
2019-06-14 10:55 ` Richard Purdie
2019-06-14 12:04   ` Marco Felsch
2019-06-14 12:11     ` richard.purdie [this message]
2019-06-14 12:34       ` Marco Felsch
2019-06-14 12:45         ` Alexander Kanavin
2019-06-14 13:16           ` Burton, Ross
2019-06-14 13:31             ` Alexander Kanavin
2019-06-14 12:50         ` richard.purdie
2019-06-14 13:05           ` Alexander Kanavin
2019-06-14 13:26             ` richard.purdie
2019-06-14 13:33               ` Alexander Kanavin
2019-06-14 13:36                 ` Burton, Ross
2019-06-14 13:37                   ` Alexander Kanavin
2019-06-17  9:35                     ` Marco Felsch
2019-06-17 11:21                       ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee3249ee4f978ee2ee7c74b0af81fe971ca66300.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=m.felsch@pengutronix.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox