From: richard.purdie@linuxfoundation.org
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: kernel@pengutronix.de, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] mesa: make gallium swrast target optional
Date: Fri, 14 Jun 2019 13:50:21 +0100 [thread overview]
Message-ID: <f2348016a0867fd986bbe4965dcb88a5b652055f.camel@linuxfoundation.org> (raw)
In-Reply-To: <20190614123451.c5idgiizmqnlhob4@pengutronix.de>
On Fri, 2019-06-14 at 14:34 +0200, Marco Felsch wrote:
> On 19-06-14 13:11, richard.purdie@linuxfoundation.org wrote:
> > On Fri, 2019-06-14 at 14:04 +0200, Marco Felsch wrote:
> > > Anyway thats
> > > interessting. IMHO it isn't a good solution to rely on that fact
> > > that
> > > the package have some 'random' default enabled drivers. Should we
> > > fix
> > > the qemu configs or should I add:
> > >
> > > PACKAGECONFIG_append_qemuall = " swrast"
> >
> > The assumption is that swrast makes a good fallback and would be
> > available in most cases.
>
> No I don't think that it is a good fallback, following my patch
> description. If you are on a embedded device you want the hw-renderer
> and not the sw one. A good example: After I updated my kernel, my
> hw-renderer wasn't available anymore and my application didn't start.
> Thats a very good indication that something went bad. With the swrast
> enabled I wouldn't see that immediately.
Alternatively, if swrast is available the system is more usable and you
can then have a more usable system to track down the problem and fix
it?
My point is you can argue that both ways.
I did read your commit message.
> > I suspect qemuall might not fix beaglebone-yocto or some of the
> > hardware BSPs.
>
> As I discribed in the patch description if you want that fallback you
> have to enable it. IMHO this is the better way instead of to be a
> 'smart' package.
As things stand this patch will likely break a significant number of
BSPs. This isn't acceptable.
> > Its also assumed these packages are shared amongst multiple
> > machines
> > which may need different drivers.
> >
> > I suspect this means the defaults should be on but I am happy to
> > have
> > more PACKAGECONFIG options to control things for people who want to
> > customise/micro-optimise.
>
> Optimising wasn't my main motivation. Avoiding 'random' performace
> issues after a upgrade (kernel, mesa) was my main motivation. Do you
> get me?
I understand why you're doing it however I don't like the implications
of the change which mean breakage for a significant number of BSPs, and
the fact it breaks the way distros would use this recipe from a
packaging perspective as its not marked as machine specific, nor should
it be.
Cheers,
Richard
next prev parent reply other threads:[~2019-06-14 12:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 17:54 [PATCH 1/2] mesa: make gallium swrast target optional Marco Felsch
2019-06-13 17:54 ` [PATCH 2/2] mesa: make gallium virgl " Marco Felsch
2019-06-13 18:17 ` [PATCH 1/2] mesa: make gallium swrast " Martin Jansa
2019-06-13 18:38 ` Marco Felsch
2019-06-13 19:07 ` Martin Jansa
2019-06-14 10:55 ` Richard Purdie
2019-06-14 12:04 ` Marco Felsch
2019-06-14 12:11 ` richard.purdie
2019-06-14 12:34 ` Marco Felsch
2019-06-14 12:45 ` Alexander Kanavin
2019-06-14 13:16 ` Burton, Ross
2019-06-14 13:31 ` Alexander Kanavin
2019-06-14 12:50 ` richard.purdie [this message]
2019-06-14 13:05 ` Alexander Kanavin
2019-06-14 13:26 ` richard.purdie
2019-06-14 13:33 ` Alexander Kanavin
2019-06-14 13:36 ` Burton, Ross
2019-06-14 13:37 ` Alexander Kanavin
2019-06-17 9:35 ` Marco Felsch
2019-06-17 11:21 ` Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2348016a0867fd986bbe4965dcb88a5b652055f.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=m.felsch@pengutronix.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox