Re: [PATCH 1/1] rpm: remove dbus dependency for rpm-native

[ChenQi <Qi.Chen@windriver.com>]

On 04/05/2018 05:16 PM, Alexander Kanavin wrote:
> On 04/04/2018 02:32 PM, Alexander Kanavin wrote:
>>> +# dbus dependency is deliberately omitted for rpm-native to prevent 
>>> it from attempting to
>>> +# inhibit shutdown via session dbus, even when some layer enables 
>>> plugins support for rpm-native.
>>> +DEPENDS_remove_class-native = "dbus"
>>> +
>>>   inherit autotools gettext pkgconfig python3native
>>>   export PYTHON_ABI
>>> @@ -63,7 +67,7 @@ EXTRA_OECONF_append_libc-musl = " --disable-nls"
>>>   #
>>>   # --localstatedir prevents rpm from writing its database to native 
>>> sysroot when building images
>>>   #
>>> -# Also disable plugins, so that rpm doesn't attempt to inhibit 
>>> shutdown via session dbus
>>> +# Disable plugins for rpm-native.
>>>   EXTRA_OECONF_append_class-native = " --sysconfdir=/etc 
>>> --localstatedir=/var --disable-plugins"
>>
>>
>> This should definitely be a PACKAGECONFIG option. Actually, two 
>> different options: "plugins" (pulls in dbus) and "plugins-native" 
>> (does not pull in dbus). Then both can be enabled for target and 
>> native, respectively.
>
> Actually, no, neither of these ideas is correct. If dbus is removed 
> from explicit dependencies, that does not guarantee that it will not 
> get pulled into rpm sysroot by something else that rpm depends on. You 
> need to either patch configure.ac in rpm source code to add an 
> explicit enable/disable-dbus switch, or to enable plugins in all 
> cases, and remove the unneeded plugin at do_install tim when building 
> rpm-native.
>
> Alex
>
Hi Alex,

Thanks for your advice.
I've sent out a new patch, which adds dbus option to configure.ac and 
then disables it for rpm-native.

Best Regards,
Chen Qi