Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Chen Qi <Qi.Chen@windriver.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] rpm: remove dbus dependency for rpm-native
Date: Thu, 5 Apr 2018 12:16:52 +0300	[thread overview]
Message-ID: <eeaa06cb-34e8-4b94-ee71-047d26894372@linux.intel.com> (raw)
In-Reply-To: <11a298c3-7fed-c73e-be12-0ed099fca145@linux.intel.com>

On 04/04/2018 02:32 PM, Alexander Kanavin wrote:
>> +# dbus dependency is deliberately omitted for rpm-native to prevent 
>> it from attempting to
>> +# inhibit shutdown via session dbus, even when some layer enables 
>> plugins support for rpm-native.
>> +DEPENDS_remove_class-native = "dbus"
>> +
>>   inherit autotools gettext pkgconfig python3native
>>   export PYTHON_ABI
>> @@ -63,7 +67,7 @@ EXTRA_OECONF_append_libc-musl = " --disable-nls"
>>   #
>>   # --localstatedir prevents rpm from writing its database to native 
>> sysroot when building images
>>   #
>> -# Also disable plugins, so that rpm doesn't attempt to inhibit 
>> shutdown via session dbus
>> +# Disable plugins for rpm-native.
>>   EXTRA_OECONF_append_class-native = " --sysconfdir=/etc 
>> --localstatedir=/var --disable-plugins"
> 
> 
> This should definitely be a PACKAGECONFIG option. Actually, two 
> different options: "plugins" (pulls in dbus) and "plugins-native" (does 
> not pull in dbus). Then both can be enabled for target and native, 
> respectively.

Actually, no, neither of these ideas is correct. If dbus is removed from 
explicit dependencies, that does not guarantee that it will not get 
pulled into rpm sysroot by something else that rpm depends on. You need 
to either patch configure.ac in rpm source code to add an explicit 
enable/disable-dbus switch, or to enable plugins in all cases, and 
remove the unneeded plugin at do_install tim when building rpm-native.

Alex


  reply	other threads:[~2018-04-05  9:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04 10:45 [PATCH 0/1] rpm: remove dbus dependency for rpm-native Chen Qi
2018-04-04 10:45 ` [PATCH 1/1] " Chen Qi
2018-04-04 11:32   ` Alexander Kanavin
2018-04-05  9:16     ` Alexander Kanavin [this message]
2018-04-08  7:57       ` ChenQi
2018-04-09  6:11         ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eeaa06cb-34e8-4b94-ee71-047d26894372@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=Qi.Chen@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox